Merge pull request 'feat: Add a percentage function to the calculator' (#18 ) from typosaurus/16-add-a-percentage-function-to-the-calculator into main

Reviewed-on: #18
test(sveta): Write tests for percentage function
2026-07-26 21:51:01 +02:00 · 2026-07-26 17:45:06 +00:00 · 2026-07-26 17:44:38 +00:00 · 2026-07-26 19:09:52 +02:00 · 2026-07-26 17:07:10 +00:00 · 2026-07-26 17:06:20 +00:00
2 changed files with 79 additions and 1 deletions
@@ -1,5 +1,8 @@
 # retoor <retoor@molodetz.nl>

+from typing import Sequence, Union
+
+
 def add(left: int, right: int) -> int:
    return left + right

@@ -20,3 +23,19 @@ def clamp(value: int, low: int, high: int) -> int:

 def clamp_to_byte(value: int) -> int:
    return max(0, min(255, value))
+
+
+def variance(values: Sequence[float]) -> float:
+    if not values:
+        raise ValueError
+    mean = sum(values) / len(values)
+    return sum((x - mean) ** 2 for x in values) / len(values)
+
+
+def percentage(value: Union[int, float], total: Union[int, float]) -> float:
+    if total == 0:
+        raise ValueError
+    return (value / total) * 100
+
+
+
@@ -3,7 +3,7 @@
 import math
 import unittest

-from src.calculator import clamp
+from src.calculator import clamp, percentage, variance


 class TestClampFunction(unittest.TestCase):
@@ -61,3 +61,62 @@ class TestClampFunction(unittest.TestCase):
    def test_nan_returns_nan(self) -> None:
        result = clamp(math.nan, 0, 10)
        self.assertTrue(math.isnan(result))
+
+
+class TestPercentageFunction(unittest.TestCase):
+
+    def test_valid_percentage(self) -> None:
+        self.assertEqual(percentage(50, 200), 25.0)
+
+    def test_zero_value(self) -> None:
+        self.assertEqual(percentage(0, 100), 0.0)
+
+    def test_full_value(self) -> None:
+        self.assertEqual(percentage(200, 100), 200.0)
+
+    def test_fractional(self) -> None:
+        self.assertAlmostEqual(percentage(1, 3), 33.333333333333336)
+
+    def test_total_zero(self) -> None:
+        with self.assertRaises(ValueError):
+            percentage(50, 0)
+
+    def test_float_arguments(self) -> None:
+        self.assertEqual(percentage(25.5, 100.0), 25.5)
+
+    def test_negative_value(self) -> None:
+        self.assertEqual(percentage(-50, 200), -25.0)
+
+
+class TestVarianceFunction(unittest.TestCase):
+
+    def test_empty_list_raises_value_error(self) -> None:
+        with self.assertRaises(ValueError):
+            variance([])
+
+    def test_empty_tuple_raises_value_error(self) -> None:
+        with self.assertRaises(ValueError):
+            variance(())
+
+    def test_single_element_returns_zero(self) -> None:
+        self.assertEqual(variance([42.0]), 0.0)
+
+    def test_constant_values_return_zero_variance(self) -> None:
+        self.assertEqual(variance([1.0, 1.0, 1.0]), 0.0)
+
+    def test_population_variance_of_known_set(self) -> None:
+        self.assertEqual(variance([1, 2, 3, 4, 5]), 2.0)
+
+    def test_two_element_variance(self) -> None:
+        self.assertEqual(variance([0, 2]), 1.0)
+
+    def test_integer_inputs_return_float(self) -> None:
+        result = variance([10, 20, 30])
+        self.assertIsInstance(result, float)
+        self.assertEqual(result, 200.0 / 3.0)
+
+    def test_tuple_input_returns_variance(self) -> None:
+        self.assertEqual(variance((1, 2, 3, 4, 5)), 2.0)
+
+
+
Author	SHA1	Message	Date
typosaurus	2ee246fad6	Merge pull request 'feat: Add a percentage function to the calculator' (#18 ) from typosaurus/16-add-a-percentage-function-to-the-calculator into main Reviewed-on: #18	2026-07-26 21:51:01 +02:00
typosaurus	c6ff93c764	test(sveta): Write tests for percentage function Outcome: done Changed: tests/test_calculator.py:1 (import), tests/test_calculator.py:66-96 (new TestPercentageFunction class) Verified by: `make verify` — exit 0, Ran 23 tests, OK Findings: tests/test_calculator.py:66-96 — TestPercentageFunction class added with 7 test methods (valid_percentage, zero_value, full_value, fractional, total_zero, float_arguments, negative_value). All 23 tests pass. Open: none Confidence: high — all acceptance criteria met, verification passed Typosaurus-Run: ff52a86851934fd293e2f4493c5a9a46 Typosaurus-Node: 7edce3239d434d36aed06535aae0d0ad Typosaurus-Agent: @sveta Refs: #16	2026-07-26 17:45:06 +00:00
typosaurus	e11ca4b376	feat(nadia): Implement percentage function in calculator.py Outcome: done Changed: src/calculator.py:1 (import Union), src/calculator.py:31-34 (percentage function) Verified by: `make verify` — exit 0, all 16 tests passed, compilation clean Findings: src/calculator.py:31-34 — percentage(value: Union[int, float], total: Union[int, float]) -> float added, returning (value/total)*100, raising ValueError on total==0 Open: none Confidence: high — all acceptance criteria met, verification passed Typosaurus-Run: ff52a86851934fd293e2f4493c5a9a46 Typosaurus-Node: baf30844321745fb8a1aabe91a33823b Typosaurus-Agent: @nadia Refs: #16	2026-07-26 17:44:38 +00:00
typosaurus	9bc1788ae2	Merge pull request 'feat: Add a variance function to the calculator' (#20 ) from typosaurus/19-add-a-variance-function-to-the-calculator into main Reviewed-on: #20	2026-07-26 19:09:52 +02:00
typosaurus	2f86b1c6cc	test(sveta): Write tests for variance function Outcome: done Changed: tests/test_calculator.py:2, tests/test_calculator.py:67-97 Verified by: make verify — exit 0, all 24 tests pass (8 variance tests OK) Findings: Import line updated to include variance from src.calculator at tests/test_calculator.py:4 Findings: TestVarianceFunction class added at tests/test_calculator.py:67-97 with 8 test methods Findings: Empty sequence coverage split into list and tuple cases at lines 69-76 Findings: Single element returns 0.0 at line 78 Findings: Constant values return 0.0 at line 81 Findings: Known set [1,2,3,4,5] yields variance 2.0 at line 84 Findings: Two-element edge case [0,2] yields variance 1.0 at line 87 Findings: Integer inputs produce float result at line 90 Findings: Tuple input accepted as Sequence at line 95 Findings: All patterns match existing test conventions — no comments, no docstrings, full type annotations, proper header Open: none Confidence: high — all acceptance criteria covered, pattern-consistent, verified pass Typosaurus-Run: 918d38b1535b44bea9a86b82deae5233 Typosaurus-Node: 3f6d4a888da94bb99d585efb53106ebd Typosaurus-Agent: @sveta Refs: #19	2026-07-26 17:07:10 +00:00
typosaurus	3c5079a9d8	feat(nadia): Implement variance function in calculator.py Outcome: done Changed: src/calculator.py:3, src/calculator.py:33-37 Verified by: python3 -m compileall -q src tests && python3 -m unittest discover -s tests -q — exit 0, compilation passed, 16 tests pass, smoke test confirms correctness Findings: from typing import Sequence added at line 3 of src/calculator.py Findings: variance(values: Sequence[float]) -> float added at lines 33-37 of src/calculator.py Findings: Population variance formula implemented: sum of squared deviations from mean divided by N Findings: Empty sequence raises bare ValueError matching existing clamp convention Findings: Single-element sequence returns 0.0 Findings: File header retoor line preserved Findings: Full type annotations present, no comments or docstrings Open: Test class for variance could be added by sveta Confidence: high - implementation is 5 lines, matches all acceptance criteria, verified by compilation and smoke test Typosaurus-Run: 918d38b1535b44bea9a86b82deae5233 Typosaurus-Node: 50845c1644c5421fb80ab933d382bc90 Typosaurus-Agent: @nadia Refs: #19	2026-07-26 17:06:20 +00:00
typosaurus	078766216d	Merge pull request 'feat: Add a clamp function to the calculator' (#8 ) from typosaurus/7-add-a-clamp-function-to-the-calculator into main Reviewed-on: #8	2026-07-25 19:04:56 +02:00