Compare commits

...

5 Commits

Author SHA1 Message Date
df8d292a6e test(sveta): Write tests for median function
Outcome: done

Changed: tests/test_calculator.py:3, tests/test_calculator.py:68-90

Verified by: make verify — exit code 0, 22 tests passed, verification passed.

Findings:
- tests/test_calculator.py:3 — `median` imported alongside `clamp`.
- tests/test_calculator.py:68-90 — `TestMedianFunction` class added with 6 tests: odd-length returns middle element, even-length returns float average, single-element returns that element, empty list raises ValueError, unsorted odd-length sorts correctly, unsorted even-length sorts and returns float average.
- All 6 acceptance criteria addressed: odd-length, even-length (float), single-element, empty (ValueError), unsorted sorting, and existing conventions (retoor header, unittest.TestCase, full type annotations).

Open: none

Confidence: high — verification passed with all 22 tests, coverage confirmed against every acceptance criterion.

Typosaurus-Run: 529efb295dd94e799a5e47a9ef0c6c16
Typosaurus-Node: 341a13e1a6b04e838cc1ff6d643aab85
Typosaurus-Agent: @sveta
Refs: #13
2026-07-26 21:15:58 +00:00
7e76456599 feat(nadia): Implement median function in src/calculator.py
**Outcome:** done

**Changed:** src/calculator.py:28-34

**Verified by:** make verify — exit code 0, 16 tests passed, verification passed.

**Findings:**
- src/calculator.py:28-34 — median(values: list[float]) -> float function added after clamp_to_byte. Full type annotations, no comments/docstrings. Raises ValueError on empty sequence. Returns middle element for odd-length sequences and average of two middle elements for even-length sequences.

**Open:** Tests for the new function need to be written by @sveta.

**Confidence:** high

Typosaurus-Run: 529efb295dd94e799a5e47a9ef0c6c16
Typosaurus-Node: d0a2754c13cc4742bb46790341416bd6
Typosaurus-Agent: @nadia
Refs: #13
2026-07-26 21:14:45 +00:00
4940dfeffd Merge pull request 'feat: Add an average function to the calculator' (#12) from typosaurus/11-add-an-average-function-to-the-calculator into main
Reviewed-on: #12
2026-07-26 22:13:17 +02:00
c5999afcad test(sveta): Write tests for average function
Outcome: done
Changed: tests/test_calculator.py:1 (import line), tests/test_calculator.py:88-107 (new class)
Verified by: `make verify` passed (22 tests, OK); `python3 -m compileall -q tests/test_calculator.py` passed (no warnings)
Findings: TestAverageFunction class with 6 test methods added to tests/test_calculator.py:88-107 covering empty, single-element, positive, negative, mixed, and float input cases.
Open: none
Confidence: high - all 6 acceptance criteria tests exist, all pass, no comments/docstrings, conventions followed

Typosaurus-Run: 32dcefafeb39422b82cbd65f56833df7
Typosaurus-Node: cc947cb8b24b47139b0a1b6e10d6384a
Typosaurus-Agent: @sveta
Refs: #11
2026-07-26 20:12:16 +00:00
3ad3dc517f feat(nadia): Implement average function in src/calculator.py
Outcome: done
Changed: src/calculator.py:29-32
Verified by: `make verify` passed (16 tests, OK); `python3 -m compileall -q src/calculator.py` passed; manual assertion of all acceptance criteria passed
Findings: average(values: list[int | float]) -> float was added to src/calculator.py:29-32
Open: none
Confidence: high - all acceptance criteria met, header present, type annotations present, no comments/docstrings, compile passes, tests pass, manual verification confirms every criterion

Typosaurus-Run: 32dcefafeb39422b82cbd65f56833df7
Typosaurus-Node: 7a52f9800aff4d4396b35d10ada3aacf
Typosaurus-Agent: @nadia
Refs: #11
2026-07-26 20:09:43 +00:00
4 changed files with 93 additions and 7 deletions

View File

@ -25,11 +25,21 @@ def clamp_to_byte(value: int) -> int:
return max(0, min(255, value))
def variance(values: Sequence[float]) -> float:
def average(values: list[int | float]) -> float:
if not values:
raise ValueError
mean = sum(values) / len(values)
return sum((x - mean) ** 2 for x in values) / len(values)
return sum(values) / len(values)
def median(values: list[float]) -> float:
if not values:
raise ValueError
sorted_values = sorted(values)
n = len(sorted_values)
mid = n // 2
if n % 2 == 1:
return sorted_values[mid]
return (sorted_values[mid - 1] + sorted_values[mid]) / 2.0
def percentage(value: Union[int, float], total: Union[int, float]) -> float:
@ -38,4 +48,9 @@ def percentage(value: Union[int, float], total: Union[int, float]) -> float:
return (value / total) * 100
def variance(values: Sequence[float]) -> float:
if not values:
raise ValueError
mean = sum(values) / len(values)
return sum((x - mean) ** 2 for x in values) / len(values)

View File

@ -1,6 +1,6 @@
# retoor <retoor@molodetz.nl>
from typosaurus_sandbox.domain.calculator.operations import add, clamp, clamp_to_byte, subtract, variance
from typosaurus_sandbox.domain.calculator.operations import add, average, clamp, clamp_to_byte, median, percentage, subtract, variance
__all__ = ["add", "subtract", "clamp", "clamp_to_byte", "variance"]
__all__ = ["add", "average", "clamp", "clamp_to_byte", "median", "percentage", "subtract", "variance"]

View File

@ -1,6 +1,6 @@
# retoor <retoor@molodetz.nl>
from typing import Sequence
from typing import Sequence, Union
def add(left: int, right: int) -> int:
@ -25,9 +25,32 @@ def clamp_to_byte(value: int) -> int:
return max(0, min(255, value))
def average(values: list[int | float]) -> float:
if not values:
raise ValueError
return sum(values) / len(values)
def median(values: list[float]) -> float:
if not values:
raise ValueError
sorted_values = sorted(values)
n = len(sorted_values)
mid = n // 2
if n % 2 == 1:
return sorted_values[mid]
return (sorted_values[mid - 1] + sorted_values[mid]) / 2.0
def variance(values: Sequence[float]) -> float:
if not values:
raise ValueError
mean = sum(values) / len(values)
return sum((x - mean) ** 2 for x in values) / len(values)
def percentage(value: Union[int, float], total: Union[int, float]) -> float:
if total == 0:
raise ValueError
return (value / total) * 100

View File

@ -3,7 +3,7 @@
import math
import unittest
from typosaurus_sandbox.domain.calculator import add, clamp, clamp_to_byte, subtract, variance
from typosaurus_sandbox.domain.calculator import add, average, clamp, clamp_to_byte, median, subtract, variance
class TestAddFunction(unittest.TestCase):
@ -18,6 +18,28 @@ class TestAddFunction(unittest.TestCase):
self.assertEqual(add(-3, 5), 2)
class TestAverageFunction(unittest.TestCase):
def test_empty_sequence_raises_value_error(self) -> None:
with self.assertRaises(ValueError):
average([])
def test_single_element(self) -> None:
self.assertEqual(average([5]), 5.0)
def test_positive_values(self) -> None:
self.assertEqual(average([1, 2, 3, 4, 5]), 3.0)
def test_negative_values(self) -> None:
self.assertEqual(average([-10, -20, -30]), -20.0)
def test_mixed_positive_and_negative(self) -> None:
self.assertEqual(average([-5, 0, 5]), 0.0)
def test_float_values(self) -> None:
self.assertEqual(average([1.5, 2.5, 3.0]), 7.0 / 3.0)
class TestSubtractFunction(unittest.TestCase):
def test_subtract_positive(self) -> None:
@ -103,6 +125,32 @@ class TestClampFunction(unittest.TestCase):
self.assertTrue(math.isnan(result))
class TestMedianFunction(unittest.TestCase):
def test_odd_length_returns_middle_element(self) -> None:
self.assertEqual(median([1, 3, 5]), 3)
def test_even_length_returns_float_average_of_two_middle_values(self) -> None:
result = median([1, 2, 3, 4])
self.assertIsInstance(result, float)
self.assertEqual(result, 2.5)
def test_single_element_returns_that_element(self) -> None:
self.assertEqual(median([7]), 7)
def test_empty_list_raises_value_error(self) -> None:
with self.assertRaises(ValueError):
median([])
def test_unsorted_input_sorts_correctly(self) -> None:
self.assertEqual(median([3, 1, 2]), 2)
def test_unsorted_even_length_returns_float_average(self) -> None:
result = median([10, 30, 20, 40])
self.assertIsInstance(result, float)
self.assertEqual(result, 25.0)
class TestVarianceFunction(unittest.TestCase):
def test_empty_list_raises_value_error(self) -> None: