Commit Graph

15 Commits

Author SHA1 Message Date
63965696f4 feat(zoya): Review scaffolding against acceptance criteria
## Review Verdict — Scaffolding against acceptance criteria

### Per-criterion assessment

| # | Criterion | Evidence | Verdict |
|---|-----------|----------|---------|
| 1 | `requirements.txt` lists Flask | `requirements.txt:1` — `Flask>=3.0,<4.0` | **PASS** |
| 2 | `app/__init__.py` exists with header | `app/__init__.py:1` — `# retoor <retoor@molodetz.nl>` present | **PASS** |
| 3 | Makefile has a `run` target | `Makefile:5-6` — `run:\n\tFLASK_APP=app flask run` — uses package name `app` which Flask resolves to `app.__init__:app`, correct | **PASS** |
| 4 | `make verify` passes | Exit 0, 16 tests OK, "verification passed" printed, no stderr | **PASS** |
| 5 | `.gitignore` excludes common Flask artifacts | `.gitignore:1-2` — `__pycache__/` and `*.pyc` cover Python bytecode and cache dirs | **PASS** |
| 6 | No TODO, placeholder, or stub | Zero matches for `TODO|FIXME|placeholder|stub|XXX` across `.py`, `Makefile`, `README.md`, `requirements.txt` | **PASS** |
| 7 | No warning introduced | `make verify` produced zero stderr lines, no warnings in output | **PASS** |

### Findings

- `requirements.txt:1` — `Flask>=3.0,<4.0` added as dependency.
- `app/__init__.py:1-5` — package header, Flask import, and app instantiation all present.
- `Makefile:5-6` — run target uses `FLASK_APP=app flask run` (correct, points to `app` package).
- `make verify` — exit 0, 16 tests pass, no warnings.
- `.gitignore` — covers `__pycache__/` and `*.pyc`.
- No TODO, FIXME, placeholder, stub, or warning

Typosaurus-Run: b3f34882127d437e93c240def12065ad
Typosaurus-Node: 2ea09ca06d014fc6b74ce6c323ad78ff
Typosaurus-Agent: @zoya
Refs: #9
2026-07-26 15:10:14 +02:00
7fb55c03fc feat(nadia): Add run target and update project metadata
Outcome: done
Changed: Makefile:5-6; app/__init__.py:3-5; README.md:5-9
Verified by: make verify — exit 0, 16 tests OK, verification passed
Findings: Makefile run target added at ./Makefile:5-6 using FLASK_APP=app flask run
app/__init__.py updated at ./app/__init__.py:3-5 with Flask app instance
README.md updated at ./README.md:5-9 with web app run instructions
.gitignore already covers __pycache__/ and *.pyc, no changes needed
Open: none
Confidence: high - all three acceptance criteria met, verify passes, no warnings or TODOs introduced

Typosaurus-Run: b3f34882127d437e93c240def12065ad
Typosaurus-Node: e17f9f081d474231a32bd81836d2b0bc
Typosaurus-Agent: @nadia
Refs: #9
2026-07-26 15:09:49 +02:00
bf0e3e133f feat(nadia): Add Flask dependency and create app package
Outcome: done
Changed: requirements.txt:1; app/__init__.py:1
Verified by: make verify — exit 0, 16 tests OK, verification passed
Findings: requirements.txt created at /workspace/requirements.txt, lists Flask>=3.0,<4.0
app/__init__.py created at /workspace/app/__init__.py with header '# retoor <retoor@molodetz.nl>'
make verify passes after adding Flask dependency and app package
Open: none
Confidence: high - both acceptance criteria met and verification passes

Typosaurus-Run: b3f34882127d437e93c240def12065ad
Typosaurus-Node: 70e1371eede04740955ad247415e11c6
Typosaurus-Agent: @nadia
Refs: #9
2026-07-26 15:08:49 +02:00
078766216d Merge pull request 'feat: Add a clamp function to the calculator' (#8) from typosaurus/7-add-a-clamp-function-to-the-calculator into main
Reviewed-on: #8
2026-07-25 19:04:56 +02:00
8605a8c596 test(sveta): Write clamp tests
Outcome: done
Changed: tests/__init__.py:1, tests/test_calculator.py:1-86
Verified by: `make verify` — exit 0, "verification passed", Ran 16 tests in 0.001s, OK
Findings: tests/ directory created at ./tests/ with __init__.py (header only) and test_calculator.py (16 tests for clamp).
Findings: All 16 clamp tests pass under `make verify`: value below low, above high, in range, equals low, equals high, low>high ValueError, negative values, float below/above/in-range/equals-boundary, float low>high ValueError, large values, -inf/inf boundaries, and NaN.
Findings: clamp is typed as (value: int, low: int, high: int) -> int; float and inf/NaN tests pass because Python does not enforce type hints at runtime.
Open: none
Confidence: high - all 16 tests pass, all acceptance criteria covered, make verify passes

Typosaurus-Run: 5b5c36bf38254bf4bfcdbde317991a5a
Typosaurus-Node: 56f03705c3d64023ba102d3aa3169ef2
Typosaurus-Agent: @sveta
Refs: #7
2026-07-25 19:04:03 +02:00
c7f0712d12 feat(nadia): Implement clamp function
**Outcome:** done
**Changed:** src/calculator.py:11-18
**Verified by:** python3 -m compileall -q src — passed; python3 -c with five acceptance assertions — passed. make verify fails because tests/ directory does not exist.
**Findings:** clamp(value: int, low: int, high: int) -> int added at src/calculator.py:11 with no docstrings or comments. File header at src/calculator.py:1 is present. All functions use full int type annotations.
**Open:** Test writer (sveta) should create tests/ directory and add unit tests for clamp.
**Confidence:** high

Typosaurus-Run: 5b5c36bf38254bf4bfcdbde317991a5a
Typosaurus-Node: bf41377d70c446b1b80b9e058fe81fb8
Typosaurus-Agent: @nadia
Refs: #7
2026-07-25 19:04:03 +02:00
65ce7f1994 feat: add clamp_to_byte at the end of calculator 2026-07-25 19:01:02 +02:00
f5363514bf chore: reset calculator to a clean baseline 2026-07-25 18:58:10 +02:00
ff830c6fb8 feat: add gcd at the end of the file 2026-07-25 18:51:44 +02:00
cb4c5516ad feat: add modulo and ignore build artifacts 2026-07-25 18:49:12 +02:00
d5861fb2e3 Merge pull request 'feat: Add multiply and divide to the calculator' (#3) from typosaurus/2-add-multiply-and-divide-to-the-calculator into main
Reviewed-on: #3
2026-07-25 17:22:52 +02:00
8f7f09f44a test(sveta): Write tests for multiply and divide
Outcome: done
Changed: tests/test_calculator.py:1-65, Makefile:1
Verified by: `make verify` — exit 0, "Ran 16 tests in 0.000s ... OK"
Findings: tests/test_calculator.py exists with 16 test methods covering add, subtract, multiply (positive/negative/zero), divide (positive/negative/zero-numerator/floor), and divide-by-zero ValueError.
           make verify now runs both compileall (src + tests) and unittest discover, all passing.
Open: none
Confidence: high — all 16 tests pass; coverage spans all acceptance criteria including multiply edge cases (positive, negative, zero) and divide edge cases (positive, negative, zero numerator, divide-by-zero).

Typosaurus-Run: d9404e45783a42b586e07fc0342eee5c
Typosaurus-Node: 00f8d57fc2964dc9bf5ae68ad25a6e18
Typosaurus-Agent: @sveta
Refs: #2
2026-07-25 17:08:53 +02:00
3f2a5c8a07 feat(nadia): Implement multiply and divide in calculator.py
Outcome: done
Changed: src/calculator.py:11-19
Verified by: `make verify` — exit 0, "verification passed"
Findings: src/calculator.py now defines multiply(left: int, right: int) -> int and divide(left: int, right: int) -> int.
           divide raises ValueError('division by zero') when the divisor is zero, using integer floor division (//) to preserve the int return type.
Open: none
Confidence: high — both functions added, header preserved, no comments/docstrings, full type annotations, verify passed.

Typosaurus-Run: d9404e45783a42b586e07fc0342eee5c
Typosaurus-Node: 430bbdd86efb4f16a1c90433f0667e6b
Typosaurus-Agent: @nadia
Refs: #2
2026-07-25 17:08:02 +02:00
380ac7f40f chore: seed sandbox project 2026-07-25 16:58:41 +02:00
ba015bf790 Initial commit 2026-07-25 16:58:02 +02:00