retoorandClaude Sonnet 5
3c69de9d55
Happy 404: an HTML 404 (unmatched route, or an explicit not-found inside a
real route) now renders a random existing post instead of the error page,
using the exact same context builder as a real post view. Toggle is the
happy_404_enabled site setting (default on, /admin/settings); JSON/API
requests and a handful of excluded prefixes are never affected. The pool of
candidate slugs is cached in-process and resampled periodically so it stays
fast and eventually cycles the whole posts table; on any internal failure it
falls straight through to the real 404 page.
Applying this everywhere surfaced ~60 existing tests that asserted a literal
404 for a legitimate resource-not-found flow (deleted post, unknown
container, wrong project slug, etc.) - each now disables the setting for the
duration of that specific check and restores it after, so the underlying
not-found behavior stays covered independently of the new feature.
Post page also gained, all built on the same shared post_page_context() so
they render identically on both a real post and a happy-404 page:
- A left sidebar (three separate cards, matching /feed's sidebar-card
convention) for "Gists from {author}", "Projects from {author}" (private
projects filtered through the normal visibility check), and "Related
Discussions" - each cached per author and invalidated on create/edit/
delete so new content shows up immediately.
- A right column reusing /feed's exact Daily Topic widget class for up to
three "Featured" articles (the existing but previously-unused `featured`
news flag), cached as a pool with per-request random sampling.
- A "Next post -> " link beside "Back to Feed", pointing at the next older
post site-wide (blocked authors skipped). Wired through the same next_url
mechanism already used for listing pagination, so it emits a real
backend-rendered <link rel="next"> tag for SEO, not just a visible link.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BWJy6PrMMt5hwWxQwia2rd
111 lines
3.4 KiB
Python
111 lines
3.4 KiB
Python
# retoor <retoor@molodetz.nl>
|
|
|
|
import json
|
|
import time
|
|
import pytest
|
|
from tests.conftest import BASE_URL, CACHE_VERSION_PROPAGATION_SECONDS
|
|
from devplacepy.database import get_table, set_setting
|
|
from devplacepy.services.jobs import queue
|
|
|
|
|
|
@pytest.fixture(scope="module", autouse=True)
|
|
def _disable_happy_404(app_server):
|
|
set_setting("happy_404_enabled", "0")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
|
yield
|
|
set_setting("happy_404_enabled", "1")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
|
def _seed_job(uid="test-fork-uid-001"):
|
|
jobs = get_table("jobs")
|
|
jobs.upsert(
|
|
{
|
|
"uid": uid,
|
|
"kind": "fork",
|
|
"status": "done",
|
|
"payload": json.dumps(
|
|
{"source_project_uid": "src-001", "title": "Test Fork"}
|
|
),
|
|
"result": json.dumps(
|
|
{
|
|
"project_uid": "forked-project-001",
|
|
"project_url": "/projects/forked-project-001",
|
|
"source_project_uid": "src-001",
|
|
}
|
|
),
|
|
"preferred_name": "Test Fork",
|
|
"item_count": 3,
|
|
"owner_kind": "user",
|
|
"owner_uid": "test-owner-001",
|
|
"error": None,
|
|
"created_at": "2026-06-12T00:00:00+00:00",
|
|
"completed_at": "2026-06-12T00:05:00+00:00",
|
|
},
|
|
["uid"],
|
|
)
|
|
return uid
|
|
|
|
|
|
def test_fork_status_returns_job_details(page, app_server):
|
|
uid = _seed_job()
|
|
resp = page.request.get(f"{BASE_URL}/forks/{uid}")
|
|
assert resp.status == 200
|
|
data = resp.json()
|
|
assert data["uid"] == uid
|
|
assert data["kind"] == "fork"
|
|
assert data["status"] == "done"
|
|
assert data["project_uid"] == "forked-project-001"
|
|
assert data["project_url"] == "/projects/forked-project-001"
|
|
assert data["source_project_uid"] == "src-001"
|
|
assert data["item_count"] == 3
|
|
assert data["preferred_name"] == "Test Fork"
|
|
assert data["error"] is None
|
|
assert data["created_at"] is not None
|
|
assert data["completed_at"] is not None
|
|
|
|
|
|
def test_fork_status_unknown_returns_404(page, app_server):
|
|
resp = page.request.get(f"{BASE_URL}/forks/nonexistent-uid")
|
|
assert resp.status == 404
|
|
|
|
|
|
def test_fork_status_non_fork_kind_returns_404(page, app_server):
|
|
jobs = get_table("jobs")
|
|
jobs.upsert(
|
|
{
|
|
"uid": "non-fork-uid",
|
|
"kind": "zip",
|
|
"status": "pending",
|
|
"payload": json.dumps({}),
|
|
},
|
|
["uid"],
|
|
)
|
|
resp = page.request.get(f"{BASE_URL}/forks/non-fork-uid")
|
|
assert resp.status == 404
|
|
|
|
|
|
def test_fork_status_pending_shows_no_project_fields(page, app_server):
|
|
uid = "pending-fork-001"
|
|
jobs = get_table("jobs")
|
|
jobs.upsert(
|
|
{
|
|
"uid": uid,
|
|
"kind": "fork",
|
|
"status": "pending",
|
|
"payload": json.dumps(
|
|
{"source_project_uid": "src-002", "title": "Pending Fork"}
|
|
),
|
|
"preferred_name": "Pending Fork",
|
|
"item_count": 0,
|
|
"created_at": "2026-06-12T00:00:00+00:00",
|
|
},
|
|
["uid"],
|
|
)
|
|
resp = page.request.get(f"{BASE_URL}/forks/{uid}")
|
|
assert resp.status == 200
|
|
data = resp.json()
|
|
assert data["uid"] == uid
|
|
assert data["status"] == "pending"
|
|
assert data["project_uid"] is None
|
|
assert data["project_url"] is None
|
|
assert data["completed_at"] is None
|