retoorandClaude Sonnet 5
3c69de9d55
Happy 404: an HTML 404 (unmatched route, or an explicit not-found inside a
real route) now renders a random existing post instead of the error page,
using the exact same context builder as a real post view. Toggle is the
happy_404_enabled site setting (default on, /admin/settings); JSON/API
requests and a handful of excluded prefixes are never affected. The pool of
candidate slugs is cached in-process and resampled periodically so it stays
fast and eventually cycles the whole posts table; on any internal failure it
falls straight through to the real 404 page.
Applying this everywhere surfaced ~60 existing tests that asserted a literal
404 for a legitimate resource-not-found flow (deleted post, unknown
container, wrong project slug, etc.) - each now disables the setting for the
duration of that specific check and restores it after, so the underlying
not-found behavior stays covered independently of the new feature.
Post page also gained, all built on the same shared post_page_context() so
they render identically on both a real post and a happy-404 page:
- A left sidebar (three separate cards, matching /feed's sidebar-card
convention) for "Gists from {author}", "Projects from {author}" (private
projects filtered through the normal visibility check), and "Related
Discussions" - each cached per author and invalidated on create/edit/
delete so new content shows up immediately.
- A right column reusing /feed's exact Daily Topic widget class for up to
three "Featured" articles (the existing but previously-unused `featured`
news flag), cached as a pool with per-request random sampling.
- A "Next post -> " link beside "Back to Feed", pointing at the next older
post site-wide (blocked authors skipped). Wired through the same next_url
mechanism already used for listing pagination, so it emits a real
backend-rendered <link rel="next"> tag for SEO, not just a visible link.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BWJy6PrMMt5hwWxQwia2rd
119 lines
3.9 KiB
Python
119 lines
3.9 KiB
Python
# retoor <retoor@molodetz.nl>
|
|
|
|
import time
|
|
|
|
import requests
|
|
from playwright.sync_api import expect
|
|
from tests.conftest import BASE_URL, CACHE_VERSION_PROPAGATION_SECONDS
|
|
from devplacepy.database import get_table, set_setting
|
|
|
|
USER_INPUT = '#cm-admin-create-form input[data-search="user"]'
|
|
USER_OPTIONS = '#cm-admin-create-form [data-suggest="user"] li[data-value]'
|
|
RUN_AS_HIDDEN = '#cm-admin-create-form input[name="run_as_uid"]'
|
|
|
|
|
|
def _open_user_search(page):
|
|
page.goto(f"{BASE_URL}/admin/containers", wait_until="domcontentloaded")
|
|
page.click('[data-modal="cm-admin-create-modal"]')
|
|
inp = page.locator(USER_INPUT)
|
|
inp.wait_for(state="visible")
|
|
inp.fill("test")
|
|
options = page.locator(USER_OPTIONS)
|
|
options.first.wait_for(state="visible")
|
|
return inp, options
|
|
|
|
|
|
def test_containers_admin_page_loads(alice, app_server):
|
|
page, user = alice
|
|
page.goto(f"{BASE_URL}/admin/containers", wait_until="domcontentloaded")
|
|
assert page.is_visible(".admin-toolbar h2:has-text('Containers')")
|
|
|
|
|
|
def test_container_instance_page_404_for_missing(alice, app_server):
|
|
page, _ = alice
|
|
set_setting("happy_404_enabled", "0")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
|
try:
|
|
page.goto(f"{BASE_URL}/admin/containers/nonexistent", wait_until="domcontentloaded")
|
|
assert page.is_visible("text=Not Found") or page.is_visible("text=404")
|
|
finally:
|
|
set_setting("happy_404_enabled", "1")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
|
|
|
|
|
def test_user_search_arrow_keys_highlight_and_enter_selects(alice, seeded_db):
|
|
page, _ = alice
|
|
inp, options = _open_user_search(page)
|
|
count = options.count()
|
|
assert count >= 1
|
|
|
|
inp.press("ArrowDown")
|
|
expect(options.nth(0)).to_have_class("cm-suggest-active")
|
|
|
|
target = options.nth(0)
|
|
if count >= 2:
|
|
inp.press("ArrowDown")
|
|
expect(options.nth(1)).to_have_class("cm-suggest-active")
|
|
expect(options.nth(0)).not_to_have_class("cm-suggest-active")
|
|
target = options.nth(1)
|
|
|
|
label = target.get_attribute("data-label")
|
|
inp.press("Enter")
|
|
|
|
expect(page.locator(USER_OPTIONS)).to_have_count(0)
|
|
assert inp.input_value() == label
|
|
assert page.locator(RUN_AS_HIDDEN).input_value() != ""
|
|
|
|
|
|
def test_user_search_arrow_up_wraps_to_last(alice, seeded_db):
|
|
page, _ = alice
|
|
inp, options = _open_user_search(page)
|
|
if options.count() < 2:
|
|
return
|
|
last = options.count() - 1
|
|
inp.press("ArrowUp")
|
|
expect(options.nth(last)).to_have_class("cm-suggest-active")
|
|
|
|
|
|
def test_user_search_tab_navigates_options(alice, seeded_db):
|
|
page, _ = alice
|
|
inp, options = _open_user_search(page)
|
|
inp.press("Tab")
|
|
expect(options.nth(0)).to_have_class("cm-suggest-active")
|
|
if options.count() >= 2:
|
|
inp.press("Tab")
|
|
expect(options.nth(1)).to_have_class("cm-suggest-active")
|
|
|
|
|
|
def test_user_search_tab_past_last_selects_and_releases(alice, seeded_db):
|
|
page, _ = alice
|
|
inp, options = _open_user_search(page)
|
|
count = options.count()
|
|
label = options.nth(count - 1).get_attribute("data-label")
|
|
for _ in range(count + 1):
|
|
inp.press("Tab")
|
|
|
|
expect(page.locator(USER_OPTIONS)).to_have_count(0)
|
|
assert inp.input_value() == label
|
|
assert page.locator(RUN_AS_HIDDEN).input_value() != ""
|
|
assert not inp.evaluate("el => el === document.activeElement")
|
|
|
|
|
|
def test_user_search_escape_closes_without_selecting(alice, seeded_db):
|
|
page, _ = alice
|
|
inp, _ = _open_user_search(page)
|
|
inp.press("Escape")
|
|
expect(page.locator(USER_OPTIONS)).to_have_count(0)
|
|
assert page.locator(RUN_AS_HIDDEN).input_value() == ""
|
|
|
|
|
|
def test_user_search_has_combobox_aria(alice, seeded_db):
|
|
page, _ = alice
|
|
inp, options = _open_user_search(page)
|
|
assert inp.get_attribute("role") == "combobox"
|
|
assert inp.get_attribute("aria-expanded") == "true"
|
|
inp.press("ArrowDown")
|
|
active = inp.get_attribute("aria-activedescendant")
|
|
assert active
|
|
assert options.nth(0).get_attribute("id") == active
|