retoorandClaude Sonnet 5
3c69de9d55
Happy 404: an HTML 404 (unmatched route, or an explicit not-found inside a
real route) now renders a random existing post instead of the error page,
using the exact same context builder as a real post view. Toggle is the
happy_404_enabled site setting (default on, /admin/settings); JSON/API
requests and a handful of excluded prefixes are never affected. The pool of
candidate slugs is cached in-process and resampled periodically so it stays
fast and eventually cycles the whole posts table; on any internal failure it
falls straight through to the real 404 page.
Applying this everywhere surfaced ~60 existing tests that asserted a literal
404 for a legitimate resource-not-found flow (deleted post, unknown
container, wrong project slug, etc.) - each now disables the setting for the
duration of that specific check and restores it after, so the underlying
not-found behavior stays covered independently of the new feature.
Post page also gained, all built on the same shared post_page_context() so
they render identically on both a real post and a happy-404 page:
- A left sidebar (three separate cards, matching /feed's sidebar-card
convention) for "Gists from {author}", "Projects from {author}" (private
projects filtered through the normal visibility check), and "Related
Discussions" - each cached per author and invalidated on create/edit/
delete so new content shows up immediately.
- A right column reusing /feed's exact Daily Topic widget class for up to
three "Featured" articles (the existing but previously-unused `featured`
news flag), cached as a pool with per-request random sampling.
- A "Next post -> " link beside "Back to Feed", pointing at the next older
post site-wide (blocked authors skipped). Wired through the same next_url
mechanism already used for listing pagination, so it emits a real
backend-rendered <link rel="next"> tag for SEO, not just a visible link.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BWJy6PrMMt5hwWxQwia2rd
44 lines
1.2 KiB
Python
44 lines
1.2 KiB
Python
# retoor <retoor@molodetz.nl>
|
|
|
|
import time
|
|
|
|
import pytest
|
|
import requests
|
|
from devplacepy.database import set_setting
|
|
from tests.conftest import BASE_URL, CACHE_VERSION_PROPAGATION_SECONDS
|
|
|
|
|
|
@pytest.fixture(scope="module", autouse=True)
|
|
def _disable_happy_404(app_server):
|
|
set_setting("happy_404_enabled", "0")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
|
yield
|
|
set_setting("happy_404_enabled", "1")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
|
|
|
|
|
def test_proxy_unknown_slug_returns_404(app_server):
|
|
r = requests.get(f"{BASE_URL}/p/nonexistent-slug", allow_redirects=False)
|
|
assert r.status_code == 404
|
|
|
|
|
|
def test_proxy_unknown_slug_json(app_server):
|
|
r = requests.get(
|
|
f"{BASE_URL}/p/nonexistent-slug",
|
|
headers={"X-Requested-With": "fetch"},
|
|
allow_redirects=False,
|
|
)
|
|
assert r.status_code == 404
|
|
|
|
|
|
def test_proxy_unknown_slug_with_path(app_server):
|
|
r = requests.get(
|
|
f"{BASE_URL}/p/nonexistent-slug/some/path", allow_redirects=False
|
|
)
|
|
assert r.status_code == 404
|
|
|
|
|
|
def test_proxy_post_unknown_slug(app_server):
|
|
r = requests.post(f"{BASE_URL}/p/nonexistent-slug", allow_redirects=False)
|
|
assert r.status_code == 404
|