retoorandClaude Sonnet 5
3c69de9d55
Happy 404: an HTML 404 (unmatched route, or an explicit not-found inside a
real route) now renders a random existing post instead of the error page,
using the exact same context builder as a real post view. Toggle is the
happy_404_enabled site setting (default on, /admin/settings); JSON/API
requests and a handful of excluded prefixes are never affected. The pool of
candidate slugs is cached in-process and resampled periodically so it stays
fast and eventually cycles the whole posts table; on any internal failure it
falls straight through to the real 404 page.
Applying this everywhere surfaced ~60 existing tests that asserted a literal
404 for a legitimate resource-not-found flow (deleted post, unknown
container, wrong project slug, etc.) - each now disables the setting for the
duration of that specific check and restores it after, so the underlying
not-found behavior stays covered independently of the new feature.
Post page also gained, all built on the same shared post_page_context() so
they render identically on both a real post and a happy-404 page:
- A left sidebar (three separate cards, matching /feed's sidebar-card
convention) for "Gists from {author}", "Projects from {author}" (private
projects filtered through the normal visibility check), and "Related
Discussions" - each cached per author and invalidated on create/edit/
delete so new content shows up immediately.
- A right column reusing /feed's exact Daily Topic widget class for up to
three "Featured" articles (the existing but previously-unused `featured`
news flag), cached as a pool with per-request random sampling.
- A "Next post -> " link beside "Back to Feed", pointing at the next older
post site-wide (blocked authors skipped). Wired through the same next_url
mechanism already used for listing pagination, so it emits a real
backend-rendered <link rel="next"> tag for SEO, not just a visible link.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BWJy6PrMMt5hwWxQwia2rd
139 lines
3.9 KiB
Python
139 lines
3.9 KiB
Python
# retoor <retoor@molodetz.nl>
|
|
|
|
import time
|
|
|
|
import requests
|
|
|
|
from tests.conftest import BASE_URL
|
|
|
|
JSON = {"Accept": "application/json"}
|
|
_counter = [0]
|
|
|
|
|
|
def _unique(prefix="side"):
|
|
_counter[0] += 1
|
|
return f"{prefix}{int(time.time() * 1000)}{_counter[0]}"
|
|
|
|
|
|
def _signup():
|
|
name = _unique("sideuser")
|
|
session = requests.Session()
|
|
session.post(
|
|
f"{BASE_URL}/auth/signup",
|
|
data={
|
|
"username": name,
|
|
"email": f"{name}@t.dev",
|
|
"password": "secret123",
|
|
"confirm_password": "secret123",
|
|
"birth_date": "1990-01-01",
|
|
"accept_terms": "1",
|
|
},
|
|
allow_redirects=True,
|
|
)
|
|
return session, name
|
|
|
|
|
|
def _new_post(session):
|
|
return session.post(
|
|
f"{BASE_URL}/posts/create",
|
|
headers=JSON,
|
|
data={
|
|
"title": _unique("sidepost"),
|
|
"content": "content for the author-sidebar test post",
|
|
"topic": "devlog",
|
|
},
|
|
).json()["data"]
|
|
|
|
|
|
def _new_gist(session, title=None):
|
|
return session.post(
|
|
f"{BASE_URL}/gists/create",
|
|
headers=JSON,
|
|
data={
|
|
"title": title or _unique("sidegist"),
|
|
"description": "a gist used for the author sidebar test",
|
|
"source_code": "print('hi')",
|
|
"language": "python",
|
|
},
|
|
).json()["data"]
|
|
|
|
|
|
def _new_project(session, title=None, is_private=None):
|
|
data = {
|
|
"title": title or _unique("sideproj"),
|
|
"description": "a project used for the author sidebar test",
|
|
"project_type": "software",
|
|
"status": "In Development",
|
|
"platforms": "",
|
|
}
|
|
created = session.post(f"{BASE_URL}/projects/create", headers=JSON, data=data).json()["data"]
|
|
if is_private:
|
|
session.post(
|
|
f"{BASE_URL}/projects/{created['slug']}/private",
|
|
headers=JSON,
|
|
data={"value": "true"},
|
|
)
|
|
return created
|
|
|
|
|
|
def test_post_page_has_no_author_cards_with_nothing_else(app_server):
|
|
session, name = _signup()
|
|
post = _new_post(session)
|
|
r = requests.get(f"{BASE_URL}/posts/{post['slug']}")
|
|
assert r.status_code == 200
|
|
assert f"Gists from {name}" not in r.text
|
|
assert f"Projects from {name}" not in r.text
|
|
|
|
|
|
def test_post_page_shows_author_gists_and_projects(app_server):
|
|
session, name = _signup()
|
|
post = _new_post(session)
|
|
_new_gist(session, title="Alpha Gist")
|
|
_new_project(session, title="Alpha Project")
|
|
|
|
r = requests.get(f"{BASE_URL}/posts/{post['slug']}")
|
|
assert r.status_code == 200
|
|
assert f"Gists from {name}" in r.text
|
|
assert f"Projects from {name}" in r.text
|
|
assert "Alpha Gist" in r.text
|
|
assert "Alpha Project" in r.text
|
|
|
|
|
|
def test_post_page_sidebar_json_parity_and_limit(app_server):
|
|
session, name = _signup()
|
|
post = _new_post(session)
|
|
for i in range(7):
|
|
_new_gist(session, title=f"Gist {i}")
|
|
|
|
r = requests.get(f"{BASE_URL}/posts/{post['slug']}", headers=JSON)
|
|
assert r.status_code == 200
|
|
data = r.json()
|
|
assert len(data["author_gists"]) == 5
|
|
assert data["author_projects"] == []
|
|
|
|
|
|
def test_post_page_hides_private_project_from_stranger(app_server):
|
|
session, name = _signup()
|
|
post = _new_post(session)
|
|
_new_project(session, title="Hidden Project", is_private=True)
|
|
|
|
stranger = requests.Session()
|
|
r = stranger.get(f"{BASE_URL}/posts/{post['slug']}", headers=JSON)
|
|
assert r.status_code == 200
|
|
titles = [p["title"] for p in r.json()["author_projects"]]
|
|
assert "Hidden Project" not in titles
|
|
|
|
|
|
def test_post_page_sidebar_updates_live_after_new_gist(app_server):
|
|
session, name = _signup()
|
|
post = _new_post(session)
|
|
|
|
r0 = requests.get(f"{BASE_URL}/posts/{post['slug']}", headers=JSON)
|
|
assert r0.json()["author_gists"] == []
|
|
|
|
_new_gist(session, title="Just Created Gist")
|
|
|
|
r1 = requests.get(f"{BASE_URL}/posts/{post['slug']}", headers=JSON)
|
|
titles = [g["title"] for g in r1.json()["author_gists"]]
|
|
assert "Just Created Gist" in titles
|