retoorandClaude Sonnet 5
3c69de9d55
Happy 404: an HTML 404 (unmatched route, or an explicit not-found inside a
real route) now renders a random existing post instead of the error page,
using the exact same context builder as a real post view. Toggle is the
happy_404_enabled site setting (default on, /admin/settings); JSON/API
requests and a handful of excluded prefixes are never affected. The pool of
candidate slugs is cached in-process and resampled periodically so it stays
fast and eventually cycles the whole posts table; on any internal failure it
falls straight through to the real 404 page.
Applying this everywhere surfaced ~60 existing tests that asserted a literal
404 for a legitimate resource-not-found flow (deleted post, unknown
container, wrong project slug, etc.) - each now disables the setting for the
duration of that specific check and restores it after, so the underlying
not-found behavior stays covered independently of the new feature.
Post page also gained, all built on the same shared post_page_context() so
they render identically on both a real post and a happy-404 page:
- A left sidebar (three separate cards, matching /feed's sidebar-card
convention) for "Gists from {author}", "Projects from {author}" (private
projects filtered through the normal visibility check), and "Related
Discussions" - each cached per author and invalidated on create/edit/
delete so new content shows up immediately.
- A right column reusing /feed's exact Daily Topic widget class for up to
three "Featured" articles (the existing but previously-unused `featured`
news flag), cached as a pool with per-request random sampling.
- A "Next post -> " link beside "Back to Feed", pointing at the next older
post site-wide (blocked authors skipped). Wired through the same next_url
mechanism already used for listing pagination, so it emits a real
backend-rendered <link rel="next"> tag for SEO, not just a visible link.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BWJy6PrMMt5hwWxQwia2rd
119 lines
3.2 KiB
Python
119 lines
3.2 KiB
Python
# retoor <retoor@molodetz.nl>
|
|
|
|
import time
|
|
|
|
import requests
|
|
|
|
from devplacepy.database import get_table
|
|
from tests.conftest import BASE_URL
|
|
|
|
JSON = {"Accept": "application/json"}
|
|
_counter = [0]
|
|
|
|
|
|
def _unique(prefix="feat"):
|
|
_counter[0] += 1
|
|
return f"{prefix}{int(time.time() * 1000)}{_counter[0]}"
|
|
|
|
|
|
def _signup():
|
|
name = _unique("featuser")
|
|
session = requests.Session()
|
|
session.post(
|
|
f"{BASE_URL}/auth/signup",
|
|
data={
|
|
"username": name,
|
|
"email": f"{name}@t.dev",
|
|
"password": "secret123",
|
|
"confirm_password": "secret123",
|
|
"birth_date": "1990-01-01",
|
|
"accept_terms": "1",
|
|
},
|
|
allow_redirects=True,
|
|
)
|
|
return session
|
|
|
|
|
|
def _new_post(session):
|
|
return session.post(
|
|
f"{BASE_URL}/posts/create",
|
|
headers=JSON,
|
|
data={
|
|
"title": _unique("featpost"),
|
|
"content": "content for the featured topics test post",
|
|
"topic": "devlog",
|
|
},
|
|
).json()["data"]
|
|
|
|
|
|
def _seed_featured_article():
|
|
uid = _unique("featnews")
|
|
get_table("news").insert(
|
|
{
|
|
"uid": uid,
|
|
"title": _unique("Featured Article"),
|
|
"slug": _unique("featured-article"),
|
|
"external_id": uid,
|
|
"status": "published",
|
|
"source_name": "test",
|
|
"url": "https://example.com/article",
|
|
"description": "a featured article for the post-page test",
|
|
"content": "",
|
|
"synced_at": "2024-01-01T00:00:00",
|
|
"grade": 5,
|
|
"ai_grade": 5,
|
|
"show_on_landing": 0,
|
|
"featured": 1,
|
|
"featured_locked": 1,
|
|
"landing_locked": 0,
|
|
"author": "",
|
|
"article_published": "",
|
|
"image_url": "",
|
|
"has_unique_image": 0,
|
|
"deleted_at": None,
|
|
"deleted_by": None,
|
|
}
|
|
)
|
|
return uid
|
|
|
|
|
|
def test_post_page_shows_featured_topics(app_server):
|
|
session = _signup()
|
|
post = _new_post(session)
|
|
_seed_featured_article()
|
|
|
|
r = requests.get(f"{BASE_URL}/posts/{post['slug']}")
|
|
assert r.status_code == 200
|
|
assert 'class="feed-right"' in r.text
|
|
assert "daily-topic-card" in r.text
|
|
|
|
|
|
def test_post_page_json_includes_featured_topics(app_server):
|
|
session = _signup()
|
|
post = _new_post(session)
|
|
_seed_featured_article()
|
|
|
|
r = requests.get(f"{BASE_URL}/posts/{post['slug']}", headers=JSON)
|
|
assert r.status_code == 200
|
|
data = r.json()
|
|
assert "featured_topics" in data
|
|
assert len(data["featured_topics"]) <= 3
|
|
assert all("title" in item for item in data["featured_topics"])
|
|
|
|
|
|
def test_post_page_featured_topics_pick_varies(app_server):
|
|
session = _signup()
|
|
post = _new_post(session)
|
|
for _ in range(6):
|
|
_seed_featured_article()
|
|
|
|
seen = set()
|
|
for _ in range(20):
|
|
r = requests.get(f"{BASE_URL}/posts/{post['slug']}", headers=JSON)
|
|
assert r.status_code == 200
|
|
titles = tuple(item["title"] for item in r.json()["featured_topics"])
|
|
assert len(titles) == 3
|
|
assert len(set(titles)) == 3
|
|
seen.add(titles)
|
|
assert len(seen) > 1, "featured topics never varied across 20 requests"
|