retoorandClaude Sonnet 5
3c69de9d55
Happy 404: an HTML 404 (unmatched route, or an explicit not-found inside a
real route) now renders a random existing post instead of the error page,
using the exact same context builder as a real post view. Toggle is the
happy_404_enabled site setting (default on, /admin/settings); JSON/API
requests and a handful of excluded prefixes are never affected. The pool of
candidate slugs is cached in-process and resampled periodically so it stays
fast and eventually cycles the whole posts table; on any internal failure it
falls straight through to the real 404 page.
Applying this everywhere surfaced ~60 existing tests that asserted a literal
404 for a legitimate resource-not-found flow (deleted post, unknown
container, wrong project slug, etc.) - each now disables the setting for the
duration of that specific check and restores it after, so the underlying
not-found behavior stays covered independently of the new feature.
Post page also gained, all built on the same shared post_page_context() so
they render identically on both a real post and a happy-404 page:
- A left sidebar (three separate cards, matching /feed's sidebar-card
convention) for "Gists from {author}", "Projects from {author}" (private
projects filtered through the normal visibility check), and "Related
Discussions" - each cached per author and invalidated on create/edit/
delete so new content shows up immediately.
- A right column reusing /feed's exact Daily Topic widget class for up to
three "Featured" articles (the existing but previously-unused `featured`
news flag), cached as a pool with per-request random sampling.
- A "Next post -> " link beside "Back to Feed", pointing at the next older
post site-wide (blocked authors skipped). Wired through the same next_url
mechanism already used for listing pagination, so it emits a real
backend-rendered <link rel="next"> tag for SEO, not just a visible link.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BWJy6PrMMt5hwWxQwia2rd
121 lines
4.3 KiB
Python
121 lines
4.3 KiB
Python
# retoor <retoor@molodetz.nl>
|
|
|
|
import asyncio
|
|
import time
|
|
from datetime import datetime, timezone
|
|
from pathlib import Path
|
|
import pytest
|
|
from devplacepy.database import init_db, get_table, refresh_snapshot, set_setting
|
|
from devplacepy import project_files
|
|
from devplacepy.services.jobs import queue
|
|
from devplacepy.services.jobs.fork_service import ForkService
|
|
from tests.conftest import CACHE_VERSION_PROPAGATION_SECONDS, run_async
|
|
@pytest.fixture(autouse=True)
|
|
def _init_db_fork_jobs():
|
|
init_db()
|
|
yield
|
|
@pytest.fixture
|
|
def fork_env(tmp_path, monkeypatch):
|
|
monkeypatch.setattr(
|
|
"devplacepy.services.jobs.fork_service.FORK_STAGING_DIR", tmp_path / "staging"
|
|
)
|
|
monkeypatch.setattr("devplacepy.project_files.PROJECT_FILES_DIR", tmp_path / "pf")
|
|
yield tmp_path
|
|
jobs = get_table("jobs")
|
|
for row in list(jobs.find(kind="fork")):
|
|
jobs.delete(uid=row["uid"])
|
|
projects = get_table("projects")
|
|
files = get_table("project_files")
|
|
for project in list(projects.find()):
|
|
if str(project.get("user_uid", "")).startswith("forktest-owner"):
|
|
for node in list(files.find(project_uid=project["uid"])):
|
|
files.delete(uid=node["uid"])
|
|
projects.delete(uid=project["uid"])
|
|
for node in list(files.find()):
|
|
if str(node.get("project_uid", "")).startswith("forktest"):
|
|
files.delete(uid=node["uid"])
|
|
forks = get_table("project_forks")
|
|
for relation in list(forks.find()):
|
|
if str(relation.get("forked_by_uid", "")).startswith("forktest-owner"):
|
|
forks.delete(uid=relation["uid"])
|
|
users = get_table("users")
|
|
for user in list(users.find()):
|
|
if str(user.get("uid", "")).startswith("forktest-owner"):
|
|
users.delete(uid=user["uid"])
|
|
_counter_fork_jobs = [0]
|
|
def _make_source_project(*, is_private=False, binary=False):
|
|
_counter_fork_jobs[0] += 1
|
|
pid = f"forktest-{_counter_fork_jobs[0]}"
|
|
owner_uid = f"forktest-owner-{_counter_fork_jobs[0]}"
|
|
user = {"uid": owner_uid, "username": f"forktester{_counter_fork_jobs[0]}"}
|
|
get_table("users").insert(
|
|
{"uid": owner_uid, "username": user["username"], "xp": 0, "level": 1}
|
|
)
|
|
get_table("projects").insert(
|
|
{
|
|
"deleted_at": None,
|
|
"deleted_by": None,
|
|
"uid": pid,
|
|
"user_uid": owner_uid,
|
|
"slug": f"{pid}-source",
|
|
"title": "Source Project",
|
|
"description": "the original",
|
|
"project_type": "software",
|
|
"platforms": "linux",
|
|
"status": "Released",
|
|
"is_private": 1 if is_private else 0,
|
|
"read_only": 0,
|
|
"stars": 0,
|
|
"created_at": datetime.now(timezone.utc).isoformat(),
|
|
}
|
|
)
|
|
project_files.write_text_file(pid, user, "README.md", "# hello\nworld")
|
|
project_files.write_text_file(pid, user, "src/app.py", "print(1)\n")
|
|
if binary:
|
|
project_files.store_upload(pid, user, "assets", "logo.bin", bytes(range(256)))
|
|
return pid, owner_uid
|
|
def _tree(directory):
|
|
root = Path(directory)
|
|
out = {}
|
|
for path in sorted(root.rglob("*")):
|
|
if path.is_file():
|
|
out[path.relative_to(root).as_posix()] = path.read_bytes()
|
|
return out
|
|
def _process_fork_jobs():
|
|
async def drive():
|
|
svc = ForkService()
|
|
for _ in range(400):
|
|
await svc.run_once()
|
|
refresh_snapshot()
|
|
pending = [
|
|
r
|
|
for r in get_table("jobs").find(kind="fork")
|
|
if r["status"] in ("pending", "running")
|
|
]
|
|
if not pending and not svc._inflight:
|
|
return
|
|
await asyncio.sleep(0.05)
|
|
|
|
run_async(drive())
|
|
def _enqueue(source_uid, owner_uid, title="My Fork"):
|
|
return queue.enqueue(
|
|
"fork",
|
|
{"source_project_uid": source_uid, "title": title, "forked_by_uid": owner_uid},
|
|
"user",
|
|
owner_uid,
|
|
title,
|
|
)
|
|
|
|
|
|
def test_fork_status_http_unknown_returns_404(app_server):
|
|
import requests
|
|
from tests.conftest import BASE_URL
|
|
set_setting("happy_404_enabled", "0")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
|
try:
|
|
r = requests.get(f"{BASE_URL}/forks/nonexistent-uid")
|
|
assert r.status_code == 404
|
|
finally:
|
|
set_setting("happy_404_enabled", "1")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|