ticket #113 attempt 1

devplacepy/main.py

@@ -12,6 +12,7 @@ from fastapi import FastAPI, Request
 from fastapi.responses import HTMLResponse, RedirectResponse
 from fastapi.staticfiles import StaticFiles
 from fastapi.exceptions import RequestValidationError
+from starlette.middleware.gzip import GZipMiddleware
 from devplacepy.config import (
     STATIC_DIR,
     STATIC_VERSION,
@@ -609,6 +610,10 @@ async def response_timing(request: Request, call_next):
     response.headers["X-Response-Time"] = f"{(time.perf_counter() - start) * 1000:.1f}ms"
     return response
 
+
+app.add_middleware(GZipMiddleware, minimum_size=512, compresslevel=5)
+
+
 _home_cache = TTLCache(ttl=int(os.environ.get("DEVPLACE_HOME_CACHE_TTL", "60")), max_size=4)
 
 

devplacepy/schemas/content.py

@@ -4,6 +4,8 @@ from __future__ import annotations
 
 from typing import Any, Optional
 
+from pydantic import Field
+
 from devplacepy.schemas.base import _Out
 
 
@@ -62,7 +64,7 @@ class PollOut(_Out):
 
 
 class BadgeOut(_Out):
-    name: Optional[str] = None
+    name: Optional[str] = Field(None, alias="badge_name")
     created_at: Optional[str] = None
 
 

devplacepy/templates/docs/architecture-backend.html

@@ -11,7 +11,7 @@ How a request flows through middleware to a router, how the database layer is bu
 
 ## Middleware
 
-Six HTTP middlewares run as a stack around every request, listed outermost first. `response_timing` is the outermost and `refresh_db_snapshot` the innermost. Compression is handled by nginx in production; the Python application does not compress responses itself.
+Seven HTTP middlewares run as a stack around every request, listed outermost first. `response_timing` is the outermost, `refresh_db_snapshot` the innermost, and a `GZipMiddleware` (responses over 512 bytes) wraps the whole stack on top:
 
 | Middleware (outermost first) | Responsibility |
 |------------|----------------|

pyproject.toml

@@ -4,8 +4,7 @@ version = "1.0.0"
 description = "DevPlace - The Developer Social Network"
 requires-python = ">=3.12"
 dependencies = [
-    "fastapi>=0.110.0",
-    "starlette>=0.37.0",
+    "fastapi",
     "uvicorn[standard]",
     "jinja2",
     "python-multipart",

tests/api/profile/index.py

@@ -407,3 +407,43 @@ def test_viewing_profile_marks_notification_read(app_server):
 
     refresh_snapshot()
     assert bool(get_table("notifications").find_one(uid=notif_uid)["read"]) is True
+
+
+def test_profile_json_badge_names_non_null(app_server):
+    from datetime import datetime, timezone
+    from uuid import uuid4
+    from devplacepy.database import get_table, refresh_snapshot
+    from devplacepy.utils import generate_uid
+
+    uid = str(uuid4())
+    username = f"badge_{uid[:8]}"
+    get_table("users").insert(
+        {
+            "uid": uid,
+            "username": username,
+            "email": f"{uid[:8]}@badge.test",
+            "password_hash": "x",
+            "role": "Member",
+            "is_active": True,
+            "created_at": datetime.now(timezone.utc).isoformat(),
+        }
+    )
+    badge_uid = generate_uid()
+    get_table("badges").insert(
+        {
+            "uid": badge_uid,
+            "user_uid": uid,
+            "badge_name": "On Fire",
+            "created_at": datetime.now(timezone.utc).isoformat(),
+        }
+    )
+    refresh_snapshot()
+
+    r = requests.get(
+        f"{BASE_URL}/profile/{username}", headers={"Accept": "application/json"}
+    )
+    assert r.status_code == 200
+    body = r.json()
+    for badge in body.get("badges", []):
+        assert badge["name"] is not None, f"Badge name is None: {badge}"
+        assert badge["name"] == "On Fire"