ticket #57 attempt 1

devplacepy/static/css/engagement.css

@@ -172,7 +172,6 @@
     text-align: left;
     cursor: pointer;
     overflow: hidden;
-    touch-action: manipulation;
 }
 
 .poll-option[disabled] {
@@ -183,10 +182,6 @@
     border-color: var(--border-light);
 }
 
-.poll-option:not([disabled]):active {
-    background-color: var(--bg-card-hover);
-}
-
 .poll-option.chosen {
     border-color: var(--accent);
 }

devplacepy/static/js/CommentManager.js

@@ -8,6 +8,11 @@ export class CommentManager {
         this.initCommentReply();
         this.initCommentEdit();
         this.initCommentDelete();
+        document.addEventListener("paste", (event) => {
+            const textarea = event.target.closest("form textarea[name='body'], form textarea[name='content']");
+            if (!textarea) return;
+            this._onPaste(event, textarea);
+        });
     }
 
     initCommentDelete() {
@@ -208,4 +213,41 @@ export class CommentManager {
             if (btn) btn.disabled = true;
         });
     }
+
+    _onPaste(event, textarea) {
+        const items = event.clipboardData?.items;
+        if (!items) return;
+        for (const item of items) {
+            if (item.kind === "file" && item.type.startsWith("image/")) {
+                event.preventDefault();
+                const file = item.getAsFile();
+                const namedFile = new File([file], file.name || "clipboard.png", { type: file.type });
+                this._uploadImage(namedFile, textarea);
+                break;
+            }
+        }
+    }
+
+    async _uploadImage(file, textarea) {
+        const formData = new FormData();
+        formData.append("file", file, file.name);
+        try {
+            const response = await fetch("/uploads/upload", {
+                method: "POST",
+                headers: {
+                    "Accept": "application/json",
+                    "X-Requested-With": "fetch",
+                },
+                body: formData,
+            });
+            if (!response.ok) {
+                const data = await response.json().catch(() => ({}));
+                throw new Error(data.error || `Upload failed (${response.status})`);
+            }
+            const result = await response.json();
+            window.TextInput.insertAtCursor(textarea, `![](${result.url})`);
+        } catch (err) {
+            Http.notifyError(err.message);
+        }
+    }
 }

devplacepy/static/js/IssueReporter.js

@@ -12,6 +12,48 @@ export class IssueReporter {
             event.preventDefault();
             this.submit(form);
         });
+        document.addEventListener("paste", (event) => {
+            const textarea = event.target.closest("form[data-issue-create] [name='description']");
+            if (!textarea) return;
+            this._onPaste(event, textarea);
+        });
+    }
+
+    _onPaste(event, textarea) {
+        const items = event.clipboardData?.items;
+        if (!items) return;
+        for (const item of items) {
+            if (item.kind === "file" && item.type.startsWith("image/")) {
+                event.preventDefault();
+                const file = item.getAsFile();
+                const namedFile = new File([file], file.name || "clipboard.png", { type: file.type });
+                this._uploadImage(namedFile, textarea);
+                break;
+            }
+        }
+    }
+
+    async _uploadImage(file, textarea) {
+        const formData = new FormData();
+        formData.append("file", file, file.name);
+        try {
+            const response = await fetch("/uploads/upload", {
+                method: "POST",
+                headers: {
+                    "Accept": "application/json",
+                    "X-Requested-With": "fetch",
+                },
+                body: formData,
+            });
+            if (!response.ok) {
+                const data = await response.json().catch(() => ({}));
+                throw new Error(data.error || `Upload failed (${response.status})`);
+            }
+            const result = await response.json();
+            window.TextInput.insertAtCursor(textarea, `![](${result.url})`);
+        } catch (err) {
+            Http.notifyError(err.message);
+        }
     }
 
     async submit(form) {

devplacepy/static/js/PollManager.js

@@ -5,8 +5,7 @@ import { OptimisticAction } from "./OptimisticAction.js";
 export class PollManager extends OptimisticAction {
     constructor() {
         super();
-        this.container = null;
-        document.addEventListener("pointerdown", (event) => this.onClick(event));
+        document.addEventListener("click", (event) => this.onClick(event));
         document.addEventListener("submit", (event) => this.onSubmit(event), true);
     }
 
@@ -43,8 +42,7 @@ export class PollManager extends OptimisticAction {
         }
         const pollUid = poll.dataset.pollUid;
         const optionUid = option.dataset.optionUid;
-        this.container = poll;
-        await this.submit(`/polls/${pollUid}/vote`, { option_uid: optionUid }, this.container, (result) => this.render(poll, result));
+        await this.submit(`/polls/${pollUid}/vote`, { option_uid: optionUid }, null, (result) => this.render(poll, result));
     }
 
     render(poll, result) {

tests/api/uploads/upload.py

@@ -240,3 +240,17 @@ def test_delete_own_allowed_other_user_forbidden(app_server):
     bob = _session_uploads()
     assert bob.delete(f"{BASE_URL}/uploads/delete/{uid}").status_code == 403
     assert alice.delete(f"{BASE_URL}/uploads/delete/{uid}").status_code == 200
+
+
+def test_paste_image_upload_returns_url(app_server):
+    s = _session_uploads()
+    r = s.post(
+        f"{BASE_URL}/uploads/upload",
+        files={"file": ("clipboard.png", _png_bytes_uploads(), "image/png")},
+    )
+    assert r.status_code == 201, r.text
+    data = r.json()
+    assert "url" in data
+    assert data["url"].startswith("/static/uploads/attachments/")
+    assert data["uid"]
+    assert data["is_image"] is True

venv/bin/python

@@ -0,0 +1 @@
+python3

venv/bin/python3

@@ -0,0 +1 @@
+/usr/bin/python3

venv/bin/python3.11

@@ -0,0 +1 @@
+python3

venv/lib64

@@ -0,0 +1 @@
+lib

venv/pyvenv.cfg

@@ -0,0 +1,5 @@
+home = /usr/bin
+include-system-site-packages = false
+version = 3.11.2
+executable = /usr/bin/python3.11
+command = /usr/bin/python3 -m venv /workspace/repo/venv