forked from retoor/devplacepy
retoorandClaude Sonnet 5
3c69de9d55
Happy 404: an HTML 404 (unmatched route, or an explicit not-found inside a
real route) now renders a random existing post instead of the error page,
using the exact same context builder as a real post view. Toggle is the
happy_404_enabled site setting (default on, /admin/settings); JSON/API
requests and a handful of excluded prefixes are never affected. The pool of
candidate slugs is cached in-process and resampled periodically so it stays
fast and eventually cycles the whole posts table; on any internal failure it
falls straight through to the real 404 page.
Applying this everywhere surfaced ~60 existing tests that asserted a literal
404 for a legitimate resource-not-found flow (deleted post, unknown
container, wrong project slug, etc.) - each now disables the setting for the
duration of that specific check and restores it after, so the underlying
not-found behavior stays covered independently of the new feature.
Post page also gained, all built on the same shared post_page_context() so
they render identically on both a real post and a happy-404 page:
- A left sidebar (three separate cards, matching /feed's sidebar-card
convention) for "Gists from {author}", "Projects from {author}" (private
projects filtered through the normal visibility check), and "Related
Discussions" - each cached per author and invalidated on create/edit/
delete so new content shows up immediately.
- A right column reusing /feed's exact Daily Topic widget class for up to
three "Featured" articles (the existing but previously-unused `featured`
news flag), cached as a pool with per-request random sampling.
- A "Next post -> " link beside "Back to Feed", pointing at the next older
post site-wide (blocked authors skipped). Wired through the same next_url
mechanism already used for listing pagination, so it emits a real
backend-rendered <link rel="next"> tag for SEO, not just a visible link.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BWJy6PrMMt5hwWxQwia2rd
215 lines
6.5 KiB
Python
215 lines
6.5 KiB
Python
# retoor <retoor@molodetz.nl>
|
|
|
|
import time
|
|
from uuid import uuid4
|
|
from datetime import datetime, timezone
|
|
import requests
|
|
from tests.conftest import BASE_URL, CACHE_VERSION_PROPAGATION_SECONDS
|
|
from devplacepy.database import get_table, set_setting
|
|
from devplacepy.utils import make_combined_slug
|
|
|
|
JSON = {"Accept": "application/json"}
|
|
_counter = [0]
|
|
|
|
|
|
def _signup():
|
|
_counter[0] += 1
|
|
name = f"blkvis{int(time.time() * 1000)}{_counter[0]}"
|
|
session = requests.Session()
|
|
session.post(
|
|
f"{BASE_URL}/auth/signup",
|
|
data={
|
|
"username": name,
|
|
"email": f"{name}@t.dev",
|
|
"password": "secret123",
|
|
"confirm_password": "secret123",
|
|
"birth_date": "1990-01-01",
|
|
"accept_terms": "1",
|
|
},
|
|
allow_redirects=True,
|
|
)
|
|
return session, name
|
|
|
|
|
|
def _uid(name):
|
|
return get_table("users").find_one(username=name)["uid"]
|
|
|
|
|
|
def _new_post(session, content="blocked author post body"):
|
|
return session.post(
|
|
f"{BASE_URL}/posts/create",
|
|
headers=JSON,
|
|
data={"title": f"blkpost{uuid4().hex[:8]}", "content": content, "topic": "devlog"},
|
|
).json()["data"]
|
|
|
|
|
|
def _new_project(session):
|
|
return session.post(
|
|
f"{BASE_URL}/projects/create",
|
|
headers=JSON,
|
|
data={
|
|
"title": f"blkproj{uuid4().hex[:8]}",
|
|
"description": "blocked author project description",
|
|
"project_type": "software",
|
|
"status": "In Development",
|
|
"platforms": "",
|
|
},
|
|
).json()["data"]
|
|
|
|
|
|
def _new_gist(session):
|
|
return session.post(
|
|
f"{BASE_URL}/gists/create",
|
|
headers=JSON,
|
|
data={
|
|
"title": f"blkgist{uuid4().hex[:8]}",
|
|
"description": "blocked author gist",
|
|
"source_code": "print('x')",
|
|
"language": "python",
|
|
},
|
|
).json()["data"]
|
|
|
|
|
|
def test_blocked_author_post_hidden_from_feed(app_server):
|
|
blocker_session, blocker = _signup()
|
|
author_session, author = _signup()
|
|
post = _new_post(author_session)
|
|
|
|
before = blocker_session.get(f"{BASE_URL}/feed", headers=JSON).json()
|
|
assert post["uid"] in [i["post"]["uid"] for i in before["posts"]]
|
|
|
|
blocker_session.post(f"{BASE_URL}/block/{author}", allow_redirects=False)
|
|
|
|
after = blocker_session.get(f"{BASE_URL}/feed", headers=JSON).json()
|
|
assert post["uid"] not in [i["post"]["uid"] for i in after["posts"]]
|
|
|
|
|
|
def test_blocked_author_gist_hidden_from_listing(app_server):
|
|
blocker_session, blocker = _signup()
|
|
author_session, author = _signup()
|
|
gist = _new_gist(author_session)
|
|
blocker_session.post(f"{BASE_URL}/block/{author}", allow_redirects=False)
|
|
|
|
data = blocker_session.get(f"{BASE_URL}/gists", headers=JSON).json()
|
|
assert gist["uid"] not in [i["gist"]["uid"] for i in data["gists"]]
|
|
|
|
|
|
def test_blocked_author_project_hidden_from_listing(app_server):
|
|
blocker_session, blocker = _signup()
|
|
author_session, author = _signup()
|
|
project = _new_project(author_session)
|
|
blocker_session.post(f"{BASE_URL}/block/{author}", allow_redirects=False)
|
|
|
|
data = blocker_session.get(f"{BASE_URL}/projects", headers=JSON).json()
|
|
assert project["uid"] not in [i["uid"] for i in data["projects"]]
|
|
|
|
|
|
def test_blocked_author_post_detail_404(app_server):
|
|
blocker_session, blocker = _signup()
|
|
author_session, author = _signup()
|
|
post = _new_post(author_session)
|
|
blocker_session.post(f"{BASE_URL}/block/{author}", allow_redirects=False)
|
|
|
|
set_setting("happy_404_enabled", "0")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
|
try:
|
|
r = blocker_session.get(f"{BASE_URL}/posts/{post['slug']}")
|
|
assert r.status_code == 404
|
|
finally:
|
|
set_setting("happy_404_enabled", "1")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
|
|
|
|
|
def test_blocked_author_comment_hidden_on_detail(app_server):
|
|
blocker_session, blocker = _signup()
|
|
host_session, host = _signup()
|
|
commenter_session, commenter = _signup()
|
|
post = _new_post(host_session)
|
|
|
|
commenter_session.post(
|
|
f"{BASE_URL}/comments/create",
|
|
headers=JSON,
|
|
data={
|
|
"target_type": "post",
|
|
"target_uid": post["uid"],
|
|
"content": "comment from a blocked user",
|
|
},
|
|
)
|
|
|
|
detail = blocker_session.get(
|
|
f"{BASE_URL}/posts/{post['slug']}", headers=JSON
|
|
).json()
|
|
assert any(
|
|
c["comment"]["content"] == "comment from a blocked user"
|
|
for c in detail["comments"]
|
|
)
|
|
|
|
blocker_session.post(f"{BASE_URL}/block/{commenter}", allow_redirects=False)
|
|
|
|
detail2 = blocker_session.get(
|
|
f"{BASE_URL}/posts/{post['slug']}", headers=JSON
|
|
).json()
|
|
assert not any(
|
|
c["comment"]["content"] == "comment from a blocked user"
|
|
for c in detail2["comments"]
|
|
)
|
|
|
|
|
|
def test_blocked_user_cannot_send_dm(app_server):
|
|
blocker_session, blocker = _signup()
|
|
sender_session, sender = _signup()
|
|
blocker_session.post(f"{BASE_URL}/block/{sender}", allow_redirects=False)
|
|
|
|
sender_session.post(
|
|
f"{BASE_URL}/messages/send",
|
|
headers=JSON,
|
|
data={"receiver_uid": _uid(blocker), "content": "you blocked me"},
|
|
allow_redirects=False,
|
|
)
|
|
|
|
assert (
|
|
get_table("messages").count(
|
|
sender_uid=_uid(sender), receiver_uid=_uid(blocker)
|
|
)
|
|
== 0
|
|
)
|
|
|
|
|
|
def test_block_suppresses_notifications(app_server):
|
|
blocker_session, blocker = _signup()
|
|
actor_session, actor = _signup()
|
|
blocker_session.post(f"{BASE_URL}/block/{actor}", allow_redirects=False)
|
|
|
|
actor_session.post(f"{BASE_URL}/follow/{blocker}", allow_redirects=False)
|
|
|
|
assert (
|
|
get_table("notifications").count(
|
|
user_uid=_uid(blocker), related_uid=_uid(actor), type="follow"
|
|
)
|
|
== 0
|
|
)
|
|
|
|
|
|
def test_profile_json_reports_is_blocked(app_server):
|
|
blocker_session, blocker = _signup()
|
|
_, target = _signup()
|
|
blocker_session.post(f"{BASE_URL}/block/{target}", allow_redirects=False)
|
|
|
|
data = blocker_session.get(
|
|
f"{BASE_URL}/profile/{target}", headers=JSON
|
|
).json()
|
|
assert data["is_blocked"] is True
|
|
assert data["is_muted"] is False
|
|
|
|
|
|
def test_blocked_user_profile_still_shows_their_posts(app_server):
|
|
blocker_session, blocker = _signup()
|
|
author_session, author = _signup()
|
|
post = _new_post(author_session, content="visible on my own profile")
|
|
blocker_session.post(f"{BASE_URL}/block/{author}", allow_redirects=False)
|
|
|
|
data = blocker_session.get(
|
|
f"{BASE_URL}/profile/{author}", headers=JSON
|
|
).json()
|
|
assert post["uid"] in [p["post"]["uid"] for p in data["posts"]]
|