Bob Nystrom
21c5611bf0
The previous implementation unconditionally closed the first open upvalue when executing CLOSE_UPVALUE, which could crash when a local variable was never actually captured by a closure. Changed closeUpvalue to closeUpvalues with a stack threshold parameter, so only upvalues whose stack slot is at or above the given pointer are closed. This prevents closing nonexistent upvalues for locals that were never closed over, fixing segfaults in unused closure scenarios. Added regression tests for unused closures and for nested scopes where only some locals are captured.
12 lines
331 B
Plaintext
12 lines
331 B
Plaintext
// This is a regression test. There was a bug where the VM would try to close
|
|
// an upvalue even if the upvalue was never created because the codepath for
|
|
// the closure was not executed.
|
|
|
|
{
|
|
var a = "a"
|
|
if (false) Fn.new { a }
|
|
}
|
|
|
|
// If we get here, we didn't segfault when a went out of scope.
|
|
System.print("ok") // expect: ok
|