feat: prevent subclassing of built-in types with runtime error

Add a check in the interpreter's class creation path that rejects attempts to subclass any of the seven core built-in types (Class, Fiber, Fn, List, Map, Range, String). When such a subclass is declared, a runtime error is raised with a message like "Class 'SubName' may not subclass a built-in". Also add corresponding test files for each forbidden subclass scenario.
This commit is contained in:
Bob Nystrom
2015-02-27 15:41:25 +00:00
9 changed files with 41 additions and 0 deletions
+2
View File
@@ -0,0 +1,2 @@
class SubClass is Class {} // expect runtime error: Class 'SubClass' may not subclass a built-in
+16
View File
@@ -0,0 +1,16 @@
var f = null
{
var a = "a"
f = new Fn {
IO.print(a)
}
}
//@FIXME: repair the segfault create a propper test for the subclassing
//var closureSegfault = f
//class SubClosureSegfault is closureSegfault {}
//var closureOk = f.call
//class SubClosureOk is closureOk {}
+2
View File
@@ -0,0 +1,2 @@
class SubFiber is Fiber {} // expect runtime error: Class 'SubFiber' may not subclass a built-in
+2
View File
@@ -0,0 +1,2 @@
class SubFn is Fn {} // expect runtime error: Class 'SubFn' may not subclass a built-in
+1
View File
@@ -0,0 +1 @@
class SubList is List {} // expect runtime error: Class 'SubList' may not subclass a built-in
+2
View File
@@ -0,0 +1,2 @@
class SubMap is Map {} // expect runtime error: Class 'SubMap' may not subclass a built-in
+1
View File
@@ -0,0 +1 @@
class SubRange is Range {} // expect runtime error: Class 'SubRange' may not subclass a built-in
+2
View File
@@ -0,0 +1,2 @@
class SubString is String {} // expect runtime error: Class 'SubString' may not subclass a built-in