fix: replace DBL_EPSILON with DBL_MIN for Num.smallest in wren_core.c

Change the C implementation of `num_smallest` primitive to return `DBL_MIN` instead of `DBL_EPSILON`, correcting the value from the machine epsilon (difference between 1.0 and next representable value) to the smallest positive representable double. Update the documentation in `num.markdown` to describe `Num.smallest` as "the smallest positive representable numeric value" and `Num.largest` as "the largest representable numeric value". Add test files `largest.wren` and `smallest.wren` verifying the expected output values.

This commit is contained in:

Bob Nystrom

2016-08-28 00:25:32 +00:00

parent 5f6e06e1b5

commit c29f3e694f

4 changed files with 5 additions and 3 deletions

									
										src/vm/wren_core.c
									
		+1
		-1
	
												View File
												
				@@ -691,7 +691,7 @@ DEF_PRIMITIVE(num_largest)

				DEF_PRIMITIVE(num_smallest)

				{

				  RETURN_NUM(DBL_EPSILON);

				  RETURN_NUM(DBL_MIN);

				}

				DEF_PRIMITIVE(num_toString)