retoor/wren
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: change String#contains return type from numeric to boolean

Browse Source 
Replace NUM_VAL and integer literals with TRUE_VAL, FALSE_VAL, and BOOL_VAL
in the string_contains primitive implementation, and update the test
expectations from 1/0 to true/false accordingly.
This commit is contained in:
Bob Nystrom
2013-11-17 18:04:02 +00:00
parent 69744a3acc
commit b3d5f3b4a0
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/string_contains.wren
+6 -6
View File
@@ -1,8 +1,8 @@
io.write("".contains("")) // expect: 1
io.write("anything".contains("")) // expect: 1
io.write("something".contains("meth")) // expect: 1
io.write("something".contains("some")) // expect: 1
io.write("something".contains("ing")) // expect: 1
io.write("something".contains("math")) // expect: 0
io.write("".contains("")) // expect: true
io.write("anything".contains("")) // expect: true
io.write("something".contains("meth")) // expect: true
io.write("something".contains("some")) // expect: true
io.write("something".contains("ing")) // expect: true
io.write("something".contains("math")) // expect: false
// TODO(bob): Passing non-string as argument.