fix: change String#contains return type from numeric to boolean

Replace NUM_VAL and integer literals with TRUE_VAL, FALSE_VAL, and BOOL_VAL
in the string_contains primitive implementation, and update the test
expectations from 1/0 to true/false accordingly.
This commit is contained in:
Bob Nystrom
2013-11-17 18:04:02 +00:00
parent 69744a3acc
commit b3d5f3b4a0
2 changed files with 8 additions and 9 deletions
+2 -3
View File
@@ -176,10 +176,9 @@ DEF_PRIMITIVE(string_contains)
const char* search = AS_CSTRING(args[1]);
// Corner case, the empty string contains the empty string.
if (strlen(string) == 0 && strlen(search) == 0) return NUM_VAL(1);
if (strlen(string) == 0 && strlen(search) == 0) return TRUE_VAL;
// TODO(bob): Return bool.
return NUM_VAL(strstr(string, search) != NULL);
return BOOL_VAL(strstr(string, search) != NULL);
}
DEF_PRIMITIVE(string_count)