retoor/wren
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: guard signature string overflow when too many parameters are passed

Browse Source 
Add a MAX_PARAMETERS bound to the loop in signatureParameterList to prevent
buffer overflow when a method signature has an excessive number of parameters.
A compile error is already reported in such cases, but the unbounded loop could
still write past the end of the name buffer. Also add regression test 494.wren
to cover this scenario.
This commit is contained in:
Bob Nystrom
2018-04-27 16:13:40 +00:00
parent 248e3a69f0
commit 5c3d883204
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/regression/494.wren
+3
View File
@@ -0,0 +1,3 @@
0[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,
// expect error line 1
// expect error line 4