retoor/wren
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move OP_CLOSURE and OP_LIST down.

Browse Source 
Since they're less frequently used, pushing them down speeds
things up a little bit.
This commit is contained in:
Bob Nystrom
2013-12-13 06:47:34 -08:00
parent 5aaaa33552
commit 4957728893
4 changed files with 95 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wren_vm.c
+51 -51
View File
@@ -577,8 +577,6 @@ Value interpret(WrenVM* vm, Value function)
&&code_NULL,
&&code_FALSE,
&&code_TRUE,
&&code_LIST,
&&code_CLOSURE,
&&code_LOAD_LOCAL,
&&code_STORE_LOCAL,
&&code_LOAD_UPVALUE,
@@ -614,6 +612,8 @@ Value interpret(WrenVM* vm, Value function)
&&code_IS,
&&code_CLOSE_UPVALUE,
&&code_RETURN,
&&code_LIST,
&&code_CLOSURE,
&&code_CLASS,
&&code_SUBCLASS,
&&code_METHOD_INSTANCE,
@@ -728,55 +728,6 @@ Value interpret(WrenVM* vm, Value function)
DISPATCH();
}
CASE_CODE(LIST):
{
int numElements = READ_ARG();
ObjList* list = wrenNewList(vm, numElements);
for (int i = 0; i < numElements; i++)
{
list->elements[i] = fiber->stack[fiber->stackSize - numElements + i];
}
// Discard the elements.
fiber->stackSize -= numElements;
PUSH(OBJ_VAL(list));
DISPATCH();
}
CASE_CODE(CLOSURE):
{
ObjFn* prototype = AS_FN(fn->constants[READ_ARG()]);
ASSERT(prototype->numUpvalues > 0,
"Should not create closure for functions that don't need it.");
// Create the closure and push it on the stack before creating upvalues
// so that it doesn't get collected.
ObjClosure* closure = wrenNewClosure(vm, prototype);
PUSH(OBJ_VAL(closure));
// Capture upvalues.
for (int i = 0; i < prototype->numUpvalues; i++)
{
int isLocal = READ_ARG();
int index = READ_ARG();
if (isLocal)
{
// Make an new upvalue to close over the parent's local variable.
closure->upvalues[i] = captureUpvalue(vm, fiber,
frame->stackStart + index);
}
else
{
// Use the same upvalue as the current call frame.
closure->upvalues[i] = upvalues[index];
}
}
DISPATCH();
}
CASE_CODE(LOAD_LOCAL):
{
int local = READ_ARG();
@@ -971,6 +922,55 @@ Value interpret(WrenVM* vm, Value function)
DISPATCH();
}
CASE_CODE(LIST):
{
int numElements = READ_ARG();
ObjList* list = wrenNewList(vm, numElements);
for (int i = 0; i < numElements; i++)
{
list->elements[i] = fiber->stack[fiber->stackSize - numElements + i];
}
// Discard the elements.
fiber->stackSize -= numElements;
PUSH(OBJ_VAL(list));
DISPATCH();
}
CASE_CODE(CLOSURE):
{
ObjFn* prototype = AS_FN(fn->constants[READ_ARG()]);
ASSERT(prototype->numUpvalues > 0,
"Should not create closure for functions that don't need it.");
// Create the closure and push it on the stack before creating upvalues
// so that it doesn't get collected.
ObjClosure* closure = wrenNewClosure(vm, prototype);
PUSH(OBJ_VAL(closure));
// Capture upvalues.
for (int i = 0; i < prototype->numUpvalues; i++)
{
int isLocal = READ_ARG();
int index = READ_ARG();
if (isLocal)
{
// Make an new upvalue to close over the parent's local variable.
closure->upvalues[i] = captureUpvalue(vm, fiber,
frame->stackStart + index);
}
else
{
// Use the same upvalue as the current call frame.
closure->upvalues[i] = upvalues[index];
}
}
DISPATCH();
}
CASE_CODE(CLASS):
CASE_CODE(SUBCLASS):
{