retoor/wren
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: correct test runner to fail on all unmet expected errors and refactor into Test class

Browse Source 
The test runner previously short-circuited when a test expected an error and found at least one, causing it to miss other expected errors that didn't occur. This commit fixes the error pattern regex to exclude line-specific error expectations, removes specific error message strings from test files (since the runner doesn't validate them yet), and refactors the monolithic test function into a dedicated Test class with parse and run methods for better maintainability.
This commit is contained in:
Bob Nystrom
2015-07-09 15:06:33 +00:00
parent b1c9231b5a
commit 357e24efcb
6 changed files with 217 additions and 169 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/core/number/invalid_hex_literal.wren
+1 -1
View File
@@ -1 +1 @@
var x = 2xFF // expect error: Error at 'xFF': Expect end of file.
var x = 2xFF // expect error
test/language/function/newline_in_expression_block.wren
+2 -5
View File
@@ -1,5 +1,2 @@
new Fn { IO.print("ok") // expect error
}.call() // expect error
// The second error is cascaded here. If it starts failing, just remove that
// expectation.
Fn.new { IO.print("ok") // expect error
}.call()
test/language/number/hex_too_large.wren
+1 -1
View File
@@ -1 +1 @@
var x = 0x999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999 // expect error: Error: Number literal was too large.
var x = 0x999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999 // expect error
test/language/number/literal_too_large.wren
+1 -1
View File
@@ -1 +1 @@
var x = 999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999 // expect error: Error: Number literal was too large.
var x = 999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999 // expect error
test/limit/variable_name_too_long.wren
+1 -1
View File
@@ -1,2 +1,2 @@
var i234567890i234567890i234567890i234567890i234567890i2345 = "value" // expect error
var i234567890i234567890i234567890i234567890i234567890i234567890i2345 = "value" // expect error
class c234567890c234567890c234567890c234567890c234567890c234567890c2345 {} // expect error