Sudoku review #1

Open
BordedDev wants to merge 19 commits from BordedDev/sudoku:main into main
pull from: BordedDev/sudoku:main
merge into: retoor:main
Conversation 3 Commits 19 Files Changed 8 +2 -4
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ab8b28feba - Show all commits

6
reviews/BordedDev/sudoku.rewrite.js
View File

@ -24,7 +24,7 @@ class SudokuPuzzle extends EventTarget {
* undefined is an empty cell, null is a cell that was cleared * undefined is an empty cell, null is a cell that was cleared
* @typedef {(number|null|undefined)[]} SudokuState * @typedef {(number|null|undefined)[]} SudokuState
*/ */
/** /**
* *
* @type {SudokuState[]} * @type {SudokuState[]}
@ -198,9 +198,7 @@ class SudokuPuzzle extends EventTarget {
* @return boolean * @return boolean
*/ */
isValueValidForSlot(value, slot, state = this.#activeState) { isValueValidForSlot(value, slot, state = this.#activeState) {
return !this.#boxGetValues(slot, state) return !this.getValues(slot, state).has(value)
.union(this.#crossGetValues(slot, state))
.has(value)
} }
/** /**