Sudoku review #1

Open
BordedDev wants to merge 19 commits from BordedDev/sudoku:main into main
pull from: BordedDev/sudoku:main
merge into: retoor:main
Conversation 3 Commits 19 Files Changed 8 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a24e32249b - Show all commits

2
reviews/BordedDev/sudoku.modified.js
View File

@ -13,7 +13,7 @@ class EventHandler {
}
on(event, listener) {
this.events[event] ||= { name: name, listeners: [], callCount: 0 }
this.events[event] ??= { name: name, listeners: [], callCount: 0 }
BordedDev commented 2025-01-15 19:56:48 +00:00
Outdated
Review
Copy Link

Simplified the empty event handler assignment. It was meant to be ??= not ||= both will work in this case because of you how JS works though

Simplified the empty event handler assignment. It was meant to be `??=` not `||=` both will work in this case because of you how JS works though
this.events[event].listeners.push(listener)
}