bugfix/socket-reconnetion #29

Merged
retoor merged 2 commits from BordedDev/snek:bugfix/socket-reconnetion into main 2025-03-16 06:02:04 +01:00
Conversation 0 Commits 2 Files Changed 3 +170 -152
BordedDev commented 2025-03-16 05:46:55 +01:00
Contributor

This should be a more stable reconnecting websocket - it's based on the code that runs ABot, so there might still have an issue but ABot has been stable since removing the debounce

this also adds the app instance to the window

This should be a more stable reconnecting websocket - it's based on the code that runs ABot, so there might still have an issue but ABot has been stable since removing the debounce this also adds the app instance to the window
BordedDev added 2 commits 2025-03-16 05:46:56 +01:00
BordedDev force-pushed bugfix/socket-reconnetion from 693e5f49bc to c9c070c497 2025-03-16 05:47:07 +01:00 Compare
BordedDev reviewed 2025-03-16 05:47:41 +01:00
src/snek/static/app.js
@ -369,3 +233,4 @@ export class App extends EventHandler {
}
export const app = new App();
window.app = app;
BordedDev commented 2025-03-16 05:47:41 +01:00
Author
Contributor

Because it's a module we no longer leak the app instance, this makes it easier to debug

Because it's a module we no longer leak the app instance, this makes it easier to debug
retoor approved these changes 2025-03-16 06:01:56 +01:00
src/snek/static/socket.js
@ -0,0 +130,4 @@
};
const me = this
return new Promise((resolve) => {
me.addEventListener(call.callId, data => resolve(data));
retoor commented 2025-03-16 05:58:06 +01:00
Owner

STill me vars, but out of scope .

STill me vars, but out of scope .
retoor merged commit e62a855409 into main 2025-03-16 06:02:04 +01:00
Sign in to join this conversation.
No reviewers
retoor
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: retoor/snek#29
No description provided.
Delete Branch "BordedDev/snek:bugfix/socket-reconnetion"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?