Merge pull request #300 from return42/fix-engine-pylint

[fix] drop useless pylint: disable=undefined-variable
2021-09-07 10:43:16 +02:00 · 2021-09-07 10:43:16 +02:00 · 9ef7f38e4f
commit 9ef7f38e4f
parent f869e73d2f 82847df300
10 changed files with 3 additions and 10 deletions
--- a/2
+++ b/2
@ -37,7 +37,7 @@ PYLINT_SEARX_DISABLE_OPTION="\
 I,C,R,\
 W0105,W0212,W0511,W0603,W0613,W0621,W0702,W0703,W1401,\
 E1136"
-PYLINT_ADDITIONAL_BUILTINS_FOR_ENGINES="supported_languages,language_aliases,logger"
+PYLINT_ADDITIONAL_BUILTINS_FOR_ENGINES="supported_languages,language_aliases,logger,categories"
 PYLINT_OPTIONS="-m pylint -j 0 --rcfile .pylintrc"

 help() {
--- a/searx/engines/duckduckgo_definitions.py
+++ b/searx/engines/duckduckgo_definitions.py
@ -64,7 +64,7 @@ def request(query, params):
    params['url'] = URL.format(query=urlencode({'q': query}))
    language = match_language(
        params['language'],
-        supported_languages,   # pylint: disable=undefined-variable
+        supported_languages,
        language_aliases
    )
    language = language.split('-')[0]
--- a/searx/engines/google.py
+++ b/searx/engines/google.py
@ -277,7 +277,6 @@ def request(query, params):
    offset = (params['pageno'] - 1) * 10

    lang_info = get_lang_info(
-        # pylint: disable=undefined-variable
        params, supported_languages, language_aliases, True
    )

--- a/searx/engines/google_images.py
+++ b/searx/engines/google_images.py
@ -92,7 +92,6 @@ def request(query, params):
    """Google-Video search request"""

    lang_info = get_lang_info(
-        # pylint: disable=undefined-variable
        params, supported_languages, language_aliases, False
    )
    logger.debug(
--- a/searx/engines/google_news.py
+++ b/searx/engines/google_news.py
@ -75,7 +75,6 @@ def request(query, params):
    """Google-News search request"""

    lang_info = get_lang_info(
-        # pylint: disable=undefined-variable
        params, supported_languages, language_aliases, False
    )
    logger.debug(
--- a/searx/engines/google_scholar.py
+++ b/searx/engines/google_scholar.py
@ -73,7 +73,6 @@ def request(query, params):

    offset = (params['pageno'] - 1) * 10
    lang_info = get_lang_info(
-        # pylint: disable=undefined-variable
        params, supported_languages, language_aliases, False
    )
    logger.debug(
--- a/searx/engines/google_videos.py
+++ b/searx/engines/google_videos.py
@ -110,7 +110,6 @@ def request(query, params):
    """Google-Video search request"""

    lang_info = get_lang_info(
-        # pylint: disable=undefined-variable
        params, supported_languages, language_aliases, False
    )
    logger.debug(
--- a/searx/engines/peertube.py
+++ b/searx/engines/peertube.py
@ -34,7 +34,6 @@ def request(query, params):
    search_url = sanitized_url + "/api/v1/search/videos/?pageno={pageno}&{query}"
    query_dict = {"search": query}
    language = params["language"].split("-")[0]
-    # pylint: disable=undefined-variable
    if "all" != language and language in supported_languages:
        query_dict["languageOneOf"] = language
    params["url"] = search_url.format(
--- a/searx/engines/qwant.py
+++ b/searx/engines/qwant.py
@ -89,7 +89,6 @@ def request(query, params):
    else:
        language = match_language(
            params['language'],
-            # pylint: disable=undefined-variable
            supported_languages,
            language_aliases,
        )
--- a/searx/engines/xpath.py
+++ b/searx/engines/xpath.py
@ -184,7 +184,7 @@ def response(resp):
    '''
    results = []
    dom = html.fromstring(resp.text)
-    is_onion = 'onions' in categories  # pylint: disable=undefined-variable
+    is_onion = 'onions' in categories

    if results_xpath:
        for result in eval_xpath_list(dom, results_xpath):