fix: return proper WebDAV auth challenge headers and text error bodies instead of JSON

mywebdav/main.py

@@ -2,9 +2,9 @@ import argparse
 import uvicorn
 import logging
 from contextlib import asynccontextmanager
-from fastapi import FastAPI, Request, HTTPException
+from fastapi import FastAPI, Request, HTTPException, status
 from fastapi.staticfiles import StaticFiles
-from fastapi.responses import HTMLResponse, JSONResponse
+from fastapi.responses import HTMLResponse, JSONResponse, Response
 from tortoise.contrib.fastapi import register_tortoise
 from .settings import settings
 from .routers import (
@@ -131,9 +131,22 @@ async def http_exception_handler(request: Request, exc: HTTPException):
     logger.error(
         f"HTTPException: {exc.status_code} - {exc.detail} for URL: {request.url}"
     )
+
+    headers = exc.headers
+
+    # For WebDAV authentication challenges, we must return the headers
+    # from the exception and an empty body. A JSON body will confuse WebDAV clients.
+    if request.url.path.startswith("/webdav") and exc.status_code == status.HTTP_401_UNAUTHORIZED:
+        return Response(status_code=exc.status_code, headers=headers)
+
+    # For other WebDAV errors, it's better to return a text body than JSON
+    if request.url.path.startswith("/webdav"):
+        return Response(content=exc.detail, status_code=exc.status_code, headers=headers)
+
     return JSONResponse(
         status_code=exc.status_code,
         content=ErrorResponse(code=exc.status_code, message=exc.detail).model_dump(),
+        headers=headers,
     )