typosaurus
95c4233802
Outcome: done
Changed: none
Verified by: e2e run attempted (3 tests) but blocked at browser launch by missing libglib-2.0.so.0 (environment fault, not a result); breakage proven from Playwright source elementText() in driver coreBundle.js plus empty-button markup
Findings: REJECT - the implementation empties all four vote buttons (_post_votes.html:4,9; _comment.html:6,11) and moves glyphs into CSS ::before, so has_text="+" locators at tests/e2e/notifications/index.py:313, :799 and tests/e2e/leaderboard.py:42 match zero elements (Playwright text matching reads DOM text nodes, never ::before content) and those 3 tests time out
Findings: commit 625940a claimed "Changed: none" but deleted the glyph text from post-downvote and comment-upvote, leaving HEAD with two glyph-less vote buttons (regression only repaired by the uncommitted diff adding the ::before rules)
Findings: map line references are accurate for 625940a^ (text glyphs, no ::before rules) but stale for the working tree, where glyph rules are feed.css:193-217 and post.css:141-165
Findings: the voted cue itself satisfies the ticket - `+`->U+2295 and U+2212/U+002D->U+2296 under .voted (feed.css:211-217, post.css:159-165), non-color, consistent with the star precedent base.css:1319-1325, with aria-pressed synced client-side (VoteManager.js:60-62)
Findings: unvoted downvote glyphs remain inconsistent in touched rules: post U+2212 (feed.css:198) vs comment U+002D (post.css:146)
Open: fix the 3 e2e locators to class-based .vo
Typosaurus-Run: c36faeceb55d45b6bf38a45eec4f47ab
Typosaurus-Node: ebdbae6c04a84a239287bd62262cb254
Typosaurus-Agent: @zoya
Refs: #162
74 lines
4.4 KiB
HTML
74 lines
4.4 KiB
HTML
{% macro comment_cell(item, depth, parent_author=None) %}
|
|
<div class="comment" style="--comment-depth: {{ depth }};" data-depth="{{ depth }}">
|
|
<div class="comment-votes" role="group" aria-label="Comment votes">
|
|
<form method="POST" action="/votes/comment/{{ item.comment['uid'] }}">
|
|
<input type="hidden" name="value" value="1">
|
|
<button type="submit" class="comment-vote-btn vote-up{% if item.my_vote == 1 %} voted{% endif %}" aria-label="Upvote" title="Upvote" aria-pressed="{% if item.my_vote == 1 %}true{% else %}false{% endif %}"{{ guest_disabled(user) }}></button>
|
|
</form>
|
|
<span class="comment-vote-count" data-vote-count="{{ item.comment['uid'] }}">{{ item.votes.up - item.votes.down }}</span>
|
|
<form method="POST" action="/votes/comment/{{ item.comment['uid'] }}">
|
|
<input type="hidden" name="value" value="-1">
|
|
<button type="submit" class="comment-vote-btn vote-down{% if item.my_vote == -1 %} voted{% endif %}" aria-label="Downvote" title="Downvote" aria-pressed="{% if item.my_vote == -1 %}true{% else %}false{% endif %}"{{ guest_disabled(user) }}></button>
|
|
</form>
|
|
</div>
|
|
|
|
<div class="comment-body" id="comment-{{ item.comment['uid'] }}" data-comment-uid="{{ item.comment['uid'] }}">
|
|
<div class="comment-header">
|
|
{% set _user = item.author %}{% set _size = 32 %}{% set _size_class = "sm" %}{% include "_avatar_link.html" %}
|
|
{% set _user = item.author %}{% set _class = "comment-author" %}{% include "_user_link.html" %}
|
|
{% if parent_author %}<span class="comment-reply-to">↳ @{{ parent_author.get('username', '') }}</span>{% endif %}
|
|
<span class="comment-time">{{ dt_ago(item.comment.get('created_at')) if item.comment.get('created_at') else item.time_ago }}</span>
|
|
</div>
|
|
<div class="comment-text rendered-content" data-raw="{{ item.comment['content'] }}">{{ render_content(item.comment['content'], author_is_admin=is_admin(item.author)) }}</div>
|
|
{% set attachments = item.get('attachments', []) %}
|
|
{% if attachments %}
|
|
{% include "_attachment_display.html" %}
|
|
{% endif %}
|
|
<div class="comment-actions">
|
|
<button type="button" class="comment-action-btn" data-action="reply"{{ guest_disabled(user) }}><span class="icon">💬</span><span class="label"> Reply</span></button>
|
|
{% if owns(item.comment, user) %}
|
|
<button type="button" class="comment-action-btn" data-action="edit" data-edit-url="/comments/edit/{{ item.comment['uid'] }}"><span class="icon">✏️</span><span class="label"> Edit</span></button>
|
|
{% endif %}
|
|
{% if owns(item.comment, user) or is_admin(user) %}
|
|
<form method="POST" action="/comments/delete/{{ item.comment['uid'] }}" class="inline-form comment-delete-form" data-comment-uid="{{ item.comment['uid'] }}">
|
|
<button type="submit" class="comment-action-btn" data-confirm="Delete this comment?"><span class="icon">🗑️</span><span class="label"> Delete</span></button>
|
|
</form>
|
|
{% endif %}
|
|
{% set _type = "comment" %}{% set _uid = item.comment['uid'] %}{% set _reactions = item.reactions %}{% include "_reaction_bar.html" %}
|
|
{% set _type = "comment" %}{% set _uid = item.comment['uid'] %}{% set _owner = item.comment['user_uid'] %}{% set _owner_name = (item.author or {}).get('username', '') %}{% set _class = "comment-action-btn" %}{% include "_report_button.html" %}
|
|
</div>
|
|
{{ caller() }}
|
|
</div>
|
|
</div>
|
|
{% endmacro %}
|
|
|
|
{% macro render_comment(item, depth=0) %}
|
|
{% set max_depth = 2 %}
|
|
{% set visual_depth = depth if depth < max_depth else max_depth %}
|
|
{% call comment_cell(item, visual_depth) %}
|
|
{% if item.children %}
|
|
{% if depth < max_depth %}
|
|
<div class="comment-replies">
|
|
{% for child in item.children %}
|
|
{{ render_comment(child, depth + 1) }}
|
|
{% endfor %}
|
|
</div>
|
|
{% else %}
|
|
<div class="comment-replies comment-replies-flat">
|
|
{% for child in item.children %}
|
|
{{ render_comment_flat(child, max_depth, item.author) }}
|
|
{% endfor %}
|
|
</div>
|
|
{% endif %}
|
|
{% endif %}
|
|
{% endcall %}
|
|
{% endmacro %}
|
|
|
|
{% macro render_comment_flat(item, depth, parent_author) %}
|
|
{% call comment_cell(item, depth, parent_author) %}{% endcall %}
|
|
{% for child in item.children %}
|
|
{{ render_comment_flat(child, depth, item.author) }}
|
|
{% endfor %}
|
|
{% endmacro %}
|
|
|