Notifications: a new "thread" type notifies every other commenter on a
post whenever anyone comments on it, disregarding reply hierarchy -
excluding the actor and whoever already got a comment/reply
notification for that same event, so no one is double-notified.
Implemented via a background-deferred fan-out mirroring the existing
mention-notification pattern.
SEO: discussion_forum_posting() now embeds up to 20 of a post's
comments as nested schema.org Comment entities (not just an aggregate
count), and a new /topics hub plus /topics/{topic} pages give the
feed's topic filter real, independently crawlable/indexable URLs -
/feed?topic=X was never indexable since its canonical strips the
query string back to bare /feed. Both are wired end to end (schemas,
Devii actions, docs API, sitemap, locustfile load-test coverage).
Quiz player: the auto-advance to the next question used to hide the
just-answered slide in the same tick as rendering the grade, so on
any multi-question quiz the Correct/Not correct feedback was never
actually visible before the view moved on. Delayed via setTimeout,
with the pending timer cleared on manual navigation and on
disconnect so it can't race or fire on a removed component.
Also includes other local changes already in progress in this
working tree before this session (messaging, push delivery,
deepsearch jobs, game economy, quiz builder) - verified by the full
suite passing (3467 tests) but not authored or individually reviewed
in this session.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VL9Xn57W5UR3HZbbuuzxdK
153 lines
4.8 KiB
Python
153 lines
4.8 KiB
Python
# retoor <retoor@molodetz.nl>
|
|
|
|
import time
|
|
from datetime import datetime, timedelta, timezone
|
|
import requests
|
|
from tests.conftest import BASE_URL
|
|
from devplacepy.database import get_table, refresh_snapshot
|
|
from devplacepy.database.pagination import PAGE_SIZE
|
|
from devplacepy.utils import generate_uid
|
|
|
|
JSON_topics = {"Accept": "application/json"}
|
|
_counter_topics = [0]
|
|
|
|
|
|
def _session_topics():
|
|
_counter_topics[0] += 1
|
|
name = f"tpc{int(time.time() * 1000)}{_counter_topics[0]}"
|
|
s = requests.Session()
|
|
s.post(
|
|
f"{BASE_URL}/auth/signup",
|
|
data={
|
|
"username": name,
|
|
"email": f"{name}@t.dev",
|
|
"password": "secret123",
|
|
"confirm_password": "secret123",
|
|
"birth_date": "1990-01-01",
|
|
"accept_terms": "1",
|
|
},
|
|
allow_redirects=True,
|
|
)
|
|
return s, name
|
|
|
|
|
|
def _create_post_topics(session, title, topic):
|
|
r = session.post(
|
|
f"{BASE_URL}/posts/create",
|
|
data={"content": f"Post body for {title}", "title": title, "topic": topic},
|
|
allow_redirects=False,
|
|
)
|
|
return r.headers["location"].split("/posts/")[-1]
|
|
|
|
|
|
def _create_post_direct_topics(user_uid, topic, order, marker=None):
|
|
uid = generate_uid()
|
|
marker = marker or f"tpc-{uid[:8]}"
|
|
get_table("posts").insert(
|
|
{
|
|
"deleted_at": None,
|
|
"deleted_by": None,
|
|
"uid": uid,
|
|
"user_uid": user_uid,
|
|
"slug": f"{uid[:8]}-{topic}-post",
|
|
"title": marker,
|
|
"content": f"Direct topic post content {order}",
|
|
"topic": topic,
|
|
"project_uid": None,
|
|
"image": None,
|
|
"stars": 0,
|
|
"created_at": (
|
|
datetime.now(timezone.utc) + timedelta(seconds=order)
|
|
).isoformat(),
|
|
}
|
|
)
|
|
return uid, marker
|
|
|
|
|
|
def _topic_hub_entry(topic):
|
|
r = requests.get(f"{BASE_URL}/topics", headers=JSON_topics)
|
|
data = r.json()
|
|
return next(t for t in data["topics"] if t["key"] == topic)
|
|
|
|
|
|
def test_topics_hub_lists_every_topic(app_server):
|
|
r = requests.get(f"{BASE_URL}/topics", headers=JSON_topics)
|
|
assert r.status_code == 200
|
|
data = r.json()
|
|
keys = {t["key"] for t in data["topics"]}
|
|
assert keys == {"devlog", "showcase", "question", "rant", "fun", "random", "politics"}
|
|
|
|
|
|
def test_topics_hub_post_count_reflects_new_posts(app_server):
|
|
s, name = _session_topics()
|
|
refresh_snapshot()
|
|
user_uid = get_table("users").find_one(username=name)["uid"]
|
|
before = _topic_hub_entry("rant")["post_count"]
|
|
for i in range(3):
|
|
_create_post_direct_topics(user_uid, "rant", i)
|
|
refresh_snapshot()
|
|
after = _topic_hub_entry("rant")["post_count"]
|
|
assert after - before == 3
|
|
|
|
|
|
def test_topic_page_lists_only_that_topics_posts(app_server):
|
|
s, _ = _session_topics()
|
|
unique = int(time.time() * 1000)
|
|
devlog_title = f"devlog-only-{unique}"
|
|
showcase_title = f"showcase-only-{unique}"
|
|
_create_post_topics(s, devlog_title, "devlog")
|
|
_create_post_topics(s, showcase_title, "showcase")
|
|
|
|
r = requests.get(f"{BASE_URL}/topics/devlog", headers=JSON_topics)
|
|
assert r.status_code == 200
|
|
data = r.json()
|
|
assert data["topic"] == "devlog"
|
|
titles = [item["post"]["title"] for item in data["posts"]]
|
|
assert devlog_title in titles
|
|
assert showcase_title not in titles
|
|
|
|
|
|
def test_topic_page_rejects_an_unknown_topic(app_server):
|
|
r = requests.get(f"{BASE_URL}/topics/not-a-real-topic", allow_redirects=False)
|
|
assert r.status_code == 404
|
|
|
|
|
|
def test_topic_page_canonical_and_breadcrumbs_are_topic_specific(app_server):
|
|
r = requests.get(f"{BASE_URL}/topics/showcase", allow_redirects=False)
|
|
assert r.status_code == 200
|
|
assert 'href="' in r.text
|
|
assert "/topics/showcase" in r.text
|
|
assert "Topics" in r.text
|
|
|
|
|
|
def test_topic_page_pagination_crosses_a_page_boundary(app_server):
|
|
s, name = _session_topics()
|
|
refresh_snapshot()
|
|
user_uid = get_table("users").find_one(username=name)["uid"]
|
|
count = PAGE_SIZE + 1
|
|
markers = []
|
|
for i in range(count):
|
|
_, marker = _create_post_direct_topics(user_uid, "fun", i, marker=f"tpcpag-{i}")
|
|
markers.append(marker)
|
|
refresh_snapshot()
|
|
|
|
r = requests.get(f"{BASE_URL}/topics/fun", headers=JSON_topics)
|
|
assert r.status_code == 200
|
|
body = r.json()
|
|
assert len(body["posts"]) == PAGE_SIZE
|
|
assert body["next_cursor"] is not None
|
|
|
|
r2 = requests.get(
|
|
f"{BASE_URL}/topics/fun",
|
|
headers=JSON_topics,
|
|
params={"before": body["next_cursor"]},
|
|
)
|
|
assert r2.status_code == 200
|
|
body2 = r2.json()
|
|
assert len(body2["posts"]) >= 1
|
|
|
|
seen_titles = {item["post"]["title"] for item in body["posts"]} | {
|
|
item["post"]["title"] for item in body2["posts"]
|
|
}
|
|
assert set(markers).issubset(seen_titles)
|