retoorandClaude Sonnet 5
3c69de9d55
Happy 404: an HTML 404 (unmatched route, or an explicit not-found inside a
real route) now renders a random existing post instead of the error page,
using the exact same context builder as a real post view. Toggle is the
happy_404_enabled site setting (default on, /admin/settings); JSON/API
requests and a handful of excluded prefixes are never affected. The pool of
candidate slugs is cached in-process and resampled periodically so it stays
fast and eventually cycles the whole posts table; on any internal failure it
falls straight through to the real 404 page.
Applying this everywhere surfaced ~60 existing tests that asserted a literal
404 for a legitimate resource-not-found flow (deleted post, unknown
container, wrong project slug, etc.) - each now disables the setting for the
duration of that specific check and restores it after, so the underlying
not-found behavior stays covered independently of the new feature.
Post page also gained, all built on the same shared post_page_context() so
they render identically on both a real post and a happy-404 page:
- A left sidebar (three separate cards, matching /feed's sidebar-card
convention) for "Gists from {author}", "Projects from {author}" (private
projects filtered through the normal visibility check), and "Related
Discussions" - each cached per author and invalidated on create/edit/
delete so new content shows up immediately.
- A right column reusing /feed's exact Daily Topic widget class for up to
three "Featured" articles (the existing but previously-unused `featured`
news flag), cached as a pool with per-request random sampling.
- A "Next post -> " link beside "Back to Feed", pointing at the next older
post site-wide (blocked authors skipped). Wired through the same next_url
mechanism already used for listing pagination, so it emits a real
backend-rendered <link rel="next"> tag for SEO, not just a visible link.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BWJy6PrMMt5hwWxQwia2rd
56 lines
2.1 KiB
Python
56 lines
2.1 KiB
Python
# retoor <retoor@molodetz.nl>
|
|
|
|
import time
|
|
|
|
from tests.conftest import BASE_URL, CACHE_VERSION_PROPAGATION_SECONDS, login_user
|
|
from devplacepy.database import get_table, set_setting
|
|
def _promote_to_admin(username: str) -> None:
|
|
users = get_table("users")
|
|
user = users.find_one(username=username)
|
|
if user:
|
|
users.update({"uid": user["uid"], "role": "Admin"}, ["uid"])
|
|
|
|
|
|
def test_services_data_json(page, seeded_db):
|
|
user = seeded_db["alice"]
|
|
_promote_to_admin(user["username"])
|
|
login_user(page, user)
|
|
page.goto(f"{BASE_URL}/admin/services/data", wait_until="domcontentloaded")
|
|
text = page.inner_text("body > pre") if page.locator("body > pre").count() > 0 else page.content()
|
|
import json
|
|
|
|
data = json.loads(text)
|
|
assert "services" in data
|
|
assert isinstance(data["services"], list)
|
|
|
|
|
|
def test_service_detail_unknown_404(page, seeded_db):
|
|
user = seeded_db["alice"]
|
|
_promote_to_admin(user["username"])
|
|
login_user(page, user)
|
|
set_setting("happy_404_enabled", "0")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
|
try:
|
|
resp = page.request.get(f"{BASE_URL}/admin/services/nope")
|
|
assert resp.status == 404
|
|
assert page.request.get(f"{BASE_URL}/admin/services/nope/data").status == 404
|
|
finally:
|
|
set_setting("happy_404_enabled", "1")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
|
|
|
|
|
def test_bots_service_registered_and_opt_in(page, seeded_db):
|
|
user = seeded_db["alice"]
|
|
_promote_to_admin(user["username"])
|
|
login_user(page, user)
|
|
page.goto(f"{BASE_URL}/admin/services", wait_until="domcontentloaded")
|
|
data = page.request.get(f"{BASE_URL}/admin/services/data").json()
|
|
bots = next(s for s in data["services"] if s["name"] == "bots")
|
|
assert bots["enabled"] is False
|
|
assert bots["status"] == "stopped"
|
|
assert "metrics" in bots
|
|
page.goto(f"{BASE_URL}/admin/services/bots", wait_until="domcontentloaded")
|
|
detail = page.locator("[data-service-detail][data-service='bots']")
|
|
assert detail.locator("input[name='bot_fleet_size']").count() == 1
|
|
assert detail.locator("input[name='bot_input_cost_per_1m']").count() == 1
|