retoorandClaude Sonnet 5
3c69de9d55
Happy 404: an HTML 404 (unmatched route, or an explicit not-found inside a
real route) now renders a random existing post instead of the error page,
using the exact same context builder as a real post view. Toggle is the
happy_404_enabled site setting (default on, /admin/settings); JSON/API
requests and a handful of excluded prefixes are never affected. The pool of
candidate slugs is cached in-process and resampled periodically so it stays
fast and eventually cycles the whole posts table; on any internal failure it
falls straight through to the real 404 page.
Applying this everywhere surfaced ~60 existing tests that asserted a literal
404 for a legitimate resource-not-found flow (deleted post, unknown
container, wrong project slug, etc.) - each now disables the setting for the
duration of that specific check and restores it after, so the underlying
not-found behavior stays covered independently of the new feature.
Post page also gained, all built on the same shared post_page_context() so
they render identically on both a real post and a happy-404 page:
- A left sidebar (three separate cards, matching /feed's sidebar-card
convention) for "Gists from {author}", "Projects from {author}" (private
projects filtered through the normal visibility check), and "Related
Discussions" - each cached per author and invalidated on create/edit/
delete so new content shows up immediately.
- A right column reusing /feed's exact Daily Topic widget class for up to
three "Featured" articles (the existing but previously-unused `featured`
news flag), cached as a pool with per-request random sampling.
- A "Next post -> " link beside "Back to Feed", pointing at the next older
post site-wide (blocked authors skipped). Wired through the same next_url
mechanism already used for listing pagination, so it emits a real
backend-rendered <link rel="next"> tag for SEO, not just a visible link.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BWJy6PrMMt5hwWxQwia2rd
73 lines
2.1 KiB
Python
73 lines
2.1 KiB
Python
# retoor <retoor@molodetz.nl>
|
|
|
|
import time
|
|
|
|
import requests
|
|
|
|
from tests.conftest import BASE_URL
|
|
|
|
JSON = {"Accept": "application/json"}
|
|
_counter = [0]
|
|
|
|
|
|
def _unique(prefix="nextpost"):
|
|
_counter[0] += 1
|
|
return f"{prefix}{int(time.time() * 1000)}{_counter[0]}"
|
|
|
|
|
|
def _signup():
|
|
name = _unique("nextuser")
|
|
session = requests.Session()
|
|
session.post(
|
|
f"{BASE_URL}/auth/signup",
|
|
data={
|
|
"username": name,
|
|
"email": f"{name}@t.dev",
|
|
"password": "secret123",
|
|
"confirm_password": "secret123",
|
|
"birth_date": "1990-01-01",
|
|
"accept_terms": "1",
|
|
},
|
|
allow_redirects=True,
|
|
)
|
|
return session
|
|
|
|
|
|
def _new_post(session, title=None):
|
|
return session.post(
|
|
f"{BASE_URL}/posts/create",
|
|
headers=JSON,
|
|
data={
|
|
"title": title or _unique("nextpostbody"),
|
|
"content": "content for the next-post navigation test",
|
|
"topic": "devlog",
|
|
},
|
|
).json()["data"]
|
|
|
|
|
|
def test_newer_post_links_to_the_next_older_post(app_server):
|
|
session = _signup()
|
|
older = _new_post(session, title="Older Post For Next Nav")
|
|
newer = _new_post(session, title="Newer Post For Next Nav")
|
|
|
|
r = requests.get(f"{BASE_URL}/posts/{newer['slug']}", headers=JSON)
|
|
assert r.status_code == 200
|
|
assert r.json()["next_post_url"] == f"/posts/{older['slug']}"
|
|
|
|
html = requests.get(f"{BASE_URL}/posts/{newer['slug']}")
|
|
assert f'href="/posts/{older["slug"]}" class="back-link next-post-link"' in html.text
|
|
assert f'<link rel="next" href="{BASE_URL}/posts/{older["slug"]}">' in html.text
|
|
|
|
|
|
def test_next_post_link_is_absent_when_the_url_is_none(app_server):
|
|
session = _signup()
|
|
post = _new_post(session)
|
|
|
|
data = requests.get(f"{BASE_URL}/posts/{post['slug']}", headers=JSON).json()
|
|
html = requests.get(f"{BASE_URL}/posts/{post['slug']}").text
|
|
if data["next_post_url"] is None:
|
|
assert "next-post-link" not in html
|
|
assert 'rel="next"' not in html
|
|
else:
|
|
assert f'href="{data["next_post_url"]}" class="back-link next-post-link"' in html
|