Devii window shrinks when double-clicking outside of it #44
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Devii's window gets smaller if you double-click outside of it. If you reopen it and repeat the process, it gets smaller again, and so on.
Steps to Reproduce
Expected Behaviour
Double-clicking outside of Devii's window does not shrink it.
Actual Behaviour
Double-clicking outside of Devii's window shrinks it.
Environment
Windows + Firefox.
Reported by D-04got10-01 via DevPlace.
Adding attachment via molodetz, for pravda.education had no such option.
Attachments are !visible here. Dunno if by design.
Posted by D-04got10-01 via DevPlace.
@D-04got10-01 attachments is a ticket for, to create that. Congrats, you made the first official ticket that is not made by me!! :) Also, dmmit. Yeah, i see it getting smaller now. Very subtile. I use it full time, and did not notice.
Posted by retoor via DevPlace.
hey my ai content fixer doesnt work here. no dots and lowercas
Posted by retoor via DevPlace.
Yeah. Wanted to test this feature. Seems to be working fine.
Posted by D-04got10-01 via DevPlace.
@D-04got10-01 as you can see, it makes something very nice out of it.
Posted by retoor via DevPlace.
Depends on one's reporting skills. But sure, allows for a quick report.
I am picking this ticket up now.
First I will bring up an isolated workspace with a fresh checkout and investigate whether the ticket matches the current state of the code before planning any change. I will announce every step here before I take it.
Starting research round 1 of at most 5.
I am now reading the relevant source, tests, and prior work in the live checkout to verify the ticket and gather the context needed for a concrete plan. This can take a while; I will post periodic progress updates until it completes.
Progress update: research round 1 is still running (10 minutes elapsed). I have not stalled; I will report the result here the moment this step completes.
Investigated the ticket against the current source and tests. The findings confirm the described behavior—window shrinking on double-click outside—is reproducible. The previous fix (commit
1c31c1d) mitigated the most severe runaway shrinking but did not eliminate the core problem: the CSS transition animation causes theResizeObserverto capture and persist a smaller (floor‑clamped) size, resulting in noticeable reduction. The ticket remains accurate as a description of the original issue, and the fix is incomplete.Decision is to proceed. Drafting a concrete implementation plan to address the root cause is the next step.
I am drafting the implementation plan now.
The research confirmed the ticket; I am turning the findings into a concrete, verifiable plan.
Drafted an implementation plan from the investigation findings to address the window shrinkage on double-click. The plan covers CSS transition suppression during programmatic resizes, a guard in
_onViewportChangeto prevent re-entry, new unit tests for clamping and state guards, and verification steps. Handing the plan to the execution agent for implementation.The full, verbatim implementation plan is attached: plan-ticket-44.md
Starting implementation attempt 1 of at most 5.
I am executing the plan inside this ticket's isolated workspace. This can take a while; I will post periodic progress updates until it completes.
The implementation attempt was run but could not complete. The execution agent reported that it requires clarification before it can proceed.
Could you clarify the requirement so I can continue?
I am picking this ticket up now.
First I will bring up an isolated workspace with a fresh checkout and investigate whether the ticket matches the current state of the code before planning any change. I will announce every step here before I take it.
I need input to continue.
What I tried: Retried this step 3 times.
What I found: Each attempt failed for internal reasons unrelated to this ticket. The details are in the operator's logs; this is not a judgment about the ticket.
The system needs operator attention before I can continue. Reply here once things are healthy and I will resume from where I left off.
I am picking this ticket up now.
First I will bring up an isolated workspace with a fresh checkout and investigate whether the ticket matches the current state of the code before planning any change. I will announce every step here before I take it.
Starting research round 1 of at most 5.
I am now reading the relevant source, tests, and prior work in the live checkout to verify the ticket and gather the context needed for a concrete plan. This can take a while; I will post periodic progress updates until it completes.
We reviewed the ticket against the current source and tests, and checked external documentation. The research confirms that double-clicking outside the window does not trigger any code path that would modify window geometry; the relevant handler returns early when Devii is open, and no progressive shrinking mechanism is invoked by the described steps. The reported behavior does not reproduce under the current codebase.
This does not appear to match the current state of the code. Could you confirm whether this is still accurate, or should the ticket be closed?
Interestingly enough, I see no changes. I have refreshed the page, skipping cache before verification.
Either the fix isn't in production, yet, or it's not working.
Posted by D-04got10-01 via DevPlace.
Thank you — that answers my question. Resuming work now.
I am picking the investigation back up with your clarification taken into account.
Starting research round 2 of at most 5.
I am now reading the relevant source, tests, and prior work in the live checkout to verify the ticket and gather the context needed for a concrete plan. This can take a while; I will post periodic progress updates until it completes.
Investigation into the ticket confirms a reproducible bug: the progressive window shrinking over repeated open/close cycles. Analysis of the current source and tests shows the root cause is the
ResizeObservercapturing intermediate CSS transition values and persisting them. The user's description of "double-clicking outside" appears to be a misidentification — the titlebar handler is the likely trigger — but the underlying shrinking behavior is real and well explained by these findings.The findings are sufficiently specific to directly plan a fix addressing both the
ResizeObserverguard and the titlebar handler conflict. Decision is to proceed.Next step will be drafting a concrete implementation plan with the necessary code changes.
I am drafting the implementation plan now.
The research confirmed the ticket; I am turning the findings into a concrete, verifiable plan.
Drafted an implementation plan based on the investigation findings. The plan addresses two root causes: the titlebar double-click event propagating to the document-level close handler, and the ResizeObserver capturing stale geometry during state transitions. Two targeted changes are specified — adding stopPropagation and a target check in the titlebar handler, and introducing a
_transitioningflag with a transitionend listener in FloatingWindow to skip the observer during transitions. An optional CSS fix for the launcher FAB when Devii is closed is noted but not required for the ticket.The definition of done is defined: titlebar double-click toggles maximize/normalize without closing, double-clicking outside the window still closes it, window geometry remains stable across close/reopen cycles, and all existing tests pass without regressions.
The plan is now ready and will be handed to the execution agent.
The full, verbatim implementation plan is attached: plan-ticket-44.md
A conflict appeared while rebasing onto
master; I am resolving it now.Handing the conflicting files to the execution agent for one resolution attempt.
Progress update: rebase conflict resolution is still running (20 minutes elapsed). I have not stalled; I will report the result here the moment this step completes.