retoor/devplacepy
1
0
Fork 1
Code Issues 15 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Guard :popover-open selector usage for Firefox compatibility #190

New Issue
Open
opened 2026-11-02 15:10:28 +01:00 by retoor · 0 comments
retoor commented 2026-11-02 15:10:28 +01:00
Owner
Copy Link
Copy Source

Summary

Clicking the Refactor button on /game does nothing and no confirmation popup appears. Console shows Document.querySelectorAll: ':popover-open' is not a valid selector originating from closeOtherPopovers() in AppDialog.js, called via open(). Same unguarded :popover-open use exists in close() via this.overlay.matches(":popover-open").

Steps to Reproduce

  1. Open /game in Firefox.
  2. Click the Refactor button.
  3. Observe no confirmation popup appears and check console for DOMException.

Expected Behaviour

Refactor confirmation dialog opens.

Actual Behaviour

No confirmation appears. Exception in closeOtherPopovers aborts open() before showing dialog.

Environment

Not provided.

Reported by D-04got10-01 via DevPlace.

## Summary Clicking the Refactor button on /game does nothing and no confirmation popup appears. Console shows `Document.querySelectorAll: ':popover-open' is not a valid selector` originating from `closeOtherPopovers()` in AppDialog.js, called via `open()`. Same unguarded `:popover-open` use exists in `close()` via `this.overlay.matches(":popover-open")`. ## Steps to Reproduce 1. Open /game in Firefox. 2. Click the Refactor button. 3. Observe no confirmation popup appears and check console for DOMException. ## Expected Behaviour Refactor confirmation dialog opens. ## Actual Behaviour No confirmation appears. Exception in `closeOtherPopovers` aborts `open()` before showing dialog. ## Environment Not provided. --- *Reported by **D-04got10-01** via DevPlace.*
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
typosaurus retoor
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: retoor/devplacepy#190