Fix pull request links in bot answers including trailing punctuation #152
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
When the bot posts a pull request URL at the end of a sentence, the trailing punctuation (e.g., a period) is included inside the hyperlink, making the URL invalid and resulting in a 404 error.
Steps to Reproduce
Expected Behaviour
The hyperlink should end at the URL and not include any trailing punctuation. The punctuation should appear outside the link.
Actual Behaviour
The punctuation is mixed into the hyperlink, causing the link to point to an invalid URL and return a 404 error.
Environment
Not provided.
Reported by Alice via DevPlace.
I am picking this ticket up now.
First I will bring up an isolated workspace with a fresh checkout and investigate whether the ticket matches the current state of the code before planning any change. I will announce every step here before I take it.
Starting research round 1 of at most 5.
I am now reading the relevant source, tests, and prior work in the live checkout to verify the ticket and gather the context needed for a concrete plan. This can take a while; I will post periodic progress updates until it completes.
Investigated the ticket against the current source and tests. The research findings confirm that both
rendering.pyandContentRenderer.jsmatch trailing punctuation as part of the URL, producing broken links. No existing fix addresses these specific renderers, and the ticket's description matches the observed defect.The issue is clearly identified and actionable without further investigation. Decision: proceed. Next steps involve drafting a concrete implementation plan.
I am drafting the implementation plan now.
The research confirmed the ticket; I am turning the findings into a concrete, verifiable plan.
The implementation plan has been drafted based on the investigation findings. The plan specifies changes to
_embed_urlindevplacepy/rendering.pyand the client-side URL renderer inContentRenderer.jsto strip trailing punctuation from bare URLs and render it outside the<a>element. Unit tests are included for the server-side fix, and the definition of done outlines verification steps.The plan is now being handed to the execution agent for implementation.
The full, verbatim implementation plan is attached: plan-ticket-152.md
Starting implementation attempt 1 of at most 5.
I am executing the plan inside this ticket's isolated workspace. This can take a while; I will post periodic progress updates until it completes.
Progress update: implementation attempt 1 is still running (10 minutes elapsed). I have not stalled; I will report the result here the moment this step completes.
Implementation attempt 1 finished; I am verifying it now.
Running the project's own build, test, and lint commands against the change.
The change was implemented on the first attempt, and all configured build, test, and lint commands completed successfully. The project's own validation checks therefore passed without issue.
Next steps are to commit the work, push the branch, and open a pull request for review.
I am delivering the change now.
Committing the verified change, pushing branch
typosaurus/ticket-152, and opening a pull request.Pushed the change to branch
typosaurus/ticket-152and opened pull request #153. The implementation passed the project's internal checks. Monitoring the pull request for review, merge, or further feedback.I mean, to be fair, it's valid to interprete a trailing period as potentially being part of the URL. I would suggest escaping the punctuation in the bot replies instead or using hyperlink markdown format to properly isolate the link in them. Changing how the automatic link detection works in general, just to remove an ending period, can potentially break it for others.
Posted by Alice via DevPlace.
Thanks for delivering half of the solution bots.
Posted by retoor via DevPlace.
@retoor not just that, the bot that formats and "fixes" the issue reports before posting them, stripped my description by half the stuff I said lol
Posted by Alice via DevPlace.