Add missing icon field to badges API response #146

New Issue
Closed
opened 2026-07-27 11:55:59 +02:00 by retoor · 15 comments
retoor commented 2026-07-27 11:55:59 +02:00
Owner
Copy Link

Summary

The badges API endpoint returns badge objects that are missing the icon field, which is present in the web application's badge display. Each badge should include an icon along with its name, but currently only the name is delivered.

Steps to Reproduce

  1. Make a GET request to the badges API endpoint.
  2. Observe the response JSON contains only name and created_at for each badge, with no icon field.

Expected Behaviour

Each badge object in the API response should include an icon field (e.g., a URL or icon identifier) in addition to name and created_at.

Actual Behaviour

Each badge object only contains name and created_at; the icon field is absent.

Environment

Not provided.

Reported by Lensflare via DevPlace.

## Summary The badges API endpoint returns badge objects that are missing the `icon` field, which is present in the web application's badge display. Each badge should include an icon along with its name, but currently only the name is delivered. ## Steps to Reproduce 1. Make a GET request to the badges API endpoint. 2. Observe the response JSON contains only `name` and `created_at` for each badge, with no `icon` field. ## Expected Behaviour Each badge object in the API response should include an `icon` field (e.g., a URL or icon identifier) in addition to `name` and `created_at`. ## Actual Behaviour Each badge object only contains `name` and `created_at`; the `icon` field is absent. ## Environment Not provided. --- *Reported by **Lensflare** via DevPlace.*
plan-ticket-146.md
1.7 KiB
retoor commented 2026-07-27 11:57:34 +02:00
Author
Owner
Copy Link

The icon looks like a simple emoji, so the string type for the icon will be fine. No need for urls or icon ids.

Posted by Lensflare via DevPlace.

The icon looks like a simple emoji, so the string type for the icon will be fine. No need for urls or icon ids. --- *Posted by **Lensflare** via DevPlace.*
typosaurus commented 2026-07-27 11:58:58 +02:00
Collaborator
Copy Link

I am picking this ticket up now.

First I will bring up an isolated workspace with a fresh checkout and investigate whether the ticket matches the current state of the code before planning any change. I will announce every step here before I take it.

I am picking this ticket up now. First I will bring up an isolated workspace with a fresh checkout and investigate whether the ticket matches the current state of the code before planning any change. I will announce every step here before I take it.
typosaurus commented 2026-07-27 11:59:10 +02:00
Collaborator
Copy Link

Starting research round 1 of at most 5.

I am now reading the relevant source, tests, and prior work in the live checkout to verify the ticket and gather the context needed for a concrete plan. This can take a while; I will post periodic progress updates until it completes.

Starting research round 1 of at most 5. I am now reading the relevant source, tests, and prior work in the live checkout to verify the ticket and gather the context needed for a concrete plan. This can take a while; I will post periodic progress updates until it completes.
typosaurus commented 2026-07-27 12:02:02 +02:00
Collaborator
Copy Link

Investigated the ticket against the current source and tests. The analysis confirms the API response is missing the icon field as described: the BadgeOut schema lacks it, and no enrichment occurs before serialization. The findings yield a precise, minimal fix that matches the ticket’s expected behavior, with no contradictions or need for further research.

Drafting a concrete implementation plan next.

Investigated the ticket against the current source and tests. The analysis confirms the API response is missing the `icon` field as described: the `BadgeOut` schema lacks it, and no enrichment occurs before serialization. The findings yield a precise, minimal fix that matches the ticket’s expected behavior, with no contradictions or need for further research. Drafting a concrete implementation plan next.
typosaurus commented 2026-07-27 12:02:13 +02:00
Collaborator
Copy Link

I am drafting the implementation plan now.

The research confirmed the ticket; I am turning the findings into a concrete, verifiable plan.

I am drafting the implementation plan now. The research confirmed the ticket; I am turning the findings into a concrete, verifiable plan.
typosaurus commented 2026-07-27 12:02:27 +02:00
Collaborator
Copy Link

Drafted an implementation plan based on the investigation findings. The plan covers schema updates, route enrichment, optional API testing, and verification steps needed to expose the icon field in badge API responses.

Handing the plan to the execution agent for implementation.

Drafted an implementation plan based on the investigation findings. The plan covers schema updates, route enrichment, optional API testing, and verification steps needed to expose the `icon` field in badge API responses. Handing the plan to the execution agent for implementation.
typosaurus commented 2026-07-27 12:02:28 +02:00
Collaborator
Copy Link

The full, verbatim implementation plan is attached: plan-ticket-146.md

The full, verbatim implementation plan is attached: [plan-ticket-146.md](https://retoor.molodetz.nl/attachments/cca35dc1-7731-460c-9c1d-7dbcd69a50fb)
typosaurus commented 2026-07-27 12:02:44 +02:00
Collaborator
Copy Link

Starting implementation attempt 1 of at most 5.

I am executing the plan inside this ticket's isolated workspace. This can take a while; I will post periodic progress updates until it completes.

Starting implementation attempt 1 of at most 5. I am executing the plan inside this ticket's isolated workspace. This can take a while; I will post periodic progress updates until it completes.
typosaurus commented 2026-07-27 12:08:16 +02:00
Collaborator
Copy Link

Implementation attempt 1 finished; I am verifying it now.

Running the project's own build, test, and lint commands against the change.

Implementation attempt 1 finished; I am verifying it now. Running the project's own build, test, and lint commands against the change.
typosaurus commented 2026-07-27 12:08:19 +02:00
Collaborator
Copy Link

The change was implemented on the first attempt, and all configured project checks—build, test, and lint—completed successfully. The implementation is therefore stable and ready for review. Next steps are to commit the changes, push a branch, and open a pull request.

The change was implemented on the first attempt, and all configured project checks—build, test, and lint—completed successfully. The implementation is therefore stable and ready for review. Next steps are to commit the changes, push a branch, and open a pull request.
typosaurus commented 2026-07-27 12:08:28 +02:00
Collaborator
Copy Link

I am delivering the change now.

Committing the verified change, pushing branch typosaurus/ticket-146, and opening a pull request.

I am delivering the change now. Committing the verified change, pushing branch `typosaurus/ticket-146`, and opening a pull request.
typosaurus referenced this issue from a commit 2026-07-27 12:08:32 +02:00
ticket #146 attempt 1
typosaurus commented 2026-07-27 12:08:38 +02:00
Collaborator
Copy Link

The change has been committed and pushed to branch typosaurus/ticket-146. A pull request is open at #147. The implementation passed the project's own checks, so the branch was submitted for integration.

The next step is to monitor the pull request for review, merge, or further feedback.

The change has been committed and pushed to branch `typosaurus/ticket-146`. A pull request is open at https://retoor.molodetz.nl/retoor/devplacepy/pulls/147. The implementation passed the project's own checks, so the branch was submitted for integration. The next step is to monitor the pull request for review, merge, or further feedback.
typosaurus commented 2026-07-27 12:36:11 +02:00
Collaborator
Copy Link

The pull request has been merged, resolving the ticket. The change addresses the reported issue and has passed review. No further follow-up is required at this time.

The pull request has been merged, resolving the ticket. The change addresses the reported issue and has passed review. No further follow-up is required at this time.
typosaurus commented 2026-07-27 12:36:11 +02:00
Collaborator
Copy Link

This ticket has reached its outcome. The pull request is merged and the branch is no longer needed.

Would you like me to clean up the branch and workspace for this ticket? Reply with /typosaurus cancel-and-cleanup to confirm, or leave it as is.

This ticket has reached its outcome. The pull request is merged and the branch is no longer needed. Would you like me to clean up the branch and workspace for this ticket? Reply with `/typosaurus cancel-and-cleanup` to confirm, or leave it as is.
typosaurus commented 2026-07-27 12:38:01 +02:00
Collaborator
Copy Link

Totally correct, the file(s):https://retoor.molodetz.nl/retoor/devplacepy/pulls/147/files#diff-8072c8ef0898a92e2443bc732bab9813a0b3dc14

But no unit test, but i have a agent that will recursively check that and update tests.

Will deploy now.

Totally correct, the file(s):https://retoor.molodetz.nl/retoor/devplacepy/pulls/147/files#diff-8072c8ef0898a92e2443bc732bab9813a0b3dc14 But no unit test, but i have a agent that will recursively check that and update tests. Will deploy now.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: retoor/devplacepy#146
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?