ticket #114 attempt 1

devplacepy/main.py

@@ -12,6 +12,7 @@ from fastapi import FastAPI, Request
 from fastapi.responses import HTMLResponse, RedirectResponse
 from fastapi.staticfiles import StaticFiles
 from fastapi.exceptions import RequestValidationError
+from starlette.middleware.gzip import GZipMiddleware
 from devplacepy.config import (
     STATIC_DIR,
     STATIC_VERSION,
@@ -609,6 +610,10 @@ async def response_timing(request: Request, call_next):
     response.headers["X-Response-Time"] = f"{(time.perf_counter() - start) * 1000:.1f}ms"
     return response
 
+
+app.add_middleware(GZipMiddleware, minimum_size=512, compresslevel=5)
+
+
 _home_cache = TTLCache(ttl=int(os.environ.get("DEVPLACE_HOME_CACHE_TTL", "60")), max_size=4)
 
 

devplacepy/models.py

@@ -439,8 +439,8 @@ class VoteForm(BaseModel):
     @field_validator("value")
     @classmethod
     def valid_value(cls, value):
-        if value not in (1, -1):
+        if value not in (1, -1, 0):
-            raise ValueError("value must be 1 or -1")
+            raise ValueError("value must be 1, -1, or 0")
         return value
 
 

devplacepy/services/devii/actions/catalog/engagement.py

@@ -22,7 +22,7 @@ ENGAGEMENT_ACTIONS: tuple[Action, ...] = (
             ),
             body(
                 "value",
-                "Vote value: 1 to upvote, -1 to downvote (re-send to remove).",
+                "Vote value: 1 to upvote, -1 to downvote, 0 to retract.",
                 required=True,
             ),
         ),

devplacepy/templates/docs/architecture-backend.html

@@ -11,7 +11,7 @@ How a request flows through middleware to a router, how the database layer is bu
 
 ## Middleware
 
-Six HTTP middlewares run as a stack around every request, listed outermost first. `response_timing` is the outermost and `refresh_db_snapshot` the innermost. Compression is handled by nginx in production; the Python application does not compress responses itself.
+Seven HTTP middlewares run as a stack around every request, listed outermost first. `response_timing` is the outermost, `refresh_db_snapshot` the innermost, and a `GZipMiddleware` (responses over 512 bytes) wraps the whole stack on top:
 
 | Middleware (outermost first) | Responsibility |
 |------------|----------------|

pyproject.toml

@@ -4,8 +4,7 @@ version = "1.0.0"
 description = "DevPlace - The Developer Social Network"
 requires-python = ">=3.12"
 dependencies = [
-    "fastapi>=0.110.0",
+    "fastapi",
-    "starlette>=0.37.0",
     "uvicorn[standard]",
     "jinja2",
     "python-multipart",

tests/api/votes.py

@@ -135,3 +135,13 @@ def test_non_ajax_vote_redirects_to_referer(app_server):
     )
     assert r.status_code == 302
     assert r.headers["location"] == "/gists"
+
+
+def test_explicit_zero_retracts_vote(app_server):
+    s_a, a_name = _session_votes()
+    s_b, _ = _session_votes()
+    post_uid = _make_post_votes(_uid_votes(a_name))
+    s_b.post(f"{BASE_URL}/votes/post/{post_uid}", data={"value": "1"}, headers=AJAX_votes)
+    r = s_b.post(f"{BASE_URL}/votes/post/{post_uid}", data={"value": "0"}, headers=AJAX_votes)
+    assert r.json()["value"] == 0
+    assert r.json()["net"] == 0