Optimization

2026-09-03 08:47:57 +02:00
parent 7d32ef17dd
commit 81d6aa68b6
8 changed files with 1234 additions and 35 deletions
@@ -83,3 +83,88 @@ def test_planning_enqueue_without_numbers_is_all_open(seeded_db):
    refresh_snapshot()
    job = get_table("jobs").find_one(uid=uid)
    assert json.loads(job["payload"])["numbers"] == []
+
+
+def _mark_done(uid, result):
+    get_table("jobs").update(
+        {"uid": uid, "status": "done", "result": json.dumps(result)}, ["uid"]
+    )
+    refresh_snapshot()
+
+
+def test_planning_download_serves_the_report_file(seeded_db):
+    from devplacepy.config import PLANNING_REPORTS_DIR
+    from devplacepy.services.jobs import queue
+
+    admin = _admin(seeded_db)
+    uid = queue.enqueue(
+        "planning", {"numbers": []}, "user", "planning-download-owner", "open-tickets-plan"
+    )
+    report_dir = PLANNING_REPORTS_DIR / "ab" / "cd"
+    report_dir.mkdir(parents=True, exist_ok=True)
+    report_path = report_dir / f"{uid}.open-tickets-plan.md"
+    report_path.write_text("# Plan\n\nDo the thing.\n", encoding="utf-8")
+    try:
+        _mark_done(
+            uid,
+            {
+                "download_url": f"/issues/planning/{uid}/download",
+                "local_path": str(report_path),
+                "final_name": "open-tickets-plan.md",
+                "markdown": "# Plan\n\nDo the thing.\n",
+                "ai_used": False,
+                "item_count": 0,
+                "bytes_out": report_path.stat().st_size,
+            },
+        )
+        response = admin.get(f"{BASE_URL}/issues/planning/{uid}/download")
+        assert response.status_code == 200, response.text[:300]
+        assert response.headers["content-type"].startswith("text/markdown")
+        assert "Do the thing." in response.text
+    finally:
+        get_table("jobs").delete(uid=uid)
+        report_path.unlink(missing_ok=True)
+
+
+def test_planning_download_rejects_a_local_path_outside_the_reports_dir(seeded_db):
+    from devplacepy.config import DATA_DIR
+    from devplacepy.services.jobs import queue
+
+    admin = _admin(seeded_db)
+    uid = queue.enqueue(
+        "planning", {"numbers": []}, "user", "planning-traversal-owner", "open-tickets-plan"
+    )
+    escape_path = DATA_DIR / f"escaped-{uid}.md"
+    escape_path.write_text("secret", encoding="utf-8")
+    try:
+        _mark_done(
+            uid,
+            {
+                "download_url": f"/issues/planning/{uid}/download",
+                "local_path": str(escape_path),
+                "final_name": "escaped.md",
+                "markdown": "secret",
+                "ai_used": False,
+                "item_count": 0,
+                "bytes_out": escape_path.stat().st_size,
+            },
+        )
+        response = admin.get(f"{BASE_URL}/issues/planning/{uid}/download")
+        assert response.status_code == 404
+    finally:
+        get_table("jobs").delete(uid=uid)
+        escape_path.unlink(missing_ok=True)
+
+
+def test_planning_download_pending_job_is_404(seeded_db):
+    from devplacepy.services.jobs import queue
+
+    admin = _admin(seeded_db)
+    uid = queue.enqueue(
+        "planning", {"numbers": []}, "user", "planning-pending-owner", "open-tickets-plan"
+    )
+    try:
+        response = admin.get(f"{BASE_URL}/issues/planning/{uid}/download")
+        assert response.status_code == 404
+    finally:
+        get_table("jobs").delete(uid=uid)