ticket #114 attempt 1
Some checks failed
DevPlace CI / test (pull_request) Failing after 11s
Details

Browse Source
This commit is contained in:
Typosaurus 2026-07-23 03:15:14 +00:00
parent ad1736ebf1
commit 7332e4dd59
4 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.dpc/verify_cache.json
View File

File diff suppressed because one or more lines are too long

4
devplacepy/models.py
View File

@ -439,8 +439,8 @@ class VoteForm(BaseModel):
@field_validator("value") @field_validator("value")
@classmethod @classmethod
def valid_value(cls, value): def valid_value(cls, value):
if value not in (1, -1): if value not in (1, -1, 0):
raise ValueError("value must be 1 or -1") raise ValueError("value must be 1, -1, or 0")
return value return value

2
devplacepy/services/devii/actions/catalog/engagement.py
View File

@ -22,7 +22,7 @@ ENGAGEMENT_ACTIONS: tuple[Action, ...] = (
), ),
body( body(
"value", "value",
"Vote value: 1 to upvote, -1 to downvote (re-send to remove).", "Vote value: 1 to upvote, -1 to downvote, 0 to retract.",
required=True, required=True,
), ),
), ),

10
tests/api/votes.py
View File

@ -135,3 +135,13 @@ def test_non_ajax_vote_redirects_to_referer(app_server):
) )
assert r.status_code == 302 assert r.status_code == 302
assert r.headers["location"] == "/gists" assert r.headers["location"] == "/gists"
def test_explicit_zero_retracts_vote(app_server):
s_a, a_name = _session_votes()
s_b, _ = _session_votes()
post_uid = _make_post_votes(_uid_votes(a_name))
s_b.post(f"{BASE_URL}/votes/post/{post_uid}", data={"value": "1"}, headers=AJAX_votes)
r = s_b.post(f"{BASE_URL}/votes/post/{post_uid}", data={"value": "0"}, headers=AJAX_votes)
assert r.json()["value"] == 0
assert r.json()["net"] == 0