switch all ints to bigints

Browse Source
This commit is contained in:
conorreid 2019-07-13 10:42:20 -04:00
parent 96f57f161a
commit 8409c40645
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dataset/types.py
View File

@ -27,10 +27,7 @@ class Types(object):
if isinstance(sample, bool): if isinstance(sample, bool):
return cls.boolean return cls.boolean
elif isinstance(sample, int): elif isinstance(sample, int):
if sample > 2147483647 or sample < -2147483648:
return cls.bigint return cls.bigint
else:
return cls.integer
elif isinstance(sample, float): elif isinstance(sample, float):
return cls.float return cls.float
elif isinstance(sample, datetime): elif isinstance(sample, datetime):

4
test/test_dataset.py
View File

@ -6,7 +6,7 @@ import os
import unittest import unittest
from datetime import datetime from datetime import datetime
from sqlalchemy import FLOAT, INTEGER, TEXT, BIGINT from sqlalchemy import FLOAT, TEXT, BIGINT
from sqlalchemy.exc import IntegrityError, SQLAlchemyError, ArgumentError from sqlalchemy.exc import IntegrityError, SQLAlchemyError, ArgumentError
from dataset import connect from dataset import connect
@ -435,7 +435,7 @@ class TableTestCase(unittest.TestCase):
tbl.table.c['bar'].type tbl.table.c['bar'].type
tbl.create_column_by_example('bar', 1) tbl.create_column_by_example('bar', 1)
assert 'bar' in tbl.table.c, tbl.table.c assert 'bar' in tbl.table.c, tbl.table.c
assert isinstance(tbl.table.c['bar'].type, INTEGER), \ assert isinstance(tbl.table.c['bar'].type, BIGINT), \
tbl.table.c['bar'].type tbl.table.c['bar'].type
tbl.create_column_by_example('pippo', 'test') tbl.create_column_by_example('pippo', 'test')
assert 'pippo' in tbl.table.c, tbl.table.c assert 'pippo' in tbl.table.c, tbl.table.c