From 8409c40645314d50e66e039cc90b3e32c4499c38 Mon Sep 17 00:00:00 2001 From: conorreid Date: Sat, 13 Jul 2019 10:42:20 -0400 Subject: [PATCH] switch all ints to bigints --- dataset/types.py | 5 +---- test/test_dataset.py | 4 ++-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/dataset/types.py b/dataset/types.py index 6cb3dba..46f5550 100644 --- a/dataset/types.py +++ b/dataset/types.py @@ -27,10 +27,7 @@ class Types(object): if isinstance(sample, bool): return cls.boolean elif isinstance(sample, int): - if sample > 2147483647 or sample < -2147483648: - return cls.bigint - else: - return cls.integer + return cls.bigint elif isinstance(sample, float): return cls.float elif isinstance(sample, datetime): diff --git a/test/test_dataset.py b/test/test_dataset.py index 1e73918..22530c9 100644 --- a/test/test_dataset.py +++ b/test/test_dataset.py @@ -6,7 +6,7 @@ import os import unittest from datetime import datetime -from sqlalchemy import FLOAT, INTEGER, TEXT, BIGINT +from sqlalchemy import FLOAT, TEXT, BIGINT from sqlalchemy.exc import IntegrityError, SQLAlchemyError, ArgumentError from dataset import connect @@ -435,7 +435,7 @@ class TableTestCase(unittest.TestCase): tbl.table.c['bar'].type tbl.create_column_by_example('bar', 1) assert 'bar' in tbl.table.c, tbl.table.c - assert isinstance(tbl.table.c['bar'].type, INTEGER), \ + assert isinstance(tbl.table.c['bar'].type, BIGINT), \ tbl.table.c['bar'].type tbl.create_column_by_example('pippo', 'test') assert 'pippo' in tbl.table.c, tbl.table.c