Remove unused arguments, fixes #343.

Browse Source
This commit is contained in:
Friedrich Lindenberg 2020-11-14 22:51:05 +01:00
parent de68e2ba2b
commit 2a6a6c1e22
2 changed files with 6 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
dataset/__init__.py
View File

@ -17,9 +17,7 @@ __version__ = "1.3.2"
def connect( def connect(
url=None, url=None,
schema=None, schema=None,
reflect_metadata=True,
engine_kwargs=None, engine_kwargs=None,
reflect_views=True,
ensure_schema=True, ensure_schema=True,
row_type=row_type, row_type=row_type,
sqlite_wal_mode=True, sqlite_wal_mode=True,
@ -28,14 +26,11 @@ def connect(
*url* can be any valid `SQLAlchemy engine URL`_. If *url* is not defined *url* can be any valid `SQLAlchemy engine URL`_. If *url* is not defined
it will try to use *DATABASE_URL* from environment variable. Returns an it will try to use *DATABASE_URL* from environment variable. Returns an
instance of :py:class:`Database <dataset.Database>`. Set *reflect_metadata* instance of :py:class:`Database <dataset.Database>`. Additionally,
to False if you don't want the entire database schema to be pre-loaded. *engine_kwargs* will be directly passed to SQLAlchemy, e.g. set
This significantly speeds up connecting to large databases with lots of *engine_kwargs={'pool_recycle': 3600}* will avoid `DB connection timeout`_.
tables. *reflect_views* can be set to False if you don't want views to be Set *row_type* to an alternate dict-like class to change the type of
loaded. Additionally, *engine_kwargs* will be directly passed to container rows are stored in.::
SQLAlchemy, e.g. set *engine_kwargs={'pool_recycle': 3600}* will avoid `DB
connection timeout`_. Set *row_type* to an alternate dict-like class to
change the type of container rows are stored in.::
db = dataset.connect('sqlite:///factbook.db') db = dataset.connect('sqlite:///factbook.db')
@ -53,9 +48,7 @@ def connect(
return Database( return Database(
url, url,
schema=schema, schema=schema,
reflect_metadata=reflect_metadata,
engine_kwargs=engine_kwargs, engine_kwargs=engine_kwargs,
reflect_views=reflect_views,
ensure_schema=ensure_schema, ensure_schema=ensure_schema,
row_type=row_type, row_type=row_type,
sqlite_wal_mode=sqlite_wal_mode, sqlite_wal_mode=sqlite_wal_mode,

2
dataset/database.py
View File

@ -27,9 +27,7 @@ class Database(object):
self, self,
url, url,
schema=None, schema=None,
reflect_metadata=True,
engine_kwargs=None, engine_kwargs=None,
reflect_views=True,
ensure_schema=True, ensure_schema=True,
row_type=row_type, row_type=row_type,
sqlite_wal_mode=True, sqlite_wal_mode=True,