removed obsolete TODOs

Browse Source
This commit is contained in:
Wilhelm Oks 2024-12-23 16:42:28 +01:00
parent bf033acc93
commit 114bc4bf07
3 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Package.resolved
View File

@ -1,13 +1,13 @@
{ {
"originHash" : "e6d5e17e67c8a09b38a3e356fa94b64f66f993b6102d12b3e4ad9adc4352c7d0", "originHash" : "784fdb7c7e39f222bad686cbadee649d54ea0f27366fc78043d40dbc6b843cf4",
"pins" : [ "pins" : [
{ {
"identity" : "kreerequest", "identity" : "kreerequest",
"kind" : "remoteSourceControl", "kind" : "remoteSourceControl",
"location" : "https://github.com/WilhelmOks/KreeRequest", "location" : "https://github.com/WilhelmOks/KreeRequest",
"state" : { "state" : {
"revision" : "ce0d2ecdf923a9110b1439f22e868d22dd4ca006", "revision" : "1a6ae5c74649546473c1ffbbec16794ecd3073bd",
"version" : "1.0.2" "version" : "1.0.3"
} }
} }
], ],

2
Package.swift
View File

@ -14,7 +14,7 @@ let package = Package(
), ),
], ],
dependencies: [ dependencies: [
.package(url: "https://github.com/WilhelmOks/KreeRequest", .upToNextMajor(from: "1.0.2")), .package(url: "https://github.com/WilhelmOks/KreeRequest", .upToNextMajor(from: "1.0.3")),
], ],
targets: [ targets: [
// Targets are the basic building blocks of a package, defining a module or a test suite. // Targets are the basic building blocks of a package, defining a module or a test suite.

3
Sources/SwiftDevRant/DevRantRequest.swift
View File

@ -157,8 +157,6 @@ public extension DevRantRequest {
parameters["limit"] = String(limit) parameters["limit"] = String(limit)
parameters["skip"] = String(skip) parameters["skip"] = String(skip)
//parameters["sort"] = "algo" //TODO: This seems wrong. Check if this is needed or not.
let config = makeConfig(.get, path: "devrant/weekly-rants", urlParameters: parameters, token: token) let config = makeConfig(.get, path: "devrant/weekly-rants", urlParameters: parameters, token: token)
let response: RantFeed.CodingData = try await request.requestJson(config: config, apiError: DevRantApiError.CodingData.self) let response: RantFeed.CodingData = try await request.requestJson(config: config, apiError: DevRantApiError.CodingData.self)
@ -194,7 +192,6 @@ public extension DevRantRequest {
var parameters: [String: String] = [:] var parameters: [String: String] = [:]
parameters["last_comment_id"] = lastCommentId.flatMap { String($0) } parameters["last_comment_id"] = lastCommentId.flatMap { String($0) }
//parameters["ver"] = "1.17.0.4" //TODO: check if this is needed
let config = makeConfig(.get, path: "devrant/rants/\(rantId)", urlParameters: parameters, token: token) let config = makeConfig(.get, path: "devrant/rants/\(rantId)", urlParameters: parameters, token: token)