From 114bc4bf07d7ea447c0650312358a89c71199909 Mon Sep 17 00:00:00 2001 From: Wilhelm Oks Date: Mon, 23 Dec 2024 16:42:28 +0100 Subject: [PATCH] removed obsolete TODOs --- Package.resolved | 6 +++--- Package.swift | 2 +- Sources/SwiftDevRant/DevRantRequest.swift | 3 --- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/Package.resolved b/Package.resolved index 5e87354..b51823f 100644 --- a/Package.resolved +++ b/Package.resolved @@ -1,13 +1,13 @@ { - "originHash" : "e6d5e17e67c8a09b38a3e356fa94b64f66f993b6102d12b3e4ad9adc4352c7d0", + "originHash" : "784fdb7c7e39f222bad686cbadee649d54ea0f27366fc78043d40dbc6b843cf4", "pins" : [ { "identity" : "kreerequest", "kind" : "remoteSourceControl", "location" : "https://github.com/WilhelmOks/KreeRequest", "state" : { - "revision" : "ce0d2ecdf923a9110b1439f22e868d22dd4ca006", - "version" : "1.0.2" + "revision" : "1a6ae5c74649546473c1ffbbec16794ecd3073bd", + "version" : "1.0.3" } } ], diff --git a/Package.swift b/Package.swift index 55ce723..8818e3a 100644 --- a/Package.swift +++ b/Package.swift @@ -14,7 +14,7 @@ let package = Package( ), ], dependencies: [ - .package(url: "https://github.com/WilhelmOks/KreeRequest", .upToNextMajor(from: "1.0.2")), + .package(url: "https://github.com/WilhelmOks/KreeRequest", .upToNextMajor(from: "1.0.3")), ], targets: [ // Targets are the basic building blocks of a package, defining a module or a test suite. diff --git a/Sources/SwiftDevRant/DevRantRequest.swift b/Sources/SwiftDevRant/DevRantRequest.swift index 04e4334..d0e478d 100644 --- a/Sources/SwiftDevRant/DevRantRequest.swift +++ b/Sources/SwiftDevRant/DevRantRequest.swift @@ -157,8 +157,6 @@ public extension DevRantRequest { parameters["limit"] = String(limit) parameters["skip"] = String(skip) - //parameters["sort"] = "algo" //TODO: This seems wrong. Check if this is needed or not. - let config = makeConfig(.get, path: "devrant/weekly-rants", urlParameters: parameters, token: token) let response: RantFeed.CodingData = try await request.requestJson(config: config, apiError: DevRantApiError.CodingData.self) @@ -194,7 +192,6 @@ public extension DevRantRequest { var parameters: [String: String] = [:] parameters["last_comment_id"] = lastCommentId.flatMap { String($0) } - //parameters["ver"] = "1.17.0.4" //TODO: check if this is needed let config = makeConfig(.get, path: "devrant/rants/\(rantId)", urlParameters: parameters, token: token)