forked from retoor/devplacepy
retoorandClaude Sonnet 5
3c69de9d55
Happy 404: an HTML 404 (unmatched route, or an explicit not-found inside a
real route) now renders a random existing post instead of the error page,
using the exact same context builder as a real post view. Toggle is the
happy_404_enabled site setting (default on, /admin/settings); JSON/API
requests and a handful of excluded prefixes are never affected. The pool of
candidate slugs is cached in-process and resampled periodically so it stays
fast and eventually cycles the whole posts table; on any internal failure it
falls straight through to the real 404 page.
Applying this everywhere surfaced ~60 existing tests that asserted a literal
404 for a legitimate resource-not-found flow (deleted post, unknown
container, wrong project slug, etc.) - each now disables the setting for the
duration of that specific check and restores it after, so the underlying
not-found behavior stays covered independently of the new feature.
Post page also gained, all built on the same shared post_page_context() so
they render identically on both a real post and a happy-404 page:
- A left sidebar (three separate cards, matching /feed's sidebar-card
convention) for "Gists from {author}", "Projects from {author}" (private
projects filtered through the normal visibility check), and "Related
Discussions" - each cached per author and invalidated on create/edit/
delete so new content shows up immediately.
- A right column reusing /feed's exact Daily Topic widget class for up to
three "Featured" articles (the existing but previously-unused `featured`
news flag), cached as a pool with per-request random sampling.
- A "Next post -> " link beside "Back to Feed", pointing at the next older
post site-wide (blocked authors skipped). Wired through the same next_url
mechanism already used for listing pagination, so it emits a real
backend-rendered <link rel="next"> tag for SEO, not just a visible link.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BWJy6PrMMt5hwWxQwia2rd
71 lines
2.1 KiB
Python
71 lines
2.1 KiB
Python
# retoor <retoor@molodetz.nl>
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
import os
|
|
import random
|
|
|
|
from fastapi import Request
|
|
from fastapi.responses import HTMLResponse
|
|
|
|
from devplacepy.cache import TTLCache
|
|
from devplacepy.content import load_detail
|
|
from devplacepy.database import db, get_setting
|
|
from devplacepy.routers.posts import post_page_context
|
|
from devplacepy.templating import templates
|
|
from devplacepy.utils import get_current_user
|
|
|
|
logger = logging.getLogger("happy404")
|
|
|
|
POOL_TTL_SECONDS = int(os.environ.get("DEVPLACE_HAPPY_404_POOL_TTL", "300"))
|
|
POOL_SIZE = 100
|
|
|
|
API_PATH_PREFIXES = ("/api", "/dbapi", "/openai", "/xmlrpc", "/swagger", "/openapi.json")
|
|
|
|
_pool_cache = TTLCache(ttl=POOL_TTL_SECONDS, max_size=1)
|
|
|
|
|
|
def _post_pool() -> list[str]:
|
|
cached = _pool_cache.get("slugs")
|
|
if cached is not None:
|
|
return cached
|
|
slugs: list[str] = []
|
|
if "posts" in db.tables:
|
|
rows = db.query(
|
|
"SELECT slug, uid FROM posts WHERE deleted_at IS NULL ORDER BY RANDOM() LIMIT :limit",
|
|
limit=POOL_SIZE,
|
|
)
|
|
slugs = [row["slug"] or row["uid"] for row in rows]
|
|
_pool_cache.set("slugs", slugs)
|
|
return slugs
|
|
|
|
|
|
def _eligible(request: Request) -> bool:
|
|
if request.method != "GET":
|
|
return False
|
|
if request.url.path.startswith(API_PATH_PREFIXES):
|
|
return False
|
|
return get_setting("happy_404_enabled", "1") == "1"
|
|
|
|
|
|
def render(request: Request) -> HTMLResponse | None:
|
|
try:
|
|
if not _eligible(request):
|
|
return None
|
|
pool = _post_pool()
|
|
if not pool:
|
|
return None
|
|
slug = random.choice(pool)
|
|
user = get_current_user(request)
|
|
detail = load_detail("posts", "post", slug, user)
|
|
if not detail:
|
|
return None
|
|
context = post_page_context(
|
|
request, user, detail, robots="noindex,nofollow"
|
|
)
|
|
return templates.TemplateResponse(request, "post.html", context)
|
|
except Exception as exc: # noqa: BLE001 - a happy-404 bug must never break the 404 page
|
|
logger.warning("happy_404 render failed: %s", exc)
|
|
return None
|