forked from retoor/devplacepy
retoorandClaude Sonnet 5
3c69de9d55
Happy 404: an HTML 404 (unmatched route, or an explicit not-found inside a
real route) now renders a random existing post instead of the error page,
using the exact same context builder as a real post view. Toggle is the
happy_404_enabled site setting (default on, /admin/settings); JSON/API
requests and a handful of excluded prefixes are never affected. The pool of
candidate slugs is cached in-process and resampled periodically so it stays
fast and eventually cycles the whole posts table; on any internal failure it
falls straight through to the real 404 page.
Applying this everywhere surfaced ~60 existing tests that asserted a literal
404 for a legitimate resource-not-found flow (deleted post, unknown
container, wrong project slug, etc.) - each now disables the setting for the
duration of that specific check and restores it after, so the underlying
not-found behavior stays covered independently of the new feature.
Post page also gained, all built on the same shared post_page_context() so
they render identically on both a real post and a happy-404 page:
- A left sidebar (three separate cards, matching /feed's sidebar-card
convention) for "Gists from {author}", "Projects from {author}" (private
projects filtered through the normal visibility check), and "Related
Discussions" - each cached per author and invalidated on create/edit/
delete so new content shows up immediately.
- A right column reusing /feed's exact Daily Topic widget class for up to
three "Featured" articles (the existing but previously-unused `featured`
news flag), cached as a pool with per-request random sampling.
- A "Next post -> " link beside "Back to Feed", pointing at the next older
post site-wide (blocked authors skipped). Wired through the same next_url
mechanism already used for listing pagination, so it emits a real
backend-rendered <link rel="next"> tag for SEO, not just a visible link.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BWJy6PrMMt5hwWxQwia2rd
76 lines
2.7 KiB
Python
76 lines
2.7 KiB
Python
# retoor <retoor@molodetz.nl>
|
|
|
|
import time
|
|
|
|
from tests.conftest import BASE_URL, CACHE_VERSION_PROPAGATION_SECONDS
|
|
from devplacepy.database import set_setting
|
|
|
|
|
|
def test_issues_page_loads(alice):
|
|
page, _ = alice
|
|
page.goto(f"{BASE_URL}/issues", wait_until="domcontentloaded")
|
|
assert page.is_visible("h1:has-text('Issue Reports')")
|
|
|
|
|
|
def test_issues_filters_visible(alice):
|
|
page, _ = alice
|
|
page.goto(f"{BASE_URL}/issues", wait_until="domcontentloaded")
|
|
assert page.locator(".issues-filter:has-text('Open')").is_visible()
|
|
assert page.locator(".issues-filter:has-text('Closed')").is_visible()
|
|
assert page.locator(".issues-filter:has-text('All')").is_visible()
|
|
|
|
|
|
def test_issues_not_configured_notice(alice):
|
|
page, _ = alice
|
|
page.goto(f"{BASE_URL}/issues", wait_until="domcontentloaded")
|
|
assert page.is_visible("text=The issue tracker is not configured yet.")
|
|
|
|
|
|
def test_issues_create_modal(alice):
|
|
page, _ = alice
|
|
page.goto(f"{BASE_URL}/issues", wait_until="domcontentloaded")
|
|
page.click("button:has-text('Report Issue')")
|
|
assert page.is_visible("h3:has-text('Report an Issue')")
|
|
|
|
|
|
def test_issues_create_cancel(alice):
|
|
page, _ = alice
|
|
page.goto(f"{BASE_URL}/issues", wait_until="domcontentloaded")
|
|
page.click("button:has-text('Report Issue')")
|
|
page.click("button:has-text('Cancel')")
|
|
modal = page.locator("#create-issue-modal")
|
|
assert not modal.is_visible()
|
|
|
|
|
|
def test_issues_unauth(page):
|
|
page.goto(f"{BASE_URL}/issues", wait_until="domcontentloaded")
|
|
assert page.is_visible("h1:has-text('Issue Reports')")
|
|
assert page.locator("a.login-required:has-text('Report Issue')").is_visible()
|
|
assert page.locator("#create-issue-modal").count() == 0
|
|
|
|
|
|
def test_issue_button_icon_spacing(alice):
|
|
page, _ = alice
|
|
page.goto(f"{BASE_URL}/issues", wait_until="domcontentloaded")
|
|
html = page.locator("button:has-text('Report Issue')").inner_html()
|
|
assert "</span> Report Issue" in html
|
|
page.goto(f"{BASE_URL}/", wait_until="domcontentloaded")
|
|
landing = page.locator("a:has-text('Issue Report')").inner_html()
|
|
assert "</span> Issue Report" in landing
|
|
page.goto(f"{BASE_URL}/feed", wait_until="domcontentloaded")
|
|
footer = page.locator("a:has-text('Issue Report')").inner_html()
|
|
assert "</span> Issue Report" in footer
|
|
|
|
|
|
def test_issue_detail_not_configured(alice):
|
|
page, _ = alice
|
|
set_setting("happy_404_enabled", "0")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
|
try:
|
|
page.goto(f"{BASE_URL}/issues/999", wait_until="domcontentloaded")
|
|
assert page.is_visible("h1.error-code:has-text('404')")
|
|
assert page.is_visible("text=Page not found")
|
|
finally:
|
|
set_setting("happy_404_enabled", "1")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|