forked from retoor/devplacepy
retoorandClaude Sonnet 5
3c69de9d55
Happy 404: an HTML 404 (unmatched route, or an explicit not-found inside a
real route) now renders a random existing post instead of the error page,
using the exact same context builder as a real post view. Toggle is the
happy_404_enabled site setting (default on, /admin/settings); JSON/API
requests and a handful of excluded prefixes are never affected. The pool of
candidate slugs is cached in-process and resampled periodically so it stays
fast and eventually cycles the whole posts table; on any internal failure it
falls straight through to the real 404 page.
Applying this everywhere surfaced ~60 existing tests that asserted a literal
404 for a legitimate resource-not-found flow (deleted post, unknown
container, wrong project slug, etc.) - each now disables the setting for the
duration of that specific check and restores it after, so the underlying
not-found behavior stays covered independently of the new feature.
Post page also gained, all built on the same shared post_page_context() so
they render identically on both a real post and a happy-404 page:
- A left sidebar (three separate cards, matching /feed's sidebar-card
convention) for "Gists from {author}", "Projects from {author}" (private
projects filtered through the normal visibility check), and "Related
Discussions" - each cached per author and invalidated on create/edit/
delete so new content shows up immediately.
- A right column reusing /feed's exact Daily Topic widget class for up to
three "Featured" articles (the existing but previously-unused `featured`
news flag), cached as a pool with per-request random sampling.
- A "Next post -> " link beside "Back to Feed", pointing at the next older
post site-wide (blocked authors skipped). Wired through the same next_url
mechanism already used for listing pagination, so it emits a real
backend-rendered <link rel="next"> tag for SEO, not just a visible link.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BWJy6PrMMt5hwWxQwia2rd
67 lines
2.0 KiB
Python
67 lines
2.0 KiB
Python
# retoor <retoor@molodetz.nl>
|
|
|
|
import time
|
|
|
|
import requests
|
|
from tests.conftest import BASE_URL, CACHE_VERSION_PROPAGATION_SECONDS
|
|
from devplacepy.database import get_table, refresh_snapshot, set_setting
|
|
|
|
JSON = {"Accept": "application/json"}
|
|
|
|
|
|
def _admin():
|
|
refresh_snapshot()
|
|
key = get_table("users").find_one(username="alice_test")["api_key"]
|
|
s = requests.Session()
|
|
s.headers.update({"X-API-KEY": key})
|
|
return s
|
|
|
|
|
|
def test_bots_page_requires_login(app_server):
|
|
r = requests.get(f"{BASE_URL}/admin/bots", allow_redirects=False)
|
|
assert r.status_code in (302, 303)
|
|
|
|
|
|
def test_bots_data_denied_for_non_admin(app_server, seeded_db):
|
|
s = requests.Session()
|
|
s.post(
|
|
f"{BASE_URL}/auth/login",
|
|
data={
|
|
"email": seeded_db["bob"]["email"],
|
|
"password": seeded_db["bob"]["password"],
|
|
},
|
|
)
|
|
r = s.get(f"{BASE_URL}/admin/bots/data", allow_redirects=False)
|
|
assert r.status_code in (302, 303, 403)
|
|
r_json = s.get(f"{BASE_URL}/admin/bots/data", headers=JSON, allow_redirects=False)
|
|
assert r_json.status_code == 403
|
|
|
|
|
|
def test_bots_data_shape_for_admin(app_server, seeded_db):
|
|
admin = _admin()
|
|
r = admin.get(f"{BASE_URL}/admin/bots/data", headers=JSON)
|
|
assert r.status_code == 200, r.text[:300]
|
|
body = r.json()
|
|
assert "frames" in body
|
|
assert isinstance(body["frames"], list)
|
|
assert "enabled" in body
|
|
assert isinstance(body["enabled"], bool)
|
|
assert "service_status" in body
|
|
|
|
|
|
def test_bots_frame_missing_is_404(app_server, seeded_db):
|
|
admin = _admin()
|
|
set_setting("happy_404_enabled", "0")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
|
try:
|
|
r = admin.get(f"{BASE_URL}/admin/bots/999/frame.jpg", allow_redirects=False)
|
|
assert r.status_code == 404
|
|
finally:
|
|
set_setting("happy_404_enabled", "1")
|
|
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
|
|
|
|
|
def test_bots_frame_requires_admin(app_server, seeded_db):
|
|
r = requests.get(f"{BASE_URL}/admin/bots/0/frame.jpg", allow_redirects=False)
|
|
assert r.status_code in (302, 303)
|