blindxfish/devplacepy
1
0
Fork 0
forked from retoor/devplacepy
Code Pull Requests Activity

feat: enforce hard test-tier requirement across all DevPlace workflow agents and feature-builder docs

Browse Source 
Update the feature-builder agent prompt, test-maintainer agent, and all four workflow JS files (devii-tool, endpoint, feature, job-service) to codify the DevPlace test standard as a non-optional project requirement: one test file per endpoint, directory tree mirroring the URL/source path, split into three tiers (unit, api, e2e). Add explicit Test phases to devii-tool, endpoint, feature, and job-service workflows, and embed tier-specific test instructions (path mapping, fixture choice, coverage scope) directly in each workflow's meta description and TESTS constant.
This commit is contained in:
retoor
2026-06-15 12:10:14 +00:00
parent 3c7527988e
commit e1874f9b6a
71 changed files with 2198 additions and 145 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.claude/workflows/job-service.js
+12 -4
View File
@@ -1,13 +1,14 @@
// retoor <retoor@molodetz.nl>
export const meta = {
name: 'job-service',
description: 'Scaffold an async JobService (the zip/fork pattern): the JobService subclass, enqueue/status/download routes, the JobOut schema, main.py registration, Devii tools, JobPoller frontend, and docs, then verify',
description: 'Scaffold an async JobService (the zip/fork pattern): the JobService subclass, enqueue/status/download routes, the JobOut schema, main.py registration, Devii tools, JobPoller frontend, and docs, then verify and write the integration tests (enqueue, status, download) in the api tier',
phases: [
{ title: 'Understand', detail: 'read ZipService and ForkService as the template' },
{ title: 'Plan', detail: 'a per-touchpoint plan for the new job kind' },
{ title: 'Implement', detail: 'build the service and all consumers in the repo' },
{ title: 'Verify', detail: 'completeness, security, and audit-log review' },
{ title: 'Fix', detail: 'close gaps and write the job tests' },
{ title: 'Fix', detail: 'close gaps from the review' },
{ title: 'Test', detail: 'write the api-tier integration tests for enqueue, status, and download' },
],
}
@@ -34,6 +35,13 @@ const CHECKLIST = [
'9. README.md + AGENTS.md - document the new job kind.',
].join('\n')
const TESTS = [
'DevPlace test standard (a hard project requirement - one test file per endpoint, the directory tree mirroring the URL path):',
'A job kind is exercised over HTTP, so its tests live in tests/api/ against the live uvicorn subprocess (app_server/seeded_db, requests/httpx vs BASE_URL), one file per route path (POST /projects/{slug}/zip -> tests/api/projects/zip.py; GET /zips/{uid} -> tests/api/zips/index.py). Cover enqueue (authz + a job uid back), status (the *JobOut shape and lifecycle), and download/result (the capability URL) where applicable.',
'Because the service loop only runs in the lock owner and tests set DEVPLACE_DISABLE_SERVICES=1, assert the enqueue contract and the pending/known status shape rather than waiting on real completion; if you need a finished job, drive process() directly in a unit test under tests/unit/services/jobs/.',
'Required patterns: scoped assertions; try/finally restore of any flipped global setting; the shared fixtures; raw inserts into a soft-delete table set deleted_at/deleted_by. Validate by a clean import only. NEVER run the suite.',
].join('\n')
function jobBrief() {
if (!args) return ''
if (typeof args === 'string') return args
@@ -160,8 +168,8 @@ if (gaps.length) {
}
const tests = await agent(
`Operate in FIX mode. Write the integration tests for the new job kind (enqueue, status, download) following the required patterns and the directory-mirrors-path layout. Validate by a clean import only. NEVER run the suite.\n\nJob request: ${ask}\nKind: ${build && build.kind}\nFiles changed:\n${changed.join('\n')}`,
{ agentType: 'test-maintainer', label: 'tests', phase: 'Fix' }
`Operate in FIX mode. Write the integration tests for the new job kind (enqueue, status, download) following the required patterns and the directory-mirrors-path layout. The job kind is not complete until each of its routes has a test. Create any missing package directories the test paths need. Validate by a clean import only. NEVER run the suite.\n\n${TESTS}\n\nJob request: ${ask}\nKind: ${build && build.kind}\nFiles changed:\n${changed.join('\n')}\n\nReturn the test files written and the routes they cover.`,
{ agentType: 'test-maintainer', label: 'tests', phase: 'Test' }
)
return { ask, map, plan, build, audit: gaps, gapFix, tests }