blindxfish/devplacepy
1
0
Fork 0
forked from retoor/devplacepy
Code Pull Requests Activity

feat: enforce hard test-tier requirement across all DevPlace workflow agents and feature-builder docs

Browse Source 
Update the feature-builder agent prompt, test-maintainer agent, and all four workflow JS files (devii-tool, endpoint, feature, job-service) to codify the DevPlace test standard as a non-optional project requirement: one test file per endpoint, directory tree mirroring the URL/source path, split into three tiers (unit, api, e2e). Add explicit Test phases to devii-tool, endpoint, feature, and job-service workflows, and embed tier-specific test instructions (path mapping, fixture choice, coverage scope) directly in each workflow's meta description and TESTS constant.
This commit is contained in:
retoor
2026-06-15 12:10:14 +00:00
parent 3c7527988e
commit e1874f9b6a
71 changed files with 2198 additions and 145 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.claude/workflows/devii-tool.js
+12 -4
View File
@@ -1,12 +1,13 @@
// retoor <retoor@molodetz.nl>
export const meta = {
name: 'devii-tool',
description: 'Add a Devii agent capability: an Action in the catalog with auth flags matched to the route guard, dispatcher wiring, API docs, and a test, then verify role-gating and confirmation',
description: 'Add a Devii agent capability: an Action in the catalog with auth flags matched to the route guard, dispatcher wiring, API docs, then verify role-gating and confirmation and write the api-tier integration test for the action',
phases: [
{ title: 'Understand', detail: 'find the underlying route and a similar Action to mirror' },
{ title: 'Implement', detail: 'add the Action, wire the handler, document it' },
{ title: 'Verify', detail: 'role-gating, flag alignment, and confirm gating' },
{ title: 'Fix', detail: 'close gaps and write the action test' },
{ title: 'Fix', detail: 'close gaps from the review' },
{ title: 'Test', detail: 'write the api-tier integration test for the action (visibility, auth gating, confirm)' },
],
}
@@ -20,6 +21,13 @@ const RULES = [
'- Validate with "hawk ." and "python -c \\"from devplacepy.main import app\\"". NEVER run the test suite. Never perform any git write.',
].join('\n')
const TESTS = [
'DevPlace test standard (a hard project requirement - one test file per endpoint, the directory tree mirroring the URL path):',
'A Devii tool is reached over the same HTTP surface a user hits, so its test lives in tests/api/ (often tests/api/devii/), against the live uvicorn subprocess (app_server/seeded_db, requests/httpx vs BASE_URL).',
'Cover the role-gating that is the whole point of the tool: an unauthenticated/guest caller is refused, a member sees and can call a requires_auth tool but is refused a requires_admin one (and its schema is withheld), an admin can call it, and a destructive action is refused without confirm=true and proceeds with it.',
'Required patterns: scoped assertions; try/finally restore of any flipped global setting; the shared fixtures (alice, bob, app_server); test FUNCTIONS are test_-prefixed though files are not. Validate by a clean import only. NEVER run the suite.',
].join('\n')
function toolBrief() {
if (!args) return ''
if (typeof args === 'string') return args
@@ -125,8 +133,8 @@ if (gaps.length) {
}
const test = await agent(
`Operate in FIX mode. Write the integration test for this Devii tool following the required patterns (tests/api/devii layout). Validate by a clean import only. NEVER run the suite.\n\nTool request: ${ask}\nAction: ${build && build.actionName}\nFiles changed:\n${changed.join('\n')}`,
{ agentType: 'test-maintainer', label: 'test', phase: 'Fix' }
`Operate in FIX mode. Write the integration test for this Devii tool following the required patterns (tests/api/devii layout), asserting the role-gating and confirm behavior described below. The tool is not complete until its gating is tested. Create any missing package directories the test path needs. Validate by a clean import only. NEVER run the suite.\n\n${TESTS}\n\nTool request: ${ask}\nAction: ${build && build.actionName}\nFiles changed:\n${changed.join('\n')}\n\nReturn the test file written and the gating cases it covers.`,
{ agentType: 'test-maintainer', label: 'test', phase: 'Test' }
)
return { ask, map, build, audit: gaps, gapFix, test }