forked from retoor/devplacepy
Fix Devii open-trigger race and close two flaky e2e waits
DeviiTerminal bound [data-devii-open] click listeners only after the async /devii/session fetch resolved, silently dropping early clicks. Switch to a single delegated document listener bound in the constructor, matching the ModalManager/dp-lightbox pattern. The steal-confirm and comment-vote e2e tests asserted DOM state right after a click with no wait for the triggering POST to land, racing the server under CI load. Wrap those clicks in page.expect_response. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
+4
-1
@@ -114,7 +114,10 @@ def test_comment_voted_state_persists(alice):
|
||||
expect(
|
||||
page.locator(".comment-text:has-text('Comment whose vote should persist')")
|
||||
).to_be_visible()
|
||||
page.locator(".comment-vote-btn").first.click()
|
||||
with page.expect_response(
|
||||
lambda r: "/votes/" in r.url and r.request.method == "POST"
|
||||
):
|
||||
page.locator(".comment-vote-btn").first.click()
|
||||
expect(page.locator(".comment-vote-btn").first).to_have_class(
|
||||
re.compile(r"\bvoted\b")
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user