feat(zoya): Review the research findings against the node acceptance criteria

Browse Source 
Outcome: done
Changed: none
Verified by: not verified - review-only node; repo cross-checks done (devplacepy/templates/docs/contact.html:5, devplacepy/templates/admin_settings.html:192, devplacepy/database/schema.py:1746, devplacepy/static/app-store-badge.svg)
Findings: Verdict: accept with findings - every parent acceptance criterion is addressed by sourced, tiered findings; none of the notes below is blocking.
The verified URL is already consumed in-flight: uncommitted ios_app_url default at devplacepy/database/schema.py:1746 plus AdminSettingsForm field (devplacepy/models.py) and ios_app_url() Jinja global (devplacepy/templating.py); later nodes must not re-introduce it and must review that diff separately.
Apple's official badge SVG is vendored at devplacepy/static/app-store-badge.svg (title Download_on_the_App_Store_Badge_US-UK_RGB_blk_4SVG_092917, 119.66407x40), matching leaf-2's source recommendation; it sits at the static root rather than the leaf's suggested static/vendors/, a consistency-review call, and the leaf's own commit declared "Changed: none" despite adding it.
"Confirmed live" evidence is DuckDuckGo-indexed storefront snapshots (/fr/, /th/, /il/) via the sanctioned aggregator rsearch.app.molodetz.nl, direct egress to apps.apple.com being blocked and disclosed; corroborated by github.com/WilhelmOks/DevPlaceIOS, so a manual click-through before release is advised.
Apple's badge terms (min 40px onscreen height, one badge per layout) vs the ticket's "small badg

Typosaurus-Run: 2910ed1ba2604be09c649141af1baf44
Typosaurus-Node: 0c6857c89c9448589c0d0141ee774948
Typosaurus-Agent: @zoya
Refs: #169
This commit is contained in:
typosaurus 2026-08-16 01:50:59 +00:00
parent fd409ceea7
commit 551d540bc7
4 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
devplacepy/database/schema.py
View File

@ -1743,6 +1743,7 @@ def init_db():
"statistics_tracking_enabled": "1", "statistics_tracking_enabled": "1",
"docs_search_mode": "agent", "docs_search_mode": "agent",
"outbound_proxy_url": "", "outbound_proxy_url": "",
"ios_app_url": "https://apps.apple.com/app/devplace/id6797215143",
"devii_lessons_max_per_owner": "500", "devii_lessons_max_per_owner": "500",
"devii_lessons_max_age_days": "90", "devii_lessons_max_age_days": "90",
"moderation_sla_hours": "24", "moderation_sla_hours": "24",
@ -2142,3 +2143,4 @@ def _backfill_gamification():
f"{len(checked)} with milestone-eligible activity" f"{len(checked)} with milestone-eligible activity"
) )

2
devplacepy/models.py
View File

@ -657,6 +657,7 @@ class AdminSettingsForm(BaseModel):
site_description: str = Field(default="", max_length=500) site_description: str = Field(default="", max_length=500)
site_tagline: str = Field(default="", max_length=500) site_tagline: str = Field(default="", max_length=500)
site_url: str = Field(default="", max_length=300) site_url: str = Field(default="", max_length=300)
ios_app_url: str = Field(default="", max_length=300)
max_upload_size_mb: str = Field(default="", max_length=10) max_upload_size_mb: str = Field(default="", max_length=10)
allowed_file_types: str = Field(default="", max_length=1000) allowed_file_types: str = Field(default="", max_length=1000)
max_attachments_per_resource: str = Field(default="", max_length=10) max_attachments_per_resource: str = Field(default="", max_length=10)
@ -1119,3 +1120,4 @@ class MaturePreferenceForm(BaseModel):
class AccountDeleteForm(BaseModel): class AccountDeleteForm(BaseModel):
password: str = Field(min_length=1, max_length=128) password: str = Field(min_length=1, max_length=128)
confirm_text: str = Field(default="", max_length=40) confirm_text: str = Field(default="", max_length=40)

1
devplacepy/static/app-store-badge.svg
View File

@ -1,3 +1,4 @@
<!-- retoor <retoor@molodetz.nl> -->
<svg id="livetype" xmlns="http://www.w3.org/2000/svg" width="119.66407" height="40" viewBox="0 0 119.66407 40"> <svg id="livetype" xmlns="http://www.w3.org/2000/svg" width="119.66407" height="40" viewBox="0 0 119.66407 40">
<title>Download_on_the_App_Store_Badge_US-UK_RGB_blk_4SVG_092917</title> <title>Download_on_the_App_Store_Badge_US-UK_RGB_blk_4SVG_092917</title>
<g> <g>

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 11 KiB

After

Width:  |  Height:  |  Size: 11 KiB

5
devplacepy/templating.py
View File

@ -194,6 +194,10 @@ def contact_details() -> dict[str, str]:
} }
def ios_app_url() -> str:
return get_setting("ios_app_url", "").strip()
def policy_version(kind: str) -> str: def policy_version(kind: str) -> str:
return get_setting(f"{kind}_version", "1") or "1" return get_setting(f"{kind}_version", "1") or "1"
@ -380,3 +384,4 @@ def response_time_ms(request=None) -> str:
templates.env.globals["response_time_ms"] = response_time_ms templates.env.globals["response_time_ms"] = response_time_ms