forked from retoor/devplacepy
Add Happy 404, featured/related sidebars, and next-post nav to the post page
Happy 404: an HTML 404 (unmatched route, or an explicit not-found inside a
real route) now renders a random existing post instead of the error page,
using the exact same context builder as a real post view. Toggle is the
happy_404_enabled site setting (default on, /admin/settings); JSON/API
requests and a handful of excluded prefixes are never affected. The pool of
candidate slugs is cached in-process and resampled periodically so it stays
fast and eventually cycles the whole posts table; on any internal failure it
falls straight through to the real 404 page.
Applying this everywhere surfaced ~60 existing tests that asserted a literal
404 for a legitimate resource-not-found flow (deleted post, unknown
container, wrong project slug, etc.) - each now disables the setting for the
duration of that specific check and restores it after, so the underlying
not-found behavior stays covered independently of the new feature.
Post page also gained, all built on the same shared post_page_context() so
they render identically on both a real post and a happy-404 page:
- A left sidebar (three separate cards, matching /feed's sidebar-card
convention) for "Gists from {author}", "Projects from {author}" (private
projects filtered through the normal visibility check), and "Related
Discussions" - each cached per author and invalidated on create/edit/
delete so new content shows up immediately.
- A right column reusing /feed's exact Daily Topic widget class for up to
three "Featured" articles (the existing but previously-unused `featured`
news flag), cached as a pool with per-request random sampling.
- A "Next post -> " link beside "Back to Feed", pointing at the next older
post site-wide (blocked authors skipped). Wired through the same next_url
mechanism already used for listing pagination, so it emits a real
backend-rendered <link rel="next"> tag for SEO, not just a visible link.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BWJy6PrMMt5hwWxQwia2rd
This commit is contained in:
@@ -1,12 +1,13 @@
|
||||
# retoor <retoor@molodetz.nl>
|
||||
|
||||
import io
|
||||
import time
|
||||
import requests
|
||||
from datetime import datetime, timezone
|
||||
from PIL import Image
|
||||
from tests.conftest import BASE_URL
|
||||
from tests.conftest import BASE_URL, CACHE_VERSION_PROPAGATION_SECONDS
|
||||
from devplacepy.attachments import store_attachment
|
||||
from devplacepy.database import get_table
|
||||
from devplacepy.database import get_table, set_setting
|
||||
from devplacepy.utils import generate_uid, make_combined_slug
|
||||
|
||||
JSON = {"Accept": "application/json"}
|
||||
@@ -87,7 +88,13 @@ def test_admin_revoke_soft_deletes_and_recomputes(seeded_db):
|
||||
assert get_table("attachments").find_one(uid=att512).get("deleted_at")
|
||||
bob = get_table("users").find_one(username="bob_test")
|
||||
assert bob.get("award_count") == 0
|
||||
assert requests.get(f"{BASE_URL}/awards/{slug}/64").status_code == 404
|
||||
set_setting("happy_404_enabled", "0")
|
||||
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
||||
try:
|
||||
assert requests.get(f"{BASE_URL}/awards/{slug}/64").status_code == 404
|
||||
finally:
|
||||
set_setting("happy_404_enabled", "1")
|
||||
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
||||
|
||||
|
||||
def test_media_gallery_hides_revoked_attachment(seeded_db):
|
||||
|
||||
@@ -1,8 +1,10 @@
|
||||
# retoor <retoor@molodetz.nl>
|
||||
|
||||
import time
|
||||
|
||||
import requests
|
||||
from tests.conftest import BASE_URL
|
||||
from devplacepy.database import get_table, refresh_snapshot
|
||||
from tests.conftest import BASE_URL, CACHE_VERSION_PROPAGATION_SECONDS
|
||||
from devplacepy.database import get_table, refresh_snapshot, set_setting
|
||||
|
||||
JSON = {"Accept": "application/json"}
|
||||
|
||||
@@ -49,8 +51,14 @@ def test_bots_data_shape_for_admin(app_server, seeded_db):
|
||||
|
||||
def test_bots_frame_missing_is_404(app_server, seeded_db):
|
||||
admin = _admin()
|
||||
r = admin.get(f"{BASE_URL}/admin/bots/999/frame.jpg", allow_redirects=False)
|
||||
assert r.status_code == 404
|
||||
set_setting("happy_404_enabled", "0")
|
||||
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
||||
try:
|
||||
r = admin.get(f"{BASE_URL}/admin/bots/999/frame.jpg", allow_redirects=False)
|
||||
assert r.status_code == 404
|
||||
finally:
|
||||
set_setting("happy_404_enabled", "1")
|
||||
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
||||
|
||||
|
||||
def test_bots_frame_requires_admin(app_server, seeded_db):
|
||||
|
||||
@@ -1,11 +1,12 @@
|
||||
# retoor <retoor@molodetz.nl>
|
||||
|
||||
import io
|
||||
import time
|
||||
import uuid
|
||||
import requests
|
||||
from PIL import Image
|
||||
from tests.conftest import BASE_URL
|
||||
from devplacepy.database import get_table
|
||||
from tests.conftest import BASE_URL, CACHE_VERSION_PROPAGATION_SECONDS
|
||||
from devplacepy.database import get_table, set_setting
|
||||
JSON_media = {"Accept": "application/json"}
|
||||
def _png_bytes_media(color=(200, 30, 30)):
|
||||
buf = io.BytesIO()
|
||||
@@ -130,4 +131,10 @@ def test_admin_purge_hard_deletes(seeded_db):
|
||||
# row gone (not in trash, cannot restore) and file removed from disk
|
||||
trash = admin.get(f"{BASE_URL}/admin/media", headers=JSON_media).json()
|
||||
assert all(m["uid"] != uid for m in trash["media"])
|
||||
assert owner.get(f"{BASE_URL}{file_url}").status_code == 404
|
||||
set_setting("happy_404_enabled", "0")
|
||||
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
||||
try:
|
||||
assert owner.get(f"{BASE_URL}{file_url}").status_code == 404
|
||||
finally:
|
||||
set_setting("happy_404_enabled", "1")
|
||||
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
||||
|
||||
@@ -2,7 +2,8 @@
|
||||
|
||||
import time
|
||||
import requests
|
||||
from tests.conftest import BASE_URL
|
||||
from tests.conftest import BASE_URL, CACHE_VERSION_PROPAGATION_SECONDS
|
||||
from devplacepy.database import set_setting
|
||||
|
||||
JSON_trash = {"Accept": "application/json"}
|
||||
_counter_trash = [0]
|
||||
@@ -146,7 +147,13 @@ def test_restore_revoked_award_recomputes_stats(seeded_db):
|
||||
row = get_table("users").find_one(uid=bob["uid"])
|
||||
assert row.get("award_count") == 1
|
||||
assert row.get("last_award_uid") == uid
|
||||
assert requests.get(f"{BASE_URL}/awards/{slug}/256").status_code in (302, 404)
|
||||
set_setting("happy_404_enabled", "0")
|
||||
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
||||
try:
|
||||
assert requests.get(f"{BASE_URL}/awards/{slug}/256").status_code in (302, 404)
|
||||
finally:
|
||||
set_setting("happy_404_enabled", "1")
|
||||
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
|
||||
|
||||
|
||||
def _create_quiz_trash(session):
|
||||
|
||||
Reference in New Issue
Block a user