Render markdown in gist and project sidebar titles; add content visibility and GIF picker

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-05 17:59:21 +01:00
co-authored by Claude Sonnet 5.5
parent bc11475f29
commit 05d6633204
154 changed files with 6394 additions and 289 deletions
+163
View File
@@ -136,3 +136,166 @@ def test_model_form_submits_selected_model_from_dropdown(page, seeded_db):
httpd.shutdown()
requests.delete(f"{BASE_URL}/admin/gateway/models/{source}", headers=auth)
requests.delete(f"{BASE_URL}/admin/gateway/providers/{provider}", headers=auth)
def _fake_probe_upstream():
sock = socket.socket()
sock.bind(("127.0.0.1", 0))
port = sock.getsockname()[1]
sock.close()
class Handler(http.server.BaseHTTPRequestHandler):
def do_POST(self):
length = int(self.headers.get("Content-Length", 0))
self.rfile.read(length)
if self.path.endswith("/images/generations"):
body = json.dumps(
{"data": [{"url": "https://img.example/h.png"}]}
).encode()
else:
body = json.dumps(
{"choices": [{"message": {"content": "OK"}}]}
).encode()
self.send_response(200)
self.send_header("Content-Type", "application/json")
self.end_headers()
self.wfile.write(body)
def log_message(self, *args):
pass
httpd = socketserver.TCPServer(("127.0.0.1", port), Handler)
thread = threading.Thread(target=httpd.serve_forever, daemon=True)
thread.start()
return httpd, port
def test_model_grid_health_badges_and_test_buttons(page, seeded_db):
user = seeded_db["alice"]
_promote_to_admin(user["username"])
key = _admin_api_key(user["username"])
auth = {"X-API-KEY": key}
httpd, port = _fake_probe_upstream()
live_provider = f"e2ehealth{port}"
dead_provider = f"e2edead{port}"
live_source = f"e2elive{port}"
dead_source = f"e2edead{port}"
try:
requests.post(
f"{BASE_URL}/admin/gateway/providers",
json={
"name": live_provider,
"base_url": f"http://127.0.0.1:{port}/v1/chat/completions",
},
headers=auth,
)
requests.post(
f"{BASE_URL}/admin/gateway/providers",
json={
"name": dead_provider,
"base_url": "http://127.0.0.1:9/v1/chat/completions",
},
headers=auth,
)
requests.post(
f"{BASE_URL}/admin/gateway/models",
json={
"source_model": live_source,
"provider": live_provider,
"target_model": "vendor/live",
"kind": "chat",
},
headers=auth,
)
requests.post(
f"{BASE_URL}/admin/gateway/models",
json={
"source_model": dead_source,
"provider": dead_provider,
"target_model": "vendor/dead",
"kind": "chat",
},
headers=auth,
)
assert (
requests.post(
f"{BASE_URL}/admin/gateway/models/{live_source}/test", headers=auth
).status_code
== 200
)
assert (
requests.post(
f"{BASE_URL}/admin/gateway/models/{dead_source}/test", headers=auth
).status_code
== 200
)
login_user(page, user)
page.goto(f"{BASE_URL}/admin/gateway?tab=models", wait_until="domcontentloaded")
grid = page.locator("table.admin-table")
grid.wait_for(state="visible")
assert page.get_by_role("button", name="Test all", exact=True).is_visible()
live_row = grid.locator("tr", has_text=live_source)
dead_row = grid.locator("tr", has_text=dead_source)
assert live_row.get_by_role("button", name="Test", exact=True).is_visible()
assert live_row.locator(".gw-badge-ok").is_visible()
assert dead_row.locator(".gw-badge-bad").is_visible()
assert "connection_error" in (dead_row.inner_text() or "")
assert "gw-row-bad" in (dead_row.get_attribute("class") or "")
finally:
httpd.shutdown()
requests.delete(f"{BASE_URL}/admin/gateway/models/{live_source}", headers=auth)
requests.delete(f"{BASE_URL}/admin/gateway/models/{dead_source}", headers=auth)
requests.delete(
f"{BASE_URL}/admin/gateway/providers/{live_provider}", headers=auth
)
requests.delete(
f"{BASE_URL}/admin/gateway/providers/{dead_provider}", headers=auth
)
def test_image_test_opens_result_modal(page, seeded_db):
user = seeded_db["alice"]
_promote_to_admin(user["username"])
key = _admin_api_key(user["username"])
auth = {"X-API-KEY": key}
httpd, port = _fake_probe_upstream()
provider = f"e2eimg{port}"
source = f"e2eimgsrc{port}"
try:
requests.post(
f"{BASE_URL}/admin/gateway/providers",
json={
"name": provider,
"base_url": f"http://127.0.0.1:{port}/v1/chat/completions",
},
headers=auth,
)
requests.post(
f"{BASE_URL}/admin/gateway/models",
json={
"source_model": source,
"provider": provider,
"target_model": "vendor/img",
"kind": "image",
},
headers=auth,
)
login_user(page, user)
page.goto(f"{BASE_URL}/admin/gateway?tab=models", wait_until="domcontentloaded")
row = page.locator("table.admin-table tr", has_text=source)
row.wait_for(state="visible")
row.get_by_role("button", name="Test", exact=True).click()
modal = page.locator("#gw-test-image-modal.visible")
modal.wait_for(state="visible", timeout=30000)
assert modal.locator(".gw-test-image").get_attribute("src") == (
"https://img.example/h.png"
)
assert source in (modal.inner_text() or "")
finally:
httpd.shutdown()
requests.delete(f"{BASE_URL}/admin/gateway/models/{source}", headers=auth)
requests.delete(f"{BASE_URL}/admin/gateway/providers/{provider}", headers=auth)
+17
View File
@@ -160,3 +160,20 @@ def test_admin_news_featured_toggle(alice):
page.locator(toggle_sel).first.get_attribute("class") or ""
)
assert is_active != was_active
def test_admin_news_visibility_select_offers_every_status_and_saves(alice):
page, _ = alice
seed_admin_news()
page.goto(f"{BASE_URL}/admin/news", wait_until="domcontentloaded")
select = page.locator("form[action*='/visibility'] select").nth(1)
assert select.locator("option").all_text_contents() == ["Published", "Hidden", "Offline"]
with page.expect_navigation(wait_until="domcontentloaded"):
select.select_option("hidden")
refresh_snapshot()
statuses = sorted(r["status"] for r in get_table("news").find(deleted_at=None))
assert "hidden" in statuses
page.goto(f"{BASE_URL}/admin/news", wait_until="domcontentloaded")
selects = page.locator("form[action*='/visibility'] select")
values = [selects.nth(i).input_value() for i in range(selects.count())]
assert "hidden" in values
+262
View File
@@ -0,0 +1,262 @@
# retoor <retoor@molodetz.nl>
import http.server
import json
import threading
import time
from contextlib import contextmanager
from devplacepy.database import get_setting, set_setting
from tests.conftest import BASE_URL, CACHE_VERSION_PROPAGATION_SECONDS
from tests.e2e.components.title import _create_post
GIF_BYTES = (
b"GIF89a\x01\x00\x01\x00\x80\x00\x00\x00\x00\x00\xff\xff\xff"
b"\x21\xf9\x04\x01\x00\x00\x00\x00\x2c\x00\x00\x00\x00\x01\x00"
b"\x01\x00\x00\x02\x02\x44\x01\x00\x3b"
)
SETTING_KEYS = ("giphy_api_key", "giphy_base_url", "giphy_rating")
TITLES = {"gif1": "happy dance", "gif2": "sad cat", "gif3": "dance party"}
PICKER = "dp-gif-picker .gif-toggle-btn"
PANEL = "dp-gif-picker .gif-picker-wrapper"
ITEM = "dp-gif-picker .gif-picker-item"
def _gif_item(port, gif_id):
media = f"http://127.0.0.1:{port}/media/{gif_id}.gif"
return {
"id": gif_id,
"title": TITLES[gif_id],
"url": f"https://giphy.test/gifs/{gif_id}",
"images": {
"fixed_width": {"url": media, "width": "200", "height": "150", "size": "10"},
"original": {"url": media, "width": "480", "height": "360", "size": "10"},
},
}
def _fake_giphy():
holder = {}
class Handler(http.server.BaseHTTPRequestHandler):
def _send(self, status, body, content_type):
self.send_response(status)
self.send_header("Content-Type", content_type)
self.send_header("Content-Length", str(len(body)))
self.end_headers()
self.wfile.write(body)
def do_GET(self):
port = holder["server"].server_port
path, _, query = self.path.partition("?")
params = dict(pair.split("=", 1) for pair in query.split("&") if "=" in pair)
if path.startswith("/media/"):
return self._send(200, GIF_BYTES, "image/gif")
ids = list(TITLES)
if path.endswith("/search"):
needle = params.get("q", "").replace("+", " ").lower()
ids = [i for i in ids if needle in TITLES[i]]
if path.endswith("/search") or path.endswith("/trending"):
body = {"data": [_gif_item(port, i) for i in ids]}
else:
body = {"data": _gif_item(port, path.rsplit("/", 1)[-1])}
self._send(200, json.dumps(body).encode(), "application/json")
def log_message(self, *args):
return
server = http.server.ThreadingHTTPServer(("127.0.0.1", 0), Handler)
holder["server"] = server
threading.Thread(target=server.serve_forever, daemon=True).start()
return server
@contextmanager
def _giphy(key="e2e-giphy-key"):
server = _fake_giphy()
originals = {name: get_setting(name, "") for name in SETTING_KEYS}
try:
set_setting("giphy_api_key", key)
set_setting("giphy_base_url", f"http://127.0.0.1:{server.server_port}/v1/gifs")
set_setting("giphy_rating", "pg")
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
yield server
finally:
for name, value in originals.items():
set_setting(name, value)
server.shutdown()
server.server_close()
time.sleep(CACHE_VERSION_PROPAGATION_SECONDS)
def _stub_attach(page):
uploaded = page.request.post(
f"{BASE_URL}/uploads/upload",
multipart={"file": {"name": "party.gif", "mimeType": "image/gif", "buffer": GIF_BYTES}},
headers={"Accept": "application/json"},
)
assert uploaded.ok, uploaded.text()
record = uploaded.json()
calls = []
def fulfil(route):
calls.append(route.request.post_data_json)
route.fulfill(status=201, content_type="application/json", body=json.dumps(record))
page.route("**/giphy/attach", fulfil)
return record, calls
def _open_post_with_comment_form(page):
_create_post(page, "A post that will receive a GIF comment.", "Giphy host post")
page.locator(".comment-form textarea").first.wait_for(state="visible")
def test_picker_is_hidden_when_giphy_is_not_configured(alice):
page, _ = alice
with _giphy(key=""):
_open_post_with_comment_form(page)
page.locator("dp-gif-picker").first.wait_for(state="attached")
page.wait_for_function("() => document.querySelector('dp-gif-picker').hidden === true")
assert not page.locator(PICKER).first.is_visible()
def test_trending_search_and_dismissal(alice):
page, _ = alice
with _giphy():
_open_post_with_comment_form(page)
page.locator(PICKER).first.click()
page.locator(PANEL).first.wait_for(state="visible")
page.wait_for_function("() => document.querySelectorAll('.gif-picker-item').length === 3")
assert "Powered by GIPHY" in page.locator(".gif-picker-credit").first.text_content()
page.locator(".gif-picker-search").first.fill("dance")
page.wait_for_function("() => document.querySelectorAll('.gif-picker-item').length === 2")
page.keyboard.press("Escape")
page.locator(PANEL).first.wait_for(state="hidden")
page.locator(PICKER).first.click()
page.locator(PANEL).first.wait_for(state="visible")
page.locator(".page-title, h1").first.click()
page.locator(PANEL).first.wait_for(state="hidden")
def test_empty_search_says_so(alice):
page, _ = alice
with _giphy():
_open_post_with_comment_form(page)
page.locator(PICKER).first.click()
page.locator(".gif-picker-search").first.fill("zzzz-no-such-gif")
status = page.locator(".gif-picker-status").first
status.wait_for(state="visible")
page.wait_for_function("() => document.querySelector('.gif-picker-status').textContent === 'No GIFs found'")
assert page.locator(ITEM).count() == 0
def test_picked_gif_becomes_an_attachment_not_markup(alice):
page, _ = alice
with _giphy():
_open_post_with_comment_form(page)
record, calls = _stub_attach(page)
form = page.locator(".comment-form").first
form.locator("textarea").fill("nice one")
page.locator(PICKER).first.click()
page.locator(ITEM).first.wait_for(state="visible")
page.locator(ITEM).first.click()
page.locator(PANEL).first.wait_for(state="hidden")
assert calls == [{"gif_id": "gif1", "title": "happy dance"}]
assert form.locator("input[name=attachment_uids]").input_value() == record["uid"]
assert form.locator("textarea").input_value() == "nice one"
form.locator(".comment-form-submit").click()
page.wait_for_load_state("domcontentloaded")
page.locator(".comment img[src$='.gif']").first.wait_for(state="visible")
assert page.locator(".comment img[src$='.gif']").count() == 1
def test_a_second_pick_adds_a_second_attachment(alice):
page, _ = alice
with _giphy():
_open_post_with_comment_form(page)
record, _ = _stub_attach(page)
form = page.locator(".comment-form").first
for _round in range(2):
page.locator(PICKER).first.click()
page.locator(ITEM).first.wait_for(state="visible")
page.locator(ITEM).first.click()
page.locator(PANEL).first.wait_for(state="hidden")
assert form.locator("input[name=attachment_uids]").input_value() == record["uid"]
def test_composer_has_the_picker_beside_the_attachment_button(alice):
page, _ = alice
with _giphy():
page.goto(f"{BASE_URL}/feed", wait_until="domcontentloaded")
page.locator(".feed-fab").first.wait_for(state="visible", timeout=10000)
page.locator(".feed-fab").first.click()
actions = page.locator("#create-post-modal .composer-attachments-actions")
actions.wait_for(state="visible")
actions.locator(".gif-toggle-btn").wait_for(state="visible")
assert actions.locator("dp-upload").count() == 1
record, _ = _stub_attach(page)
actions.locator(".gif-toggle-btn").click()
page.locator(ITEM).first.wait_for(state="visible")
page.locator(ITEM).first.click()
page.wait_for_function(
"(uid) => document.querySelector('#create-post-modal input[name=attachment_uids]').value === uid",
arg=record["uid"],
)
def test_message_input_has_the_picker(alice, bob):
page, _ = alice
_, bob_user = bob
with _giphy():
page.goto(f"{BASE_URL}/messages?search={bob_user['username']}", wait_until="domcontentloaded")
area = page.locator(".messages-input-area")
area.wait_for(state="visible")
area.locator(".gif-toggle-btn").wait_for(state="visible")
record, _ = _stub_attach(page)
area.locator(".gif-toggle-btn").click()
page.locator(ITEM).first.wait_for(state="visible")
page.locator(ITEM).first.click()
page.wait_for_function(
"(uid) => document.querySelector('.messages-input-area input[name=attachment_uids]').value === uid",
arg=record["uid"],
)
def test_panel_fits_a_small_phone(alice):
page, _ = alice
page.set_viewport_size({"width": 360, "height": 640})
with _giphy():
_open_post_with_comment_form(page)
page.locator(PICKER).first.click()
panel = page.locator(PANEL).first
panel.wait_for(state="visible")
page.locator(ITEM).first.wait_for(state="visible")
box = panel.bounding_box()
assert box["x"] >= 0
assert box["x"] + box["width"] <= 360
assert box["y"] >= 0
assert box["y"] + box["height"] <= 640
def test_message_panel_fits_a_small_phone(alice, bob):
page, _ = alice
_, bob_user = bob
page.set_viewport_size({"width": 360, "height": 640})
with _giphy():
page.goto(f"{BASE_URL}/messages?search={bob_user['username']}", wait_until="domcontentloaded")
area = page.locator(".messages-input-area")
area.wait_for(state="visible")
area.locator(".gif-toggle-btn").click()
panel = page.locator(PANEL).first
panel.wait_for(state="visible")
page.locator(ITEM).first.wait_for(state="visible")
box = panel.bounding_box()
assert box["x"] >= 0
assert box["x"] + box["width"] <= 360
assert box["y"] >= 0
+78
View File
@@ -558,3 +558,81 @@ def test_gists_long_code_line_does_not_widen_layout(page, app_server):
card.wait_for(state="visible")
assert card.locator("pre").count() == 1
assert_no_horizontal_overflow(page, ".gists-layout")
def _create_gist_with_visibility(page, title, visibility):
page.goto(f"{BASE_URL}/gists", wait_until="domcontentloaded")
page.locator("#create-gist-btn").wait_for(state="visible", timeout=10000)
page.locator("#create-gist-btn").click()
page.fill("#gist-title", title)
page.fill("#gist-description", "visibility e2e")
_set_cm_value(page, "print('visibility')")
if visibility:
page.select_option("#gist-visibility", visibility)
page.locator("button.btn-primary:has-text('Create Gist')").click()
page.wait_for_url(f"{BASE_URL}/gists/*", wait_until="domcontentloaded")
return page.url
def _gists_list_has(page, title):
page.goto(f"{BASE_URL}/gists?search={title}", wait_until="domcontentloaded")
return page.locator(f"text={title}").count() > 0
def test_gist_create_form_offers_the_three_visibility_choices(alice):
page, _ = alice
page.goto(f"{BASE_URL}/gists", wait_until="domcontentloaded")
page.locator("#create-gist-btn").click()
options = page.locator("#gist-visibility option")
assert options.all_text_contents() == ["Published", "Hidden", "Offline"]
expect(page.locator("#gist-visibility")).to_have_value("published")
def test_gist_created_hidden_leaves_the_listing(alice):
page, _ = alice
title = f"VisGistHidden{int(time.time() * 1000)}"
_create_gist_with_visibility(page, title, "hidden")
assert not _gists_list_has(page, title)
def _edit_gist_visibility(page, url, value):
page.goto(url, wait_until="domcontentloaded")
page.locator("[data-modal='edit-gist-modal']").click()
page.select_option("#edit-gist-visibility", value)
page.locator("#edit-gist-modal button.btn-primary").click()
page.wait_for_url(url, wait_until="domcontentloaded")
def test_gist_edit_form_toggles_visibility_and_others_lose_access(alice, bob):
page, _ = alice
other, _ = bob
title = f"VisGistToggle{int(time.time() * 1000)}"
url = _create_gist_with_visibility(page, title, None)
assert _gists_list_has(page, title)
_edit_gist_visibility(page, url, "offline")
assert not _gists_list_has(page, title)
other.goto(url, wait_until="domcontentloaded")
assert other.locator(f"text={title}").count() == 0
_edit_gist_visibility(page, url, "published")
assert _gists_list_has(page, title)
other.goto(url, wait_until="domcontentloaded")
expect(other.locator(f"text={title}").first).to_be_visible()
def test_gist_edit_modal_changes_visibility(alice):
page, _ = alice
title = f"VisGistEdit{int(time.time() * 1000)}"
url = _create_gist_with_visibility(page, title, None)
page.locator("[data-modal='edit-gist-modal']").click()
expect(page.locator("#edit-gist-visibility")).to_have_value("published")
page.select_option("#edit-gist-visibility", "hidden")
page.locator("#edit-gist-modal button.btn-primary").click()
page.wait_for_url(url, wait_until="domcontentloaded")
assert not _gists_list_has(page, title)
def test_gist_visibility_field_fits_a_phone(mobile_page):
page, _ = mobile_page
title = f"VisGistPhone{int(time.time() * 1000)}"
_create_gist_with_visibility(page, title, "hidden")
page.locator("[data-modal='edit-gist-modal']").click()
expect(page.locator("#edit-gist-visibility")).to_be_visible()
assert_no_horizontal_overflow(page, ".gist-detail-page")
+27
View File
@@ -183,6 +183,33 @@ def test_send_message_appears_in_thread(alice):
page.locator(f".message-bubble:has-text('{msg}')").first.wait_for(state="visible")
def test_admin_deletes_own_message_in_chat(alice):
page, _ = alice
bob = get_table("users").find_one(username="bob_test")
page.goto(
f"{BASE_URL}/messages?with_uid={bob['uid']}", wait_until="domcontentloaded"
)
msg = f"Delete me {int(time.time() * 1000)}"
page.fill("textarea[name='content']", msg)
page.locator(".messages-send-btn").click()
bubble = page.locator(f".message-bubble.mine:has-text('{msg}')").first
bubble.wait_for(state="visible")
bubble.locator(".message-delete-btn").wait_for(state="attached")
bubble.locator(".message-delete-btn").click()
page.locator(".dialog-overlay.visible .dialog-confirm").click()
expect(page.locator(f".message-bubble:has-text('{msg}')")).to_have_count(0)
def test_member_sees_no_delete_control_in_chat(bob):
page, _ = bob
alice = get_table("users").find_one(username="alice_test")
page.goto(
f"{BASE_URL}/messages?with_uid={alice['uid']}", wait_until="domcontentloaded"
)
page.locator(".messages-thread").wait_for(state="visible")
expect(page.locator(".message-delete-btn")).to_have_count(0)
def test_paste_image_attaches_in_chat(alice):
page, _ = alice
bob = get_table("users").find_one(username="bob_test")
+105
View File
@@ -0,0 +1,105 @@
# retoor <retoor@molodetz.nl>
import time
from playwright.sync_api import expect
from tests.conftest import BASE_URL, assert_no_horizontal_overflow
def _unique():
return f"vispost{int(time.time() * 1000)}"
def _compose(page, token, visibility=None):
page.goto(f"{BASE_URL}/feed", wait_until="domcontentloaded")
page.locator(".feed-fab").first.wait_for(state="visible", timeout=10000)
page.locator(".feed-fab").first.click()
page.fill("#post-content", f"visibility e2e body {token}")
if visibility:
page.select_option("#composer-visibility", visibility)
page.locator("#create-post-modal button.btn-primary:has-text('Post')").click()
page.wait_for_url(f"{BASE_URL}/posts/*", wait_until="domcontentloaded")
return page.url
def _edit_visibility(page, url, value):
page.goto(url, wait_until="domcontentloaded")
page.locator("[data-modal='edit-post-modal']").click()
page.select_option("#edit-post-visibility", value)
page.locator("#edit-post-form button.btn-primary").click()
page.wait_for_url(url, wait_until="domcontentloaded")
def _feed_has(page, token):
page.goto(f"{BASE_URL}/feed?search={token}", wait_until="domcontentloaded")
return page.locator(f"text={token}").count() > 0
def test_new_post_defaults_to_published(alice):
page, _ = alice
token = _unique()
url = _compose(page, token)
page.locator("[data-modal='edit-post-modal']").click()
expect(page.locator("#edit-post-visibility")).to_have_value("published")
assert _feed_has(page, token)
page.goto(url, wait_until="domcontentloaded")
def test_composer_offers_the_three_user_choices(alice):
page, _ = alice
page.goto(f"{BASE_URL}/feed", wait_until="domcontentloaded")
page.locator(".feed-fab").first.click()
options = page.locator("#composer-visibility option")
assert options.all_text_contents() == ["Published", "Hidden", "Offline"]
expect(page.locator("#composer-visibility")).to_have_value("published")
def test_create_hidden_post_leaves_the_feed(alice):
page, _ = alice
token = _unique()
url = _compose(page, token, "hidden")
page.locator("[data-modal='edit-post-modal']").click()
expect(page.locator("#edit-post-visibility")).to_have_value("hidden")
assert not _feed_has(page, token)
page.goto(url, wait_until="domcontentloaded")
expect(page.locator(f"text={token}").first).to_be_visible()
def test_edit_form_toggles_visibility_and_the_feed_follows(alice):
page, _ = alice
token = _unique()
url = _compose(page, token)
assert _feed_has(page, token)
_edit_visibility(page, url, "offline")
assert not _feed_has(page, token)
_edit_visibility(page, url, "published")
assert _feed_has(page, token)
def test_offline_post_is_not_shown_to_other_members(alice, bob):
page, _ = alice
other, _ = bob
token = _unique()
url = _compose(page, token)
_edit_visibility(page, url, "offline")
other.goto(url, wait_until="domcontentloaded")
assert other.locator(f"text={token}").count() == 0
_edit_visibility(page, url, "hidden")
other.goto(url, wait_until="domcontentloaded")
expect(other.locator(f"text={token}").first).to_be_visible()
assert not _feed_has(other, token)
def test_edit_form_lists_the_three_choices(alice):
page, _ = alice
_compose(page, _unique())
page.locator("[data-modal='edit-post-modal']").click()
options = page.locator("#edit-post-visibility option")
assert options.all_text_contents() == ["Published", "Hidden", "Offline"]
def test_visibility_field_fits_a_phone(mobile_page):
page, _ = mobile_page
_compose(page, _unique(), "hidden")
page.locator("[data-modal='edit-post-modal']").click()
expect(page.locator("#edit-post-visibility")).to_be_visible()
assert_no_horizontal_overflow(page, ".post-page")
+41 -12
View File
@@ -15,10 +15,39 @@ def _confirm(page):
page.locator(".dialog-overlay.visible .dialog-confirm").click()
TRIGGER = "[data-action-menu-trigger]"
def _open_menu(page):
# aria-expanded can lag behind the popover (a dialog closing, a light
# dismiss), so the open state that counts is whether the panel shows.
page.wait_for_function(
"() => document.querySelector('[data-action-menu-panel]') !== null"
" || document.querySelector('[data-action-menu-trigger]') === null"
)
panel = page.locator("[data-action-menu-panel]")
if panel.count() and panel.evaluate("(el) => el.matches(':popover-open')"):
return
page.click(TRIGGER)
page.wait_for_function(
"() => document.querySelector('[data-action-menu-panel]').matches(':popover-open')"
)
def _has(page, selector):
_open_menu(page)
return page.is_visible(selector)
def _pick(page, selector):
_open_menu(page)
page.click(selector)
def _reset_block(page):
page.goto(f"{BASE_URL}/profile/bob_test", wait_until="domcontentloaded")
if page.is_visible(UNBLOCK):
page.click(UNBLOCK)
if _has(page, UNBLOCK):
_pick(page, UNBLOCK)
_confirm(page)
page.wait_for_url("**/profile/bob_test", wait_until="domcontentloaded")
@@ -64,30 +93,30 @@ def _seed_post(owner_uid, marker):
def test_block_and_unblock_buttons_toggle(alice):
page, _ = alice
_reset_block(page)
assert page.is_visible(BLOCK)
assert _has(page, BLOCK)
page.click(BLOCK)
_pick(page, BLOCK)
_confirm(page)
page.wait_for_url("**/profile/bob_test", wait_until="domcontentloaded")
assert page.is_visible(UNBLOCK)
assert _has(page, UNBLOCK)
page.click(UNBLOCK)
_pick(page, UNBLOCK)
_confirm(page)
page.wait_for_url("**/profile/bob_test", wait_until="domcontentloaded")
assert page.is_visible(BLOCK)
assert _has(page, BLOCK)
def test_block_button_opens_confirmation_dialog(alice):
page, _ = alice
_reset_block(page)
page.click(BLOCK)
_pick(page, BLOCK)
expect(page.locator(".dialog-overlay.visible")).to_be_visible()
expect(page.locator(".dialog-overlay.visible .dialog-message")).to_contain_text(
"Block"
)
page.locator(".dialog-overlay.visible .dialog-cancel").click()
expect(page.locator(".dialog-overlay")).not_to_be_visible()
assert page.is_visible(BLOCK)
assert _has(page, BLOCK)
def test_blocked_authors_post_hidden_from_feed(alice):
@@ -151,14 +180,14 @@ def test_blocked_users_profile_still_shows_their_content(alice):
_seed_post(bob_uid, marker)
_reset_block(page)
page.click(BLOCK)
_pick(page, BLOCK)
_confirm(page)
page.wait_for_url("**/profile/bob_test", wait_until="domcontentloaded")
page.goto(f"{BASE_URL}/profile/bob_test", wait_until="domcontentloaded")
assert page.is_visible(UNBLOCK)
assert _has(page, UNBLOCK)
assert marker in page.content()
page.click(UNBLOCK)
_pick(page, UNBLOCK)
_confirm(page)
page.wait_for_url("**/profile/bob_test", wait_until="domcontentloaded")
+38 -9
View File
@@ -11,10 +11,39 @@ def _confirm(page):
page.locator(".dialog-overlay.visible .dialog-confirm").click()
TRIGGER = "[data-action-menu-trigger]"
def _open_menu(page):
# aria-expanded can lag behind the popover (a dialog closing, a light
# dismiss), so the open state that counts is whether the panel shows.
page.wait_for_function(
"() => document.querySelector('[data-action-menu-panel]') !== null"
" || document.querySelector('[data-action-menu-trigger]') === null"
)
panel = page.locator("[data-action-menu-panel]")
if panel.count() and panel.evaluate("(el) => el.matches(':popover-open')"):
return
page.click(TRIGGER)
page.wait_for_function(
"() => document.querySelector('[data-action-menu-panel]').matches(':popover-open')"
)
def _has(page, selector):
_open_menu(page)
return page.is_visible(selector)
def _pick(page, selector):
_open_menu(page)
page.click(selector)
def _reset_mute(page):
page.goto(f"{BASE_URL}/profile/bob_test", wait_until="domcontentloaded")
if page.is_visible(UNMUTE):
page.click(UNMUTE)
if _has(page, UNMUTE):
_pick(page, UNMUTE)
_confirm(page)
page.wait_for_url("**/profile/bob_test", wait_until="domcontentloaded")
@@ -22,27 +51,27 @@ def _reset_mute(page):
def test_mute_and_unmute_buttons_toggle(alice):
page, _ = alice
_reset_mute(page)
assert page.is_visible(MUTE)
assert _has(page, MUTE)
page.click(MUTE)
_pick(page, MUTE)
_confirm(page)
page.wait_for_url("**/profile/bob_test", wait_until="domcontentloaded")
assert page.is_visible(UNMUTE)
assert _has(page, UNMUTE)
page.click(UNMUTE)
_pick(page, UNMUTE)
_confirm(page)
page.wait_for_url("**/profile/bob_test", wait_until="domcontentloaded")
assert page.is_visible(MUTE)
assert _has(page, MUTE)
def test_mute_button_opens_confirmation_dialog(alice):
page, _ = alice
_reset_mute(page)
page.click(MUTE)
_pick(page, MUTE)
expect(page.locator(".dialog-overlay.visible")).to_be_visible()
expect(page.locator(".dialog-overlay.visible .dialog-message")).to_contain_text(
"Mute"
)
page.locator(".dialog-overlay.visible .dialog-cancel").click()
expect(page.locator(".dialog-overlay")).not_to_be_visible()
assert page.is_visible(MUTE)
assert _has(page, MUTE)
+17 -25
View File
@@ -7,6 +7,7 @@ from playwright.sync_api import expect
from tests.conftest import BASE_URL, CACHE_VERSION_PROPAGATION_SECONDS, assert_share_copies
from devplacepy.database import get_table, set_setting
from devplacepy.utils import make_combined_slug
from tests.e2e.ui.components import _menu_item, _open_menu, _pick
def _goto_expect_404(page, url):
@@ -317,8 +318,7 @@ def _open_project_with_delete(page, title):
slug = proj_url.rstrip("/").split("/")[-1]
return proj_url, slug
def _click_delete(page):
page.locator(".project-actions-more").click()
page.locator(".context-menu-item:has-text('Delete')").click()
_pick(page, "Delete")
import asyncio
import io
import json
@@ -503,8 +503,7 @@ def test_delete_own_project(alice):
page, _ = alice
_create_project_projects(page, "Deletable Project XYZ")
proj_url = page.url
page.locator(".project-actions-more").click()
page.locator(".context-menu-item:has-text('Delete')").click()
_pick(page, "Delete")
page.locator(".dialog-overlay.visible .dialog-confirm").click()
page.wait_for_url(f"{BASE_URL}/projects", wait_until="domcontentloaded")
_goto_expect_404(page, proj_url)
@@ -513,15 +512,14 @@ def test_delete_own_project(alice):
def test_project_edit_button(alice):
page, _ = alice
_create_project_projects(page, "Editable Project ABC")
page.locator(".project-actions-more").click()
expect(page.locator(".context-menu-item:has-text('Edit')")).to_be_visible()
_open_menu(page)
expect(_menu_item(page, "Edit")).to_be_visible()
def test_project_edit_modal_prefills(alice):
page, _ = alice
_create_project_projects(page, "Edit Modal Project")
page.locator(".project-actions-more").click()
page.locator(".context-menu-item:has-text('Edit')").click()
_pick(page, "Edit")
assert page.is_visible("h3:has-text('Edit Project')")
expect(page.locator("#edit-project-title")).to_have_value("Edit Modal Project")
expect(page.locator("#platforms-tags .platform-tag:has-text('PC')")).to_be_visible()
@@ -531,8 +529,7 @@ def test_project_edit_submit(alice):
page, _ = alice
_create_project_projects(page, "Original Project Title")
proj_url = page.url
page.locator(".project-actions-more").click()
page.locator(".context-menu-item:has-text('Edit')").click()
_pick(page, "Edit")
page.fill("#edit-project-title", "Edited Project Title")
page.fill("#edit-project-description", "Edited project description body")
page.click("button:has-text('Save Changes')")
@@ -545,8 +542,7 @@ def test_project_edit_submit(alice):
def test_project_edit_status_change(alice):
page, _ = alice
_create_project_projects(page, "Status Change Project")
page.locator(".project-actions-more").click()
page.locator(".context-menu-item:has-text('Edit')").click()
_pick(page, "Edit")
page.check("#edit-project-modal input[value='Released']")
page.click("button:has-text('Save Changes')")
expect(page.locator(".project-status:has-text('Released')")).to_be_visible()
@@ -558,11 +554,9 @@ def test_project_edit_hidden_for_non_owner(alice, bob):
proj_url = page.url
bob_page, _ = bob
bob_page.goto(proj_url, wait_until="domcontentloaded")
bob_page.locator(".project-actions-more").click()
expect(
bob_page.locator(".context-menu-item:has-text('Download zip')")
).to_be_visible()
expect(bob_page.locator(".context-menu-item:has-text('Edit')")).to_have_count(0)
_open_menu(bob_page)
expect(_menu_item(bob_page, "Download zip")).to_be_visible()
expect(_menu_item(bob_page, "Edit")).to_have_count(0)
def test_project_detail_share_button(alice):
@@ -836,8 +830,7 @@ def test_project_make_private(alice):
page, _ = alice
_create_project_projects(page, "PrivateToggleProject")
slug = page.url.rstrip("/").split("/")[-1]
page.locator(".project-actions-more").click()
page.locator(".context-menu-item:has-text('Make private')").click()
_pick(page, "Make private")
page.locator(".dialog-overlay.visible .dialog-confirm").click()
page.wait_for_url(f"**/projects/{slug}", wait_until="domcontentloaded")
expect(page.locator(".badge-type:has-text('Private')")).to_be_visible()
@@ -847,8 +840,7 @@ def test_project_make_readonly(alice):
page, _ = alice
_create_project_projects(page, "ReadonlyToggleProject")
slug = page.url.rstrip("/").split("/")[-1]
page.locator(".project-actions-more").click()
page.locator(".context-menu-item:has-text('Make read-only')").click()
_pick(page, "Make read-only")
page.locator(".dialog-overlay.visible .dialog-confirm").click()
page.wait_for_url(f"**/projects/{slug}", wait_until="domcontentloaded")
expect(page.locator(".badge-type:has-text('Read-only')")).to_be_visible()
@@ -871,8 +863,8 @@ def test_detail_download_button_downloads(app_server, page):
_write_zip_download(key, slug, "README.md", "# hi")
_login_zip_download(page, name)
page.goto(f"{BASE_URL}/projects/{slug}", wait_until="domcontentloaded")
page.locator(".project-actions-more").click()
btn = page.locator(".context-menu-item:has-text('Download zip')")
_open_menu(page)
btn = _menu_item(page, "Download zip")
btn.wait_for(state="visible")
with page.expect_download(timeout=30000) as dl_info:
btn.click()
@@ -1014,5 +1006,5 @@ def test_containers_menu_hidden_for_non_owner_admin_on_member_private_project(pa
assert get_primary_admin_uid() != admin_uid
login_user(page, {"email": f"{admin_name}@t.dev", "password": "secret123"})
page.goto(f"{BASE_URL}/projects/{slug}", wait_until="domcontentloaded")
page.locator(".project-actions-more").click()
expect(page.locator(".context-menu-item:has-text('Containers')")).to_have_count(0)
_open_menu(page)
expect(_menu_item(page, "Containers")).to_have_count(0)
+87
View File
@@ -0,0 +1,87 @@
# retoor <retoor@molodetz.nl>
import time
from playwright.sync_api import expect
from tests.conftest import BASE_URL, assert_no_horizontal_overflow
def _create(page, title, visibility=None):
page.goto(f"{BASE_URL}/projects", wait_until="domcontentloaded")
page.locator("#create-project-btn").click()
page.fill("#title", title)
page.fill("#description", "visibility e2e project")
if visibility:
page.select_option("#project-visibility", visibility)
page.click("button:has-text('Create Project')")
page.wait_for_url(f"{BASE_URL}/projects/*", wait_until="domcontentloaded")
return page.url
def _open_edit(page):
page.locator("[data-menu-label='Edit']").first.evaluate("el => el.click()")
def _edit_visibility(page, url, value):
page.goto(url, wait_until="domcontentloaded")
_open_edit(page)
page.select_option("#edit-project-visibility", value)
page.locator("#edit-project-modal button.btn-primary").click()
page.wait_for_url(url, wait_until="domcontentloaded")
def _listed(page, title):
page.goto(f"{BASE_URL}/projects?search={title}", wait_until="domcontentloaded")
return page.locator(f"text={title}").count() > 0
def _title(prefix):
return f"{prefix}{int(time.time() * 1000)}"
def test_project_create_form_offers_the_three_visibility_choices(alice):
page, _ = alice
page.goto(f"{BASE_URL}/projects", wait_until="domcontentloaded")
page.locator("#create-project-btn").click()
options = page.locator("#project-visibility option")
assert options.all_text_contents() == ["Published", "Hidden", "Offline"]
expect(page.locator("#project-visibility")).to_have_value("published")
def test_project_created_offline_is_only_visible_to_its_owner(alice, bob):
page, _ = alice
other, _ = bob
title = _title("VisProjOffline")
url = _create(page, title, "offline")
assert not _listed(other, title)
other.goto(url, wait_until="domcontentloaded")
assert other.locator(f"h1:has-text('{title}')").count() == 0
page.goto(url, wait_until="domcontentloaded")
expect(page.locator(f"h1:has-text('{title}')").first).to_be_visible()
def test_project_edit_form_toggles_visibility(alice, bob):
page, _ = alice
other, _ = bob
title = _title("VisProjToggle")
url = _create(page, title)
assert _listed(other, title)
_edit_visibility(page, url, "hidden")
assert not _listed(other, title)
other.goto(url, wait_until="domcontentloaded")
expect(other.locator(f"h1:has-text('{title}')").first).to_be_visible()
_edit_visibility(page, url, "published")
assert _listed(other, title)
def test_project_edit_form_shows_the_current_status(alice):
page, _ = alice
url = _create(page, _title("VisProjCurrent"), "hidden")
page.goto(url, wait_until="domcontentloaded")
_open_edit(page)
expect(page.locator("#edit-project-visibility")).to_have_value("hidden")
def test_project_visibility_field_fits_a_phone(mobile_page):
page, _ = mobile_page
_create(page, _title("VisProjPhone"), "hidden")
assert_no_horizontal_overflow(page, ".project-page")
+5 -4
View File
@@ -14,6 +14,7 @@ from devplacepy.services.containers import store
from devplacepy.services.containers.workspace import flags, naming
from devplacepy.utils import make_combined_slug
from tests.conftest import BASE_URL
from tests.e2e.ui.components import _menu_item, _open_menu
EDITOR_CONTAINER_PORT = 8443
TRANSITION_TIMEOUT_MS = 8000
@@ -110,8 +111,8 @@ def test_project_page_hides_the_workspace_entry_point_from_a_non_owner(bob):
page.goto(
f"{BASE_URL}/projects/{project['slug']}", wait_until="domcontentloaded"
)
page.locator(".project-actions-more").click()
assert not page.locator(".context-menu-item:has-text('Workspace')").count()
_open_menu(page)
assert not _menu_item(page, "Workspace").count()
def test_direct_vscode_button_is_absent_while_the_workspace_is_stopped(alice):
@@ -148,8 +149,8 @@ def test_project_page_hides_the_workspace_entry_point_when_disabled(alice):
page.goto(
f"{BASE_URL}/projects/{project['slug']}", wait_until="domcontentloaded"
)
page.locator(".project-actions-more").click()
assert not page.locator(".context-menu-item:has-text('Workspace')").count()
_open_menu(page)
assert not _menu_item(page, "Workspace").count()
finally:
set_setting("workspace_enabled", "1")
assert _await_workspace_flag(project["slug"], row["api_key"], True)
+1 -1
View File
@@ -178,7 +178,7 @@ def test_landing_page_loads(page, app_server):
def test_landing_tagline(page, app_server):
page.goto(f"{BASE_URL}/", wait_until="domcontentloaded")
tagline = page.text_content("p")
tagline = page.text_content(".landing-hero p")
assert "Track industry shifts" in tagline
+33 -2
View File
@@ -7,9 +7,40 @@ def _open_project_with_delete(page, title):
proj_url = _make_project_ui(page, title)
slug = proj_url.rstrip("/").split("/")[-1]
return proj_url, slug
TRIGGER = "[data-action-menu-trigger]"
PANEL = "[data-action-menu-panel]"
def _open_menu(page):
# aria-expanded can lag behind the popover, so the open state that counts
# is whether the panel shows.
page.wait_for_function(
"() => document.querySelector('[data-action-menu-panel]') !== null"
" || document.querySelector('[data-action-menu-trigger]') === null"
)
panel = page.locator(PANEL)
if panel.count() and panel.evaluate("(el) => el.matches(':popover-open')"):
return
page.click(TRIGGER)
page.wait_for_function(
"() => document.querySelector('[data-action-menu-panel]').matches(':popover-open')"
)
def _menu_item(page, label):
return page.locator(
f"{PANEL} [data-menu-action]:has-text('{label}'), "
f"{PANEL} [data-menu-action][data-menu-label='{label}']"
)
def _pick(page, label):
_open_menu(page)
_menu_item(page, label).first.click()
def _click_delete(page):
page.locator(".project-actions-more").click()
page.locator(".context-menu-item:has-text('Delete')").click()
_pick(page, "Delete")
def test_data_confirm_opens_custom_dialog(alice):